[GitHub] rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined

[GitBox <gi...@apache.org>]

rob05c commented on issue #2277: Allow the capture group for a route parameter to be defined
URL: https://github.com/apache/incubator-trafficcontrol/pull/2277#issuecomment-389339315
 
 
   I'm still not convinced this is worth the readability cost. Regex is hard to read. This makes the routes harder to read, and the router more complex, for what gain? 
   
   It's pretty common for HTTP dispatch to be in-order, I don't think it's unreasonable for developers to be required to understand that routes match in order. Or for the route to check the param type, with a helper, it's a single error check, like https://github.com/apache/incubator-trafficcontrol/pull/2256/files#diff-c99ae9948456bba1d5438e02608d7bc7R33

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services