You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/13 07:19:12 UTC

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #227: feat(memleak): remove mem leak in factory schedule task.

ShannonDing opened a new pull request #227: feat(memleak): remove mem leak in factory schedule task.
URL: https://github.com/apache/rocketmq-client-cpp/pull/227
 
 
   ## What is the purpose of the change
   
   feat(memleak): remove mem leak in factory schedule task.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #227: feat(memleak): remove mem leak in factory schedule task.

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #227: feat(memleak): remove mem leak in factory schedule task.
URL: https://github.com/apache/rocketmq-client-cpp/pull/227
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #227: feat(memleak): remove mem leak in factory schedule task.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #227: feat(memleak): remove mem leak in factory schedule task.
URL: https://github.com/apache/rocketmq-client-cpp/pull/227#issuecomment-573540716
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=h1) Report
   > Merging [#227](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/b50d99cae1bbaac24848ee668393f0568fa2e686?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #227      +/-   ##
   ==========================================
   - Coverage   51.88%   51.87%   -0.01%     
   ==========================================
     Files         174      174              
     Lines       10857    10858       +1     
   ==========================================
     Hits         5633     5633              
   - Misses       5224     5225       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `18.45% <0%> (ø)` | :arrow_up: |
   | [src/common/MQClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227/diff?src=pr&el=tree#diff-c3JjL2NvbW1vbi9NUUNsaWVudC5jcHA=) | `38.23% <0%> (-0.38%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=footer). Last update [b50d99c...f2b1a67](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/227?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services