You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/10 17:10:38 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #10031: chore(security): Renaming access methods
john-bodley opened a new pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031
### SUMMARY
This PR addresses the following:
1. Ensures consistent naming of the "access" methods for the security manager, i.e., previously we had methods named `can_access_all_queries` and `all_datasource_access` (not the singular "datasource"). The former is prefer as the return type is implied. The renaming is as follows:
- `all_datasource_access` -> `can_access_all_datasources` (plural)
- `all_database_access` -> `can_access_all_databases` (plural)
- `database_access` -> `can_acess_database`
- `schema_access` -> `can_access_schema`
- `datasource_access` -> `can_access_datasource`
2. Removes unnecessary checks, i.e., previous logic was in the form,
```python
if security_manager.database_access(database)or security_manager.all_datasource_access():
...
```
however the `database_access` method (now named `can_access_database`) first checks whether the user can access all datasources and thus the second check is irrelevant.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `9.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 59.48% -9.40%
==========================================
Files 584 400 -184
Lines 31058 12856 -18202
Branches 3180 3180
==========================================
- Hits 21393 7647 -13746
+ Misses 9555 5031 -4524
- Partials 110 178 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
=======================================
- Hits 21393 21392 -1
+ Misses 9555 9552 -3
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.89% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.33% <96.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.64%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 69.83% -0.65%
==========================================
Files 583 184 -399
Lines 31019 18180 -12839
Branches 3175 0 -3175
==========================================
- Hits 21861 12696 -9165
+ Misses 9049 5484 -3565
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.83% <95.65%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.85%`.
> The diff coverage is `95.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 65.61% -4.86%
==========================================
Files 583 583
Lines 31019 31016 -3
Branches 3175 3175
==========================================
- Hits 21861 20352 -1509
- Misses 9049 10486 +1437
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `69.99% <95.83%> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.00% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [152 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...3f813ca](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `4.83%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 64.04% -4.84%
==========================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
==========================================
- Hits 21393 19888 -1505
- Misses 9555 10988 +1433
- Partials 110 178 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.26% <96.00%> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [151 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.64%`.
> The diff coverage is `95.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 69.83% -0.65%
==========================================
Files 583 184 -399
Lines 31019 18179 -12840
Branches 3175 0 -3175
==========================================
- Hits 21861 12695 -9166
+ Misses 9049 5484 -3565
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `69.83% <95.83%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.65% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [414 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...3f813ca](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 68.65% -0.23%
==========================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
==========================================
- Hits 21393 21321 -72
- Misses 9555 9618 +63
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.15% <ø> (-0.68%)` | :arrow_down: |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.26% <96.00%> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 68.70% -1.78%
==========================================
Files 583 584 +1
Lines 31019 31051 +32
Branches 3175 3179 +4
==========================================
- Hits 21861 21333 -528
- Misses 9049 9603 +554
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.15% <ø> (-0.78%)` | :arrow_down: |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `67.34% <95.65%> (-2.73%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <66.66%> (-0.89%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `10.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
===========================================
- Coverage 70.47% 59.49% -10.99%
===========================================
Files 583 400 -183
Lines 31019 12854 -18165
Branches 3175 3179 +4
===========================================
- Hits 21861 7647 -14214
+ Misses 9049 5029 -4020
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [312 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `4.79%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 64.08% -4.80%
==========================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
==========================================
- Hits 21393 19901 -1492
- Misses 9555 10975 +1420
- Partials 110 178 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.33% <96.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [147 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...02dac5e](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 63.94% -4.94%
==========================================
Files 584 584
Lines 31058 31045 -13
Branches 3180 3180
==========================================
- Hits 21393 19853 -1540
- Misses 9555 11014 +1459
- Partials 110 178 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.10% <96.00%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.42%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
+ Coverage 70.47% 70.56% +0.08%
==========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
==========================================
- Hits 21861 9052 -12809
+ Misses 9049 3661 -5388
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.08% <ø> (-0.84%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.22% <0.00%> (-5.60%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...44ff419](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 68.69% -0.19%
==========================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
==========================================
- Hits 21393 21334 -59
- Misses 9555 9605 +50
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.15% <ø> (-0.68%)` | :arrow_down: |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.33% <96.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...1c0bb1d](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.38%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 64.09% -6.39%
==========================================
Files 583 584 +1
Lines 31019 31051 +32
Branches 3175 3179 +4
==========================================
- Hits 21861 19901 -1960
- Misses 9049 10972 +1923
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `67.34% <95.65%> (-2.73%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <66.66%> (-0.89%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.85%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 65.61% -4.86%
==========================================
Files 583 583
Lines 31019 31017 -2
Branches 3175 3175
==========================================
- Hits 21861 20353 -1508
- Misses 9049 10486 +1437
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `69.99% <95.65%> (-0.08%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [152 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 67.10% -1.78%
==========================================
Files 584 184 -400
Lines 31058 18189 -12869
Branches 3180 0 -3180
==========================================
- Hits 21393 12206 -9187
+ Misses 9555 5983 -3572
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `67.10% <96.00%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.42%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [415 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...02dac5e](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 68.88% 68.69% -0.19%
==========================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
==========================================
- Hits 21393 21333 -60
- Misses 9555 9606 +51
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.14% <ø> (-0.69%)` | :arrow_down: |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.33% <96.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...02dac5e](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642168684
@villebro I agree with your comment however we run into a name conflict issue per https://github.com/apache/incubator-superset/pull/10030#issuecomment-642165341.
Note at Airbnb we have a unit test which checks for possible changes in the base security manager (as well as `pylint` checks which ensures that method signatures are consistent) given the potential impact of the change, i.e., one may no longer be overriding the same method.
```python
import inspect
def test_sm_parity_public_methods() -> None:
def _methods(klass: SupersetSecurityManager) -> Set[str]:
return {
name
for name, _ in inspect.getmembers(klass, predicate=inspect.isfunction)
if not name.startswith("_")
}
assert _methods(AirbnbSecurityManager) == _methods(SupersetSecurityManager)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.84%`.
> The diff coverage is `95.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 65.63% -4.85%
==========================================
Files 583 583
Lines 31019 31007 -12
Branches 3175 3175
==========================================
- Hits 21861 20350 -1511
- Misses 9049 10479 +1430
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.01% <95.83%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.00% <100.00%> (-0.04%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...3f813ca](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 583 583
Lines 31019 31017 -2
Branches 3175 3175
=======================================
- Hits 21861 21860 -1
+ Misses 9049 9048 -1
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.93% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.06% <95.65%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **increase** coverage by `0.54%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
+ Coverage 70.47% 71.01% +0.54%
==========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
==========================================
- Hits 21861 9110 -12751
+ Misses 9049 3608 -5441
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <ø> (-0.09%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | | |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
| [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | | |
| [superset/utils/dates.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZXMucHk=) | | |
| [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | | |
| [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | | |
| [...migrations/versions/fb13d49b72f9\_better\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mYjEzZDQ5YjcyZjlfYmV0dGVyX2ZpbHRlcnMucHk=) | | |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...44ff419](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `11.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
===========================================
- Coverage 70.47% 59.41% -11.06%
===========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
===========================================
- Hits 21861 7622 -14239
+ Misses 9049 5028 -4021
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [311 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `11.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
===========================================
- Coverage 70.47% 59.41% -11.06%
===========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
===========================================
- Hits 21861 7622 -14239
+ Misses 9049 5028 -4021
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [311 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/54c6ddbdb722fb73bf60f7c5a7a83d82523a90b9&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 584 584
Lines 31058 31054 -4
Branches 3180 3180
=======================================
- Hits 21393 21392 -1
+ Misses 9555 9552 -3
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.89% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.48% <ø> (ø)` | |
| #python | `67.33% <96.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (-0.08%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [54c6ddb...02dac5e](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `1.58%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 68.89% -1.59%
==========================================
Files 583 584 +1
Lines 31019 31051 +32
Branches 3175 3179 +4
==========================================
- Hits 21861 21392 -469
- Misses 9049 9549 +500
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.90% <ø> (-0.02%)` | :arrow_down: |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `67.34% <95.65%> (-2.73%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <66.66%> (-0.89%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.52%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 63.95% -6.53%
==========================================
Files 583 584 +1
Lines 31019 31042 +23
Branches 3175 3179 +4
==========================================
- Hits 21861 19853 -2008
- Misses 9049 11011 +1962
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `67.11% <95.65%> (-2.96%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <66.66%> (-1.10%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [170 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.95%`.
> The diff coverage is `95.83%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 65.52% -4.96%
==========================================
Files 583 583
Lines 31019 31007 -12
Branches 3175 3175
==========================================
- Hits 21861 20317 -1544
- Misses 9049 10512 +1463
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `69.83% <95.83%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.65% <100.00%> (-0.39%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [162 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...3f813ca](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `11.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
===========================================
- Coverage 70.47% 59.41% -11.06%
===========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
===========================================
- Hits 21861 7622 -14239
+ Misses 9049 5028 -4021
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [310 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...5ab9579](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `0.20%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 70.26% -0.21%
==========================================
Files 583 583
Lines 31019 31017 -2
Branches 3175 3175
==========================================
- Hits 21861 21795 -66
- Misses 9049 9107 +58
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.08% <ø> (-0.85%)` | :arrow_down: |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `70.06% <95.65%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.27% <80.00%> (ø)` | |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `6.37%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 64.10% -6.38%
==========================================
Files 583 584 +1
Lines 31019 31042 +23
Branches 3175 3179 +4
==========================================
- Hits 21861 19899 -1962
- Misses 9049 10965 +1916
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.49% <ø> (+0.07%)` | :arrow_up: |
| #python | `67.36% <95.65%> (-2.71%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <66.66%> (-0.89%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.04% <100.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [160 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...58fed86](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `4.95%`.
> The diff coverage is `95.65%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
==========================================
- Coverage 70.47% 65.52% -4.96%
==========================================
Files 583 583
Lines 31019 31008 -11
Branches 3175 3175
==========================================
- Hits 21861 20318 -1543
- Misses 9049 10512 +1463
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `69.83% <95.65%> (-0.24%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `96.55% <ø> (-0.12%)` | :arrow_down: |
| [superset/views/dashboard/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL2ZpbHRlcnMucHk=) | `95.23% <ø> (-0.22%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `76.06% <80.00%> (-0.22%)` | :arrow_down: |
| [superset/charts/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2ZpbHRlcnMucHk=) | `95.45% <100.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.69% <100.00%> (-0.35%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.47% <100.00%> (ø)` | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZGVjb3JhdG9ycy5weQ==) | `96.15% <100.00%> (ø)` | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `90.69% <100.00%> (ø)` | |
| ... and [163 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...59d6fed](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642147358
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=h1) Report
> Merging [#10031](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e17da58a39fb5726b7a81d9bd751e11ebc33b702&el=desc) will **decrease** coverage by `11.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10031 +/- ##
===========================================
- Coverage 70.47% 59.41% -11.06%
===========================================
Files 583 399 -184
Lines 31019 12828 -18191
Branches 3175 3175
===========================================
- Hits 21861 7622 -14239
+ Misses 9049 5028 -4021
- Partials 109 178 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.41% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [310 more](https://codecov.io/gh/apache/incubator-superset/pull/10031/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=footer). Last update [e17da58...44ff419](https://codecov.io/gh/apache/incubator-superset/pull/10031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley edited a comment on pull request #10031: chore(security): Renaming access methods
Posted by GitBox <gi...@apache.org>.
john-bodley edited a comment on pull request #10031:
URL: https://github.com/apache/incubator-superset/pull/10031#issuecomment-642168684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org