You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 20:14:44 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #7484: Use neutral wording for selecting and deselecting rules

kszucs commented on a change in pull request #7484:
URL: https://github.com/apache/arrow/pull/7484#discussion_r442477672



##########
File path: cpp/build-support/cpplint.py
##########
@@ -4008,9 +4008,9 @@ def CheckTrailingSemicolon(filename, clean_lines, linenum, error):
 
   # Block bodies should not be followed by a semicolon.  Due to C++11
   # brace initialization, there are more places where semicolons are
-  # required than not, so we use a whitelist approach to check these
-  # rather than a blacklist.  These are the places where "};" should
-  # be replaced by just "}":
+  # required than not, so we use explicitly list the allowed rules

Review comment:
       It's rarely updated so I think it's ok to edit it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org