You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:21:05 UTC
[GitHub] [spark] gatorsmile commented on a change in pull request #29202: [SPARK-32406][SQL] Make RESET syntax support single configuration reset
gatorsmile commented on a change in pull request #29202:
URL: https://github.com/apache/spark/pull/29202#discussion_r462053894
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
##########
@@ -166,15 +166,21 @@ object SetCommand {
* via [[SetCommand]] will get reset to default value. Command that runs
* {{{
* reset;
+ * reset spark.sql.session.timeZone;
* }}}
*/
-case object ResetCommand extends RunnableCommand with IgnoreCachedData {
+case class ResetCommand(config: Option[String]) extends RunnableCommand with IgnoreCachedData {
override def run(sparkSession: SparkSession): Seq[Row] = {
val conf = sparkSession.sessionState.conf
- conf.clear()
- sparkSession.sparkContext.conf.getAll.foreach { case (k, v) =>
- conf.setConfString(k, v)
+ val defaults = sparkSession.sparkContext.conf
+ config match {
+ case Some(key) =>
+ conf.unsetConf(key)
+ defaults.getOption(key).foreach(conf.setConfString(key, _))
Review comment:
Could you try some SQL conf whose default is NONE? For example, spark.sql.optimizer.excludedRules?
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala
##########
@@ -166,15 +166,21 @@ object SetCommand {
* via [[SetCommand]] will get reset to default value. Command that runs
* {{{
* reset;
+ * reset spark.sql.session.timeZone;
* }}}
*/
-case object ResetCommand extends RunnableCommand with IgnoreCachedData {
+case class ResetCommand(config: Option[String]) extends RunnableCommand with IgnoreCachedData {
override def run(sparkSession: SparkSession): Seq[Row] = {
val conf = sparkSession.sessionState.conf
- conf.clear()
- sparkSession.sparkContext.conf.getAll.foreach { case (k, v) =>
- conf.setConfString(k, v)
+ val defaults = sparkSession.sparkContext.conf
Review comment:
reset some static sql conf? for example, spark.sql.warehouse.dir? do we block it with a reasonable exception message?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org