You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/09/29 15:08:34 UTC
[GitHub] [drill] pjfanning opened a new pull request, #2663: DRILL-8323: upgrade commons-text to 1.10.0
pjfanning opened a new pull request, #2663:
URL: https://github.com/apache/drill/pull/2663
(and excel-streaming-reader that has a transitive dependency on it)
## Description
Some important bugs fixed in latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] pjfanning commented on a diff in pull request #2663: DRILL-8323: upgrade commons-text to 1.10.0
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #2663:
URL: https://github.com/apache/drill/pull/2663#discussion_r983816977
##########
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestStringDistanceFunctions.java:
##########
@@ -59,15 +59,15 @@ public void testJaccardDistance() throws Exception {
double result = queryBuilder()
.sql("select jaccard_distance( 'Big car', 'red car' ) as distance FROM (VALUES(1))")
.singletonDouble();
- assertEquals(0.56, result, 0.0);
+ assertEquals(0.5555555555555556, result, 0.0);
}
@Test
public void testJaroDistance() throws Exception {
double result = queryBuilder()
.sql("select jaro_distance( 'Big car', 'red car' ) as distance FROM (VALUES(1))")
.singletonDouble();
- assertEquals(0.7142857142857143, result, 0.0);
+ assertEquals(0.2857142857142857, result, 0.0);
}
Review Comment:
change needed because of https://issues.apache.org/jira/browse/TEXT-191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2663: DRILL-8323: upgrade commons-text to 1.10.0
Posted by GitBox <gi...@apache.org>.
cgivre merged PR #2663:
URL: https://github.com/apache/drill/pull/2663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org