You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/06/22 19:23:03 UTC

Review Request 35733: DRILL-3203: Add support for impersonation in Hive storage plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35733/
-----------------------------------------------------------

Review request for drill.


Repository: drill-git


Description
-------

Please see https://issues.apache.org/jira/browse/DRILL-3203 for details.


Diffs
-----

  contrib/storage-hive/core/pom.xml 546fd7b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveAuthorizationHelper.java PRE-CREATION 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java 8a2e498 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java d0ea143 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveViewTable.java 1e02301 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java 83f250b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/metastore/DrillHiveMetaStoreClient.java PRE-CREATION 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/metastore/DrillHiveMetaStoreClientWithUGI.java PRE-CREATION 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/metastore/NonCloseableDrillHiveMSClientWithCaching.java PRE-CREATION 
  contrib/storage-hive/core/src/main/resources/bootstrap-storage-plugins.json 5c7174e 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestHiveImpersonationBase.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestStorageBasedHiveAuthorization.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java ea8d90f 
  contrib/storage-hive/core/src/test/resources/student.txt PRE-CREATION 
  contrib/storage-hive/core/src/test/resources/voter.txt PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 06f8088 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 6afce1a 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java a07f621 

Diff: https://reviews.apache.org/r/35733/diff/


Testing
-------

Added unittests to cover both storage based and SQL standard based authorizations in Hive. More unittests in chained impersonation are coming in next patch.


Thanks,

Venki Korukanti


Re: Review Request 35733: DRILL-3203: Add support for impersonation in Hive storage plugin

Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35733/
-----------------------------------------------------------

(Updated June 24, 2015, 12:16 p.m.)


Review request for drill.


Repository: drill-git


Description
-------

Please see https://issues.apache.org/jira/browse/DRILL-3203 for details.


Diffs (updated)
-----

  contrib/storage-hive/core/pom.xml 546fd7b 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java PRE-CREATION 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveAuthorizationHelper.java PRE-CREATION 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java 8a2e498 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveTable.java d0ea143 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/DrillHiveViewTable.java 1e02301 
  contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveSchemaFactory.java 83f250b 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/hive/HiveTestUtilities.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/BaseTestHiveImpersonation.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestSqlStdBasedAuthorization.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/TestStorageBasedHiveAuthorization.java PRE-CREATION 
  contrib/storage-hive/core/src/test/java/org/apache/drill/exec/store/hive/HiveTestDataGenerator.java ea8d90f 
  contrib/storage-hive/core/src/test/resources/student.txt PRE-CREATION 
  contrib/storage-hive/core/src/test/resources/voter.txt PRE-CREATION 
  exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 06f8088 
  exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java 0ba2426 
  exec/java-exec/src/main/java/org/apache/drill/exec/util/ImpersonationUtil.java 499b740 
  exec/java-exec/src/test/java/org/apache/drill/BaseTestQuery.java a07f621 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/BaseTestImpersonation.java 56b7bde 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationDisabledWithMiniDFS.java 6c3b96f 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationMetadata.java 27e737d 
  exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java 14392c9 

Diff: https://reviews.apache.org/r/35733/diff/


Testing
-------

Added unittests to cover both storage based and SQL standard based authorizations in Hive. More unittests in chained impersonation are coming in next patch.


Thanks,

Venki Korukanti