[jira] [Commented] (MPLUGIN-431) Remove deprecated items from new maven-plugin-report-plugin

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPLUGIN-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624694#comment-17624694 ] 

ASF GitHub Bot commented on MPLUGIN-431:
----------------------------------------

gnodet commented on code in PR #160:
URL: https://github.com/apache/maven-plugin-tools/pull/160#discussion_r1006080205


##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##########
@@ -107,7 +107,11 @@ else if ( !goalPrefix.equals( defaultGoalPrefix ) )
     static String getDefaultGoalPrefix( MavenProject project )
     {
         String defaultGoalPrefix;
-        if ( "maven-plugin".equalsIgnoreCase( project.getArtifactId() ) )
+        if ( "maven-plugin-report-plugin".equalsIgnoreCase( project.getArtifactId() ) )
+        {
+            defaultGoalPrefix = "plugin-report";

Review Comment:
   Is that needed ? I forced it at https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-report-plugin/pom.xml#L182





> Remove deprecated items from new maven-plugin-report-plugin
> -----------------------------------------------------------
>
>                 Key: MPLUGIN-431
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-431
>             Project: Maven Plugin Tools
>          Issue Type: Task
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)