You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/12 15:15:55 UTC
[GitHub] [netbeans-nbpackage] ebarboni opened a new pull request, #13: testing package of notice
ebarboni opened a new pull request, #13:
URL: https://github.com/apache/netbeans-nbpackage/pull/13
this is only on step.
NOTICE left intact BINARY_NOTICE changed to 2023 to see what's get in.
To me seems bin are ok, srcs are ok but read from NOTICE
jar is reading from the bundled apache jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] ebarboni commented on pull request #13: testing package of notice
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #13:
URL: https://github.com/apache/netbeans-nbpackage/pull/13#issuecomment-1386834798
sorry to not followup but there is two NOTICE that are different the one in root the other is BINARY_NOTICE to check what is used.
seems wrong notice is used if not excluded (no overwrite maybe)
<excludes>
<exclude>NOTICE*</exclude>
</excludes>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] ebarboni closed pull request #13: testing package of notice
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni closed pull request #13: testing package of notice
URL: https://github.com/apache/netbeans-nbpackage/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net commented on pull request #13: testing package of notice
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #13:
URL: https://github.com/apache/netbeans-nbpackage/pull/13#issuecomment-1380954099
Both NOTICE and BINARY_NOTICE should be updated. There is no need to exclude NOTICE - it's not picked up anyway. BINARY_NOTICE is copied to NOTICE in the bin zip.
Problem is with `nbpackage-1.0-beta3-SNAPSHOT.jar` and `nbpackage-1.0-beta3-SNAPSHOT-sources.jar`. Both have a NOTICE file in META-INF that is not the one from the repository. That has additional copyright notices.
Sources doesn't seem to deploy to snapshots? Only built with -Papache-release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] neilcsmith-net commented on pull request #13: testing package of notice
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #13:
URL: https://github.com/apache/netbeans-nbpackage/pull/13#issuecomment-1386853842
`NOTICE` in root is the source notice (includes additional source copyrights). The `BINARY_NOTICE` is the additional copyrights with binary dependencies. Similar to IDE `NOTICE` and `notice-stub`.
The notice added in the META-INF should be the source / root one. It is not.
This isn't the issue I meant in the meeting btw. This only needs fixing to release to Maven - not an issue for snapshots usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-nbpackage] ebarboni commented on pull request #13: testing package of notice
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #13:
URL: https://github.com/apache/netbeans-nbpackage/pull/13#issuecomment-1449896376
trying to be complete
`mvn clean install -Papache-release` prepare
- nbpackage-1.0....-bin.tar.gz having **notice** from `src/assembly/bin/BINARY_NOTICE`
- nbpackage-1.0....-bin.zip having notice from `src/assembly/bin/BINARY_NOTICE`
- nbpackage-1.0....-javadoc.jar having **notice** autogenerated
- nbpackage-1.0....-sources.jar having **notice** autogenerated
- nbpackage-1.0....-jar having **notice** autogenerated
- nbpackage-1.0....-source-release.zip having **notice** from `NOTICE`
- nbpackage-1.0....-src.tar.gz having **notice** from `NOTICE`
- nbpackage-1.0....-src.zip having **notice** from `NOTICE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists