You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/15 06:47:13 UTC

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`

surekhasaharan commented on a change in pull request #8059: Refactoring to use `CollectionUtils.mapValues`
URL: https://github.com/apache/incubator-druid/pull/8059#discussion_r303293112
 
 

 ##########
 File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
 ##########
 @@ -266,6 +266,7 @@ protected SeekableStreamIndexTaskIOConfig createTaskIoConfig(
 
 
   @Override
+  @SuppressWarnings("SSBasedInspection")
 
 Review comment:
   ah, so i suppressed this, since the `valueMapper` function of `CollectionUtils.mapValues()` is not independent in this situation and needs map's key. May be there is a way around this, but was not clear to me, let me know if you have any suggestion so that i can remove the suppression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org