You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/22 07:51:53 UTC

[GitHub] [camel-k] nicolaferraro opened a new pull request #1421: Fix knative sources

nicolaferraro opened a new pull request #1421:
URL: https://github.com/apache/camel-k/pull/1421


   <!-- Description -->
   
   Fix #1419
   
   @lburgazzoli this adds the required libs and capabilities whenever the `knative-source` interceptor is used. I don't think we should add a capability to avoid naming the libs directly, or do we?
   
   It also add a compatibiity hack to transform the old loader to an interceptor in order for next release to work with all currently released versions of Knative (I'll fix it in Knative 0.15).
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] lburgazzoli commented on issue #1421: Fix knative sources

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1421:
URL: https://github.com/apache/camel-k/pull/1421#issuecomment-617618666


   > Fix #1419
   > 
   > @lburgazzoli this adds the required libs and capabilities whenever the `knative-source` interceptor is used. I don't think we should add a capability to avoid naming the libs directly, or do we?
   > 
   
   At the moment it is fine to have "hardcoded" dependencies but as long term it would be better to switch to capabilities as it it make it easier to support a range of runtime versions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org