You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignacio Mulas <no...@github.com> on 2014/01/22 15:47:47 UTC
[jclouds] Update glance's endpoint for unit tests (#258)
Update the keystone unit test and endpoint file in order to achieve compatibility with glance v2 unit tests
You can merge this Pull Request by running:
git pull https://github.com/sallum/jclouds glance-endpoint
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/258
-- Commit Summary --
* Update glance's endpoint for unit tests
-- File Changes --
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAccessTest.java (2)
M apis/openstack-keystone/src/test/resources/keystoneAuthResponse.json (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/258.patch
https://github.com/jclouds/jclouds/pull/258.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #981](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/981/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-33031640
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignacio Mulas <no...@github.com>.
This fix is makes sense for the pull request jclouds/jclouds-labs-openstack#77 which combines v1 and v2. I'll dedicate time to finish it and finally merge it. Once that is in good shape, this will be needed. :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44463317
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Andrew Phillips <no...@github.com>.
> @@ -71,7 +71,7 @@
> "endpoints": [
> {
> "tenantName": "40806637803162",
> - "publicURL": "https://glance.jclouds.org:9292/v1.0",
> + "publicURL": "https://glance.jclouds.org:9292",
Is this a "real" response? I.e. does the server actually send this back? Or does the "real" server response contain a version (either v1.0 or v2.0)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258/files#r9077386
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Andrew Phillips <no...@github.com>.
> Seems like a simple test fix. Should be ok?
I think the question revolved more around the discussion of whether we're losing some test coverage if we assume here that the Glance endpoint will
* come back with a version, as opposed to without (which apparently is also a valid response)
* come back with a `/v1.0` suffix only
If we're happy that we not going to be missing a test case as a result of this, then +1 from me too.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44347207
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -71,7 +71,7 @@
> "endpoints": [
> {
> "tenantName": "40806637803162",
> - "publicURL": "https://glance.jclouds.org:9292/v1.0",
> + "publicURL": "https://glance.jclouds.org:9292",
Any update on this @sallum ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258/files#r9687881
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignasi Barrera <no...@github.com>.
/cc @jdaggett @zack-shoylev @everett-toews
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44246546
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Everett Toews <no...@github.com>.
During release week we like to do a little house cleaning in the jclouds world. That means sweeping out the pull request queue.
This PR is over 6 months old. Please update us on its status here. If we don't hear anything, we will take that as lazy consensus that the PR is no longer relevant and it will be closed on Friday, Aug 8.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-50782497
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignacio Mulas <no...@github.com>.
> @@ -71,7 +71,7 @@
> "endpoints": [
> {
> "tenantName": "40806637803162",
> - "publicURL": "https://glance.jclouds.org:9292/v1.0",
> + "publicURL": "https://glance.jclouds.org:9292",
This change on the endpoints is to ensure that the unit tests of glance v1 and v2 are valid. With this change in place, all the unit tests from the pull request jclouds/jclouds-labs-openstack#77 should work properly.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258/files#r10192267
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignasi Barrera <no...@github.com>.
It's been a while. I assume it is safe to merge this PR then, @sallum ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-43721260
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #754](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/754/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-33033618
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Jeremy Daggett <no...@github.com>.
As previous stated, this PR is superceded by work being done in jclouds-labs-openstack [PR 77](https://github.com/jclouds/jclouds-labs-openstack/pull/77). Closing.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-51815482
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Ignacio Mulas <no...@github.com>.
> @@ -71,7 +71,7 @@
> "endpoints": [
> {
> "tenantName": "40806637803162",
> - "publicURL": "https://glance.jclouds.org:9292/v1.0",
> + "publicURL": "https://glance.jclouds.org:9292",
That can be a real response if you have your endpoints configure like that. Do not know if the default value contains the version or not though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258/files#r9084298
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Andrew Phillips <no...@github.com>.
> Once that is in good shape, this will be needed. :)
Thanks for explaining, @sallum! So if I understand correctly, this one can wait until jclouds/jclouds-labs-openstack#77 is ready?
Will that PR also include test cases to see what happens if the server returns `/v2.0` endpoint URLs, and URLs with no endpoint version suffix?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44616495
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Andrew Phillips <no...@github.com>.
@nacx: Worth asking Zack, Everett or Jeremy to also take a quick look?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44230923
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Zack Shoylev <no...@github.com>.
Seems like a simple test fix. Should be ok?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#issuecomment-44346388
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Andrew Phillips <no...@github.com>.
> @@ -71,7 +71,7 @@
> "endpoints": [
> {
> "tenantName": "40806637803162",
> - "publicURL": "https://glance.jclouds.org:9292/v1.0",
> + "publicURL": "https://glance.jclouds.org:9292",
That's fine, then. Just wanted to make sure the JSON we're using is realistic. Are we adding tests in any place to ensure the new code can handle /v1.0 vs. /v2.0 results from the server? Or is that in https://github.com/jclouds/jclouds-labs-openstack/pull/77?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258/files#r9085062
Re: [jclouds] Update glance's endpoint for unit tests (#258)
Posted by Jeremy Daggett <no...@github.com>.
Closed #258.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/258#event-151494559