[GitHub] [incubator-superset] mistercrunch commented on pull request #10942: fix: setting specific exceptions common/query_context.py

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #10942:
URL: https://github.com/apache/incubator-superset/pull/10942#issuecomment-694641986


   I think `broad-except` is totally ok sometimes. A clear example is with external database calls when we support multiple engines. There's almost no way to know ahead of time what any given driver will raise. DBAPI isn't prescriptive enough to enable that, and even if it were implementations may diverge from the the prescribed way. 
   
   Personally I'd recommend adding `broad-except` to the global allow-list, at list for now. 
   
   If really we wanted to push this, we could make sure to have consistent logging on broad exceptions and dig into logs to find what's actually been raised and catch the right thing and provide a better error message. But I think there's much bigger fish to catch at this time!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org