You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/25 23:49:13 UTC
Review Request 42750: Used `std::any_of` instead of `std::count_if`
when validating IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This makes the intent slightly clearer. In principle it should save a
few cycles as well, but nothing significant. Also, clarify the name of
a helper function.
Diffs
-----
src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07
Diff: https://reviews.apache.org/r/42750/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 42750: Used `std::any_of` instead of
`std::count_if` when validating IDs.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/#review116215
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42750]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 25, 2016, 10:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42750/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 10:49 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes the intent slightly clearer. In principle it should save a
> few cycles as well, but nothing significant. Also, clarify the name of
> a helper function.
>
>
> Diffs
> -----
>
> src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07
>
> Diff: https://reviews.apache.org/r/42750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42750: Used `std::any_of` instead of
`std::count_if` when validating IDs.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/#review117626
-----------------------------------------------------------
Ship it!
Ship It!
- Joerg Schad
On Jan. 25, 2016, 10:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42750/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 10:49 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes the intent slightly clearer. In principle it should save a
> few cycles as well, but nothing significant. Also, clarify the name of
> a helper function.
>
>
> Diffs
> -----
>
> src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07
>
> Diff: https://reviews.apache.org/r/42750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42750: Used `std::any_of` instead of
`std::count_if` when validating IDs.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42750/#review117681
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Jan. 25, 2016, 10:49 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42750/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2016, 10:49 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This makes the intent slightly clearer. In principle it should save a
> few cycles as well, but nothing significant. Also, clarify the name of
> a helper function.
>
>
> Diffs
> -----
>
> src/master/validation.cpp f2bc1bad79e3b0812c019be3774cd65b58ea2d07
>
> Diff: https://reviews.apache.org/r/42750/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>