[jira] [Comment Edited] (SENTRY-339) Remove PrivilegeName column and constructPrivilegeName() function

["Dapeng Sun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064487#comment-14064487 ] 

Dapeng Sun edited comment on SENTRY-339 at 7/17/14 2:24 AM:
------------------------------------------------------------

Hi [~asuresh]
It’s great, I'm agreed with you.
I have some question about the patch:
1. I think we may need define a composite unique index key in jdo.
{code:xml|borderStyle=solid}
<class name="MSentryPrivilege" ...>
<field name="...">
    ...
</field>
<index name="PrivilegeIndex" unique="true">
    <field name="serverName"/>
    <field name="dbName"/>
    ......
</index>
</class>
{code}
2. for the thrift api {{sentry_policy_service.thrift}}, I'm not an expert about thrift, My question is 
if {{action}} need set "" by default, need the {{grantorPrincipal}} set one?

Please correct me if I misunderstood.

Regards
Dapeng


was (Author: dapengsun):
Hi [~asuresh]
It’s great, I'm agreed with you.
I have some question about the patch:
1. I think we may need define a composite unique index key in jdo.
<index name="PrivilegeIndex" unique="true">
        <field name="serverName"/>
        <field name="dbName"/>
        ......
</index>
2. for the thrift api "sentry_policy_service.thrift", I'm not an expert about thrift, My question is 
if action need set "" by default, need the grantorPrincipal set one?

Please correct me if I misunderstood.

Regards
Dapeng

> Remove PrivilegeName column and constructPrivilegeName() function
> -----------------------------------------------------------------
>
>                 Key: SENTRY-339
>                 URL: https://issues.apache.org/jira/browse/SENTRY-339
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: db_policy_store
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: SENTRY-339.1.patch, SENTRY-339.2.patch
>
>
> The {{privilegeName}} column in the Privilege table was initially created to enforce uniqueness of Privileges with same server+db+table+uri+action. This can be done using composite unique key constraint in the underlying db.
> It would also cleanup the Sentry Store codebase a bit.. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)