You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/28 15:51:14 UTC
[GitHub] [airflow-site] oripwk opened a new pull request #267: Remove JIRA from Community section
oripwk opened a new pull request #267:
URL: https://github.com/apache/airflow-site/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] zhongjiajie commented on a change in pull request #267: Remove JIRA from Community section
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #267:
URL: https://github.com/apache/airflow-site/pull/267#discussion_r417029003
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -73,10 +72,9 @@
{{< accordion title="Fix a bug" description="We don’t like bugs. If you found one please tell us as soon as possible using steps below." logo_path="icons/fix-bug-icon.svg" >}}
<ol class="counter-blue mx-auto">
- <li>Create account at Airflow JIRA <a href="https://issues.apache.org">[Sign up]</a></li>
+ <li>Create account at Github <a href="https://github.com/">[Sign up]</a></li>
Review comment:
```suggestion
<li>Create account at Github <a href="https://github.com">[Sign up]</a></li>
```
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -58,10 +58,9 @@
{{< accordion title="Add a new feature" description="There are two steps required to create feature request for Airflow." logo_path="icons/new-feature-icon.svg" >}}
<ol class="counter-blue mx-auto">
- <li>Create account at Airflow JIRA <a href="https://issues.apache.org">[Sign up]</a></li>
+ <li>Create account at Github <a href="https://github.com/">[Sign up]</a></li>
Review comment:
```suggestion
<li>Create account at Github <a href="https://github.com">[Sign up]</a></li>
```
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -29,7 +29,7 @@
</ol>
{{< /accordion >}}
- {{< accordion title="Report a bug" description="Use our [Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/) to create a ticket." logo_path="icons/bug-icon.svg" >}}
+ {{< accordion title="Report a bug" description="Use our [Github](https://github.com/apache/airflow/issues) to create a ticket." logo_path="icons/bug-icon.svg" >}}
Review comment:
Should we change to github issue icon here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] oripwk commented on a change in pull request #267: Remove JIRA from Community section
Posted by GitBox <gi...@apache.org>.
oripwk commented on a change in pull request #267:
URL: https://github.com/apache/airflow-site/pull/267#discussion_r417790990
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -29,7 +29,7 @@
</ol>
{{< /accordion >}}
- {{< accordion title="Report a bug" description="Use our [Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/) to create a ticket." logo_path="icons/bug-icon.svg" >}}
+ {{< accordion title="Report a bug" description="Use our [Github](https://github.com/apache/airflow/issues) to create a ticket." logo_path="icons/bug-icon.svg" >}}
Review comment:
I removed the JIRA icon from the footer, since Github icon is already in the footer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] zhongjiajie edited a comment on pull request #267: Remove JIRA from Community section
Posted by GitBox <gi...@apache.org>.
zhongjiajie edited a comment on pull request #267:
URL: https://github.com/apache/airflow-site/pull/267#issuecomment-620945692
FYI, I change your describe to target the exists issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] zhongjiajie commented on a change in pull request #267: Remove JIRA from Community section
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #267:
URL: https://github.com/apache/airflow-site/pull/267#discussion_r417701909
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -29,7 +29,7 @@
</ol>
{{< /accordion >}}
- {{< accordion title="Report a bug" description="Use our [Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/) to create a ticket." logo_path="icons/bug-icon.svg" >}}
+ {{< accordion title="Report a bug" description="Use our [Github](https://github.com/apache/airflow/issues) to create a ticket." logo_path="icons/bug-icon.svg" >}}
Review comment:
Oh, yeah, I make a mistake, could you change the footer too?
##########
File path: landing-pages/site/content/en/community/_index.html
##########
@@ -29,7 +29,7 @@
</ol>
{{< /accordion >}}
- {{< accordion title="Report a bug" description="Use our [Jira](https://issues.apache.org/jira/projects/AIRFLOW/issues/) to create a ticket." logo_path="icons/bug-icon.svg" >}}
+ {{< accordion title="Report a bug" description="Use our [Github](https://github.com/apache/airflow/issues) to create a ticket." logo_path="icons/bug-icon.svg" >}}
Review comment:
Oh, yeah, sorry about that. I make a mistake, could you change the footer too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-site] zhongjiajie commented on pull request #267: Remove JIRA from Community section
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #267:
URL: https://github.com/apache/airflow-site/pull/267#issuecomment-620945692
FYI, I change you describe to target the exists issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org