[Impala-ASF-CR] IMPALA-7212: Removes --use krpc flag and remove old DataStream services

["Michael Ho (Code Review)" <ge...@cloudera.org>]

Hello Sailesh Mukil, Joe McDonnell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/10835

to look at the new patch set (#4).

Change subject: IMPALA-7212: Removes --use_krpc flag and remove old DataStream services
......................................................................

IMPALA-7212: Removes --use_krpc flag and remove old DataStream services

This change removes the flag --use_krpc which allows users
to fall back to using Thrift based implementation of DataStream
services. This flag was originally added during development of
IMPALA-2567. It has served its purpose.

As we port more ImpalaInternalServices to use KRPC, it's becoming
increasingly burdensome to maintain parallel implementation of the
RPC handlers. Therefore, going forward, KRPC is always enabled.
This change removes the Thrift based implemenation of DataStreamServices
and also simplifies some of the tests which were skipped when KRPC
is disabled.

Testing done: core debug build.

Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3
---
M be/src/common/global-flags.cc
M be/src/exec/data-sink.cc
M be/src/exec/exchange-node.cc
M be/src/exec/exchange-node.h
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr-kerberized-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/runtime/CMakeLists.txt
M be/src/runtime/backend-client.h
D be/src/runtime/data-stream-mgr-base.h
D be/src/runtime/data-stream-mgr.h
D be/src/runtime/data-stream-recvr-base.h
D be/src/runtime/data-stream-recvr.cc
D be/src/runtime/data-stream-recvr.h
D be/src/runtime/data-stream-sender.cc
D be/src/runtime/data-stream-sender.h
M be/src/runtime/data-stream-test.cc
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/runtime/fragment-instance-state.cc
M be/src/runtime/krpc-data-stream-mgr.cc
M be/src/runtime/krpc-data-stream-mgr.h
M be/src/runtime/krpc-data-stream-recvr.cc
M be/src/runtime/krpc-data-stream-recvr.h
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/scheduling/scheduler.cc
M be/src/service/data-stream-service.cc
M be/src/service/impala-internal-service.cc
M be/src/service/impala-internal-service.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M bin/run-all-tests.sh
M bin/start-impala-cluster.py
M common/thrift/ImpalaInternalService.thrift
M tests/common/custom_cluster_test_suite.py
M tests/common/skip.py
D tests/common/test_skip.py
M tests/conftest.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_rpc_exception.py
M tests/query_test/test_codegen.py
M tests/webserver/test_web_pages.py
44 files changed, 88 insertions(+), 2,143 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/10835/4
-- 
To view, visit http://gerrit.cloudera.org:8080/10835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfed200751508478a3d728a917448f2dabfc67c3
Gerrit-Change-Number: 10835
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>