[jira] Commented: (THRIFT-206) ruby required field validation requires before read instead of after

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12647464#action_12647464 ] 

Kevin Clark commented on THRIFT-206:
------------------------------------

I'm going to push, but is there a test that could have caught this that we're missing?

> ruby required field validation requires before read instead of after
> --------------------------------------------------------------------
>
>                 Key: THRIFT-206
>                 URL: https://issues.apache.org/jira/browse/THRIFT-206
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>         Attachments: thrift-206.patch
>
>
> There's a glaring bug in the original ruby required patch. The check of required field presence happens BEFORE deserializing, not after. This means unset required fields will always be null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.