Re: [PR] remove unnecessary import from generated Java classes [avro]

["nielsbasjes (via GitHub)" <gi...@apache.org>]

nielsbasjes commented on PR #2601:
URL: https://github.com/apache/avro/pull/2601#issuecomment-1926640762

   I did a quick double check of the codebase.
   
   The mentioned `schema.getElementType()` returns something which is a `Schema` and `GenericArray` is not a `Schema` (it is a `List` and a `GenericContainer`).
   So that specific line will not be a reason to keep it.
   
   However looking at [the commit that introduced it](https://github.com/apache/avro/commit/b4ede4b116b24b5308e8419504a73e02b7f7e406) I do see this for example: https://github.com/apache/avro/blob/d143d6262f7d6c688e695d1656f8609605835604/lang/java/compiler/src/main/velocity/org/apache/avro/compiler/specific/templates/java/classic/record.vm#L668-L673
   
   I'm not 100% sure but to me it seems possible this can happen if someone creates a (custom) logical type that uses this as the underlying javaType.
   
   If this is correct I do not want this change, I would rather have a demonstration that shows a usecase as part of the tests.
   
   @Fokko @opwvhk @martin-g WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org