You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "slfan1989 (via GitHub)" <gi...@apache.org> on 2025/12/14 07:41:05 UTC
[PR] Previously, equality delete predicates in DeleteFilter were case-insensitive. [iceberg-rust]
slfan1989 opened a new pull request, #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930
This change adds optional case-sensitive matching when binding equality delete predicates.
- Updated build_equality_delete_predicate to handle case-sensitive option.
- Added unit tests for case-sensitive equality deletes.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add case-sensitive support for equality deletes in DeleteFilter [iceberg-rust]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930#issuecomment-3650866572
@liurenjie1024 @Xuanwo Could you please help review this PR? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add case-sensitive support for equality deletes in DeleteFilter [iceberg-rust]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on code in PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930#discussion_r2621850134
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -104,6 +104,9 @@ pub struct FileScanTask {
#[serde(serialize_with = "serialize_not_implemented")]
#[serde(deserialize_with = "deserialize_not_implemented")]
pub name_mapping: Option<Arc<NameMapping>>,
+
+ /// Whether this scan task should treat column names as case-sensitive when binding predicates.
+ pub case_sensitive: bool,
Review Comment:
@liurenjie1024 Thank you very much for reviewing the code! Yes, the `case_sensitive` flag should indeed be set according to the `TableScan`. It represents a query-level property that needs to flow down through the plan `context` and `manifest` contexts into each `FileScanTask`, so that `DeleteFilter` can correctly bind equality delete predicates with the intended case-sensitivity.
The overall call chain is:
```
TableScan → PlanContext → ManifestFileContext → ManifestEntryContext → FileScanTask
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add case-sensitive support for equality deletes in DeleteFilter [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on code in PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930#discussion_r2618948112
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -104,6 +104,9 @@ pub struct FileScanTask {
#[serde(serialize_with = "serialize_not_implemented")]
#[serde(deserialize_with = "deserialize_not_implemented")]
pub name_mapping: Option<Arc<NameMapping>>,
+
+ /// Whether this scan task should treat column names as case-sensitive when binding predicates.
+ pub case_sensitive: bool,
Review Comment:
I think this should be set according `TableScan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add case-sensitive support for equality deletes in DeleteFilter [iceberg-rust]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930#issuecomment-3662948833
> Thanks @slfan1989 for this fix!
@liurenjie1024 Thanks a lot for reviewing the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add case-sensitive support for equality deletes in DeleteFilter [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 merged PR #1930:
URL: https://github.com/apache/iceberg-rust/pull/1930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org