You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2017/02/18 12:21:49 UTC

[GitHub] zeppelin pull request #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when...

GitHub user cloverhearts opened a pull request:

    https://github.com/apache/zeppelin/pull/2035

    [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch to personal mode

    ### What is this PR for?
    Note name is gone when switch to personal mode
    There was a part of the note name that was missing processing.
    So, I fixed it.
    
    
    ### What type of PR is it?
    Bug Fix - 0.7.1 related
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2049
    
    ### How should this be tested?
    You can personalized mode.
    and then plase refresh note view.
    and check to note name.
    
    ### Screenshots (if appropriate)
    #### before(problem)
    ![screenshot](https://issues.apache.org/jira/secure/attachment/12850799/record.gif)
    
    #### after (resolved)
    ![personal](https://cloud.githubusercontent.com/assets/10525473/23093214/31f0b0a6-f620-11e6-89ce-fabafa7c0000.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2049

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2035
    
----
commit eefd7fb0020c1f154b1652eace239f28efbd1e56
Author: CloverHearts <cl...@gmail.com>
Date:   2017-02-18T12:04:31Z

    missing get note name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/2035
  
    @jongyoul @Leemoonsoo 
    Could you review on this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2035


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2035
  
    Merge to master and branch-0.7 if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2035: [ZEPPELIN-2049 : z0.7.1] Note name is gone when switch...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2035
  
    Thanks @cloverhearts for the fix.
    
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---