You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 21:30:46 UTC

[GitHub] [helix] xyuanlu commented on a change in pull request #1723: Remove task requested state

xyuanlu commented on a change in pull request #1723:
URL: https://github.com/apache/helix/pull/1723#discussion_r630553887



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java
##########
@@ -138,42 +136,6 @@ void preHandleMessage() throws Exception {
       throw err.exception;
     }
 
-    // Reset the REQUESTED_STATE property if it exists.

Review comment:
       TFTR. Yes I think this is the case. When deploy new version to participants, TASK won't carry current state and will start over from init state.
   Since only TASK have requested state, this change should not have any impact on regular resources. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org