You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Sandro Boehme <sa...@gmx.de> on 2014/10/01 14:36:37 UTC

Sling content editor tool needed?

Hello,

I write this in response to my previous contribution proposal:
http://permalink.gmane.org/gmane.comp.apache.sling.devel/47292

To provide Apache Sling with a content editor like the JCRBrowser I 
would like to know what is needed to contribute the JCRBrowser to Sling. 
I could for example understand if more features are needed.
Or is the Sling JCRBrowser not needed at all?

What do you think?

Best,

Sandro



Am 29.09.14 18:47, schrieb Sandro Boehme:
 > Hello,
 >
 > at the adaptTo() conference I had the impression that the Apache Sling
 > community might be interested in the contribution of the Sling
 > JCRBrowser [1,2] to Apache Sling.
 > The Sling JCRBrowser is an editor for Sling resources that is build on
 > top of the Apache Sling API.
 > I will work on that in any case in the months to come according to the
 > roadmap I pointed out in my talk [3]. If there is interest in the
 > contribution I would change the namespace to Apache Sling. I would also
 > take the opportunity to rename the Sling JCRBrowser to Sedi the Sling
 > Editor. This changes would take place at GitHub prior submitting the
 > code to a Jira issue.
 > In case the contribution is accepted I will continue to work on the tool
 > at GitHub and send SVN patches as Jira tickets to Sling.
 > Of course I would be proud to directly develop for it as a Sling
 > committer if the Sling community decides that this is appropriate.
 > As I said in my talk [3] I might add some commercial add ons to the
 > Sling JCRBrowser / Sedi later on to be downloaded separately. This is
 > why it is important to be able to point users to such a website from
 > Sling. But judging from other Apache projects [4] I assume this is
 > probably not a problem.
 > I'm looking forward to your feedback!
 >
 > [1] - https://github.com/sandroboehme/jcrbrowser
 > [2] - http://www.jcrbrowser.org/sling/website/
 > [3] -
 > 
http://adapt.to/content/dam/adaptto/production/presentations/2014/adaptTo2014-The-Sling-JCRBrowser-Sandro-Boehme.pdf/_jcr_content/renditions/original.media_file.download_attachment.file/adaptTo2014-The-Sling-JCRBrowser-Sandro-Boehme.pdf 

 >
 > [4] - https://www.google.de/search?q=site%3Aapache.org+commercial
 >
 > Best,
 >
 > Sandro
 >


Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
I'm absolutely fine with that.

Am 01.10.14 15:20, schrieb Bertrand Delacretaz:
> On Wed, Oct 1, 2014 at 3:17 PM, Robert Munteanu <ro...@apache.org> wrote:
>> ...+1 for accepting this in contrib. To be clear, this would mean it
>> would not replace the current Sling Explorer from the launchpad
>> imediately...
>
> Agreed, no need to delete any code right now, we'll just let software
> darwinism do its job.
>
> -Bertrand
>


Re: Sling content editor tool needed?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Oct 1, 2014 at 3:17 PM, Robert Munteanu <ro...@apache.org> wrote:
> ...+1 for accepting this in contrib. To be clear, this would mean it
> would not replace the current Sling Explorer from the launchpad
> imediately...

Agreed, no need to delete any code right now, we'll just let software
darwinism do its job.

-Bertrand

Re: Sling content editor tool needed?

Posted by Robert Munteanu <ro...@apache.org>.
On Wed, Oct 1, 2014 at 3:43 PM, Bertrand Delacretaz
<bd...@apache.org> wrote:
>
> So IMO we should accept this contribution now (in contrib - not core
> for now) - what do others think?


+1 for accepting this in contrib. To be clear, this would mean it
would not replace the current Sling Explorer from the launchpad
imediately, but once we're happy with the feature set / stability we
can move it to 'core' and replace the current explorer.

Robert

Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Wonderful!
Yes, I will do the renaming at my codebase and then attaching the code 
to the Jira issue. This also makes it easier for me to send the patches 
as the names are equal.

Best,

Sandro

Am 01.10.14 17:22, schrieb Carsten Ziegeler:
> +1 to accept the contribution
>
> I guess we can sort out all technical issues once the contribution is done.
> However, I think the renaming should be done before so we can vote on a
> renamed source code base
>
> Carsten
>
> 2014-10-01 16:24 GMT+02:00 Sandro Boehme <sa...@gmx.de>:
>
>> Hi Dominik,
>>
>> thanks for your feedback! Please see my comments inline:
>>
>> Am 01.10.14 15:17, schrieb Dominik Süß:
>>
>>> Hi everyone,
>>>
>>> here my 2 cents about changes that I would like to see (had a short chat
>>> with Sandro at adaptTo() about that):
>>> * rename it and get rid of JCR in the name since it effectively is a
>>> resourceTreeBrowser
>>>
>> As I wrote in my original proposal I would like to rename the JCRBrowser
>> based on your hint at adaptTo(). I would like to keep it simple and name it
>> Sling Editor and to have a real name I thought about "Sedi" but it is in
>> use and the domains are taken. This is why I prefer "Sledi" now. It is
>> harder to pronounce but still uses the first chars of 'Sling Editor'. But
>> I'm still open for other suggestions.
>>
>>   * make sure to be compatible with all ResourceProviders through CRUD API
>>> (and blend out operations not available for ResourceProviders not
>>> supporting it)
>>>
>> For changing content I use the Sling POST servlet. I think this is
>> compatible with the ResourceProviders right?
>>
>>   * get rid of the Selectorbased ResourceDecorator pattern for the browser
>>> but implement a ResourceProvider which does the decorationion to make sure
>>> code can be properly secured for production instances and does not impact
>>> rendering of 3rd code at all.
>>>
>> You are right, the selector could not be used in the application anymore
>> because this would call the Sling JCRBrowser.
>>
>> I will find out how ResourceProvider/-Resolver work to change the tool
>> accordingly.
>>
>> Best,
>>
>> Sandro
>>
>>
>>
>>> If all of those points are met I guess this could really be something
>>> useful (especially when not basing on commercial varations that provide a
>>> browser) which can be included without having to worry that it actually
>>> interfers with the application.
>>>
>>> Cheers
>>> Dominik
>>>
>>> On Wed, Oct 1, 2014 at 3:06 PM, Sandro Boehme <sa...@gmx.de>
>>> wrote:
>>>
>>>   Hi Bertrand,
>>>>
>>>> Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
>>>>
>>>>   Hi Sandro,
>>>>>
>>>>> On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de>
>>>>> wrote:
>>>>>
>>>>>   ...To provide Apache Sling with a content editor like the JCRBrowser I
>>>>>> would
>>>>>> like to know what is needed to contribute the JCRBrowser to Sling. I
>>>>>> could
>>>>>> for example understand if more features are needed...
>>>>>>
>>>>>>
>>>>> IIUC your JCRBrowser is read-only at the moment?
>>>>>
>>>>>   beside showing content the Sling JCRBrowser can rename nodes and delete
>>>> single nodes and a list of selected nodes.
>>>>
>>>>    If yes adding create/update/delete functionality would be nice of
>>>>
>>>>> course, but I'm in favor of accepting your contribution in its present
>>>>> state so that you can benefit from this community's feedback to evolve
>>>>> it.
>>>>>
>>>>> As you're not a committer for now you'd need to submit patches to
>>>>> expand it, but that's the best way to become a committer, by showing
>>>>> us how you work and communicate based on a real project.
>>>>>
>>>>>   I'm absolutely fine with submitting patches.
>>>>
>>>>
>>>>   So IMO we should accept this contribution now (in contrib - not core
>>>>> for now) - what do others think?
>>>>>
>>>>> -Bertrand
>>>>>
>>>>>
>>>>>   Best,
>>>>
>>>> Sandro
>>>>
>>>>
>>>
>>
>
>


Re: Sling content editor tool needed?

Posted by Carsten Ziegeler <cz...@apache.org>.
+1 to accept the contribution

I guess we can sort out all technical issues once the contribution is done.
However, I think the renaming should be done before so we can vote on a
renamed source code base

Carsten

2014-10-01 16:24 GMT+02:00 Sandro Boehme <sa...@gmx.de>:

> Hi Dominik,
>
> thanks for your feedback! Please see my comments inline:
>
> Am 01.10.14 15:17, schrieb Dominik Süß:
>
>> Hi everyone,
>>
>> here my 2 cents about changes that I would like to see (had a short chat
>> with Sandro at adaptTo() about that):
>> * rename it and get rid of JCR in the name since it effectively is a
>> resourceTreeBrowser
>>
> As I wrote in my original proposal I would like to rename the JCRBrowser
> based on your hint at adaptTo(). I would like to keep it simple and name it
> Sling Editor and to have a real name I thought about "Sedi" but it is in
> use and the domains are taken. This is why I prefer "Sledi" now. It is
> harder to pronounce but still uses the first chars of 'Sling Editor'. But
> I'm still open for other suggestions.
>
>  * make sure to be compatible with all ResourceProviders through CRUD API
>> (and blend out operations not available for ResourceProviders not
>> supporting it)
>>
> For changing content I use the Sling POST servlet. I think this is
> compatible with the ResourceProviders right?
>
>  * get rid of the Selectorbased ResourceDecorator pattern for the browser
>> but implement a ResourceProvider which does the decorationion to make sure
>> code can be properly secured for production instances and does not impact
>> rendering of 3rd code at all.
>>
> You are right, the selector could not be used in the application anymore
> because this would call the Sling JCRBrowser.
>
> I will find out how ResourceProvider/-Resolver work to change the tool
> accordingly.
>
> Best,
>
> Sandro
>
>
>
>> If all of those points are met I guess this could really be something
>> useful (especially when not basing on commercial varations that provide a
>> browser) which can be included without having to worry that it actually
>> interfers with the application.
>>
>> Cheers
>> Dominik
>>
>> On Wed, Oct 1, 2014 at 3:06 PM, Sandro Boehme <sa...@gmx.de>
>> wrote:
>>
>>  Hi Bertrand,
>>>
>>> Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
>>>
>>>  Hi Sandro,
>>>>
>>>> On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de>
>>>> wrote:
>>>>
>>>>  ...To provide Apache Sling with a content editor like the JCRBrowser I
>>>>> would
>>>>> like to know what is needed to contribute the JCRBrowser to Sling. I
>>>>> could
>>>>> for example understand if more features are needed...
>>>>>
>>>>>
>>>> IIUC your JCRBrowser is read-only at the moment?
>>>>
>>>>  beside showing content the Sling JCRBrowser can rename nodes and delete
>>> single nodes and a list of selected nodes.
>>>
>>>   If yes adding create/update/delete functionality would be nice of
>>>
>>>> course, but I'm in favor of accepting your contribution in its present
>>>> state so that you can benefit from this community's feedback to evolve
>>>> it.
>>>>
>>>> As you're not a committer for now you'd need to submit patches to
>>>> expand it, but that's the best way to become a committer, by showing
>>>> us how you work and communicate based on a real project.
>>>>
>>>>  I'm absolutely fine with submitting patches.
>>>
>>>
>>>  So IMO we should accept this contribution now (in contrib - not core
>>>> for now) - what do others think?
>>>>
>>>> -Bertrand
>>>>
>>>>
>>>>  Best,
>>>
>>> Sandro
>>>
>>>
>>
>


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org

Re: Sling content editor tool needed?

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Sandro,

On Wed, Oct 1, 2014 at 11:21 PM, Sandro Boehme <sa...@gmx.de> wrote:
> ...I guess I should go for "oas.contenteditor" even if it is a bit lengthy.
> Because "oas.ce" is not really descriptive...

Both work for me, as you prefer!

-Bertrand

Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Ok, there might be script editors or something like that. This is why I 
actually like "Sling Content Editor" as it is more specific than "Sling 
Editor".
The question is just, how to name the packages and folders. Sling Health 
Checks uses "oas.hc" [1] as package name and Sling Testing Tools uses 
"oas.testing.tools" [2].
I guess I should go for "oas.contenteditor" even if it is a bit lengthy. 
Because "oas.ce" is not really descriptive.

[1] - 
http://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/healthcheck/samples/src/main/java/org/apache/sling/hc/
[2] - 
http://svn.apache.org/repos/asf/sling/trunk/testing/tools/src/main/java/org/apache/sling/testing/tools/

Best,

Sandro

Am 01.10.14 17:24, schrieb Bertrand Delacretaz:
> On Wed, Oct 1, 2014 at 4:24 PM, Sandro Boehme <sa...@gmx.de> wrote:
>> ...This is why I prefer "Sledi" now. It is harder to
>> pronounce but still uses the first chars of 'Sling Editor'. But I'm still
>> open for other suggestions....
>
> For other modules we have opted for plain descriptive names like
> "Sling Models", "Sling Health Checks", "Sling Testing Tools" etc., so
> if we want to keep this pattern (which I like) we might just go for
> "Sling Content Editor".
>
> -Bertrand
>


Re: Sling content editor tool needed?

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Sandro,

On Fri, Oct 3, 2014 at 3:02 PM, Sandro Boehme <sa...@gmx.de> wrote:
> ..."Sling Content Editor" would again refer to a JCR
> term and I would prefer to change the name to "Sling Resource Editor"...

Good idea - we want to promote the Resource concept as much as
possible, so I like your suggestion.

-Bertrand

Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Hi,

Am 01.10.14 17:24, schrieb Bertrand Delacretaz:
> On Wed, Oct 1, 2014 at 4:24 PM, Sandro Boehme <sa...@gmx.de> wrote:
>> ...This is why I prefer "Sledi" now. It is harder to
>> pronounce but still uses the first chars of 'Sling Editor'. But I'm still
>> open for other suggestions....
>
> For other modules we have opted for plain descriptive names like
> "Sling Models", "Sling Health Checks", "Sling Testing Tools" etc., so
> if we want to keep this pattern (which I like) we might just go for
> "Sling Content Editor".
>
> -Bertrand
>

after reading about resources in Sling I have the impression that the 
term "Content" is more used in Sling for JCR content while "Resource" 
would be the equivalent that abstracts from storage.
If that is correct the "Sling Content Editor" would again refer to a JCR 
term and I would prefer to change the name to "Sling Resource Editor".
Or are the terms "Content" and "Resource" really used interchangeable in 
Sling?

Best,

Sandro

Re: Sling content editor tool needed?

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Oct 1, 2014 at 4:24 PM, Sandro Boehme <sa...@gmx.de> wrote:
> ...This is why I prefer "Sledi" now. It is harder to
> pronounce but still uses the first chars of 'Sling Editor'. But I'm still
> open for other suggestions....

For other modules we have opted for plain descriptive names like
"Sling Models", "Sling Health Checks", "Sling Testing Tools" etc., so
if we want to keep this pattern (which I like) we might just go for
"Sling Content Editor".

-Bertrand

Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Hi Dominik,

thanks for your feedback! Please see my comments inline:

Am 01.10.14 15:17, schrieb Dominik Süß:
> Hi everyone,
>
> here my 2 cents about changes that I would like to see (had a short chat
> with Sandro at adaptTo() about that):
> * rename it and get rid of JCR in the name since it effectively is a
> resourceTreeBrowser
As I wrote in my original proposal I would like to rename the JCRBrowser 
based on your hint at adaptTo(). I would like to keep it simple and name 
it Sling Editor and to have a real name I thought about "Sedi" but it is 
in use and the domains are taken. This is why I prefer "Sledi" now. It 
is harder to pronounce but still uses the first chars of 'Sling Editor'. 
But I'm still open for other suggestions.

> * make sure to be compatible with all ResourceProviders through CRUD API
> (and blend out operations not available for ResourceProviders not
> supporting it)
For changing content I use the Sling POST servlet. I think this is 
compatible with the ResourceProviders right?

> * get rid of the Selectorbased ResourceDecorator pattern for the browser
> but implement a ResourceProvider which does the decorationion to make sure
> code can be properly secured for production instances and does not impact
> rendering of 3rd code at all.
You are right, the selector could not be used in the application anymore 
because this would call the Sling JCRBrowser.

I will find out how ResourceProvider/-Resolver work to change the tool 
accordingly.

Best,

Sandro

>
> If all of those points are met I guess this could really be something
> useful (especially when not basing on commercial varations that provide a
> browser) which can be included without having to worry that it actually
> interfers with the application.
>
> Cheers
> Dominik
>
> On Wed, Oct 1, 2014 at 3:06 PM, Sandro Boehme <sa...@gmx.de> wrote:
>
>> Hi Bertrand,
>>
>> Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
>>
>>> Hi Sandro,
>>>
>>> On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de>
>>> wrote:
>>>
>>>> ...To provide Apache Sling with a content editor like the JCRBrowser I
>>>> would
>>>> like to know what is needed to contribute the JCRBrowser to Sling. I
>>>> could
>>>> for example understand if more features are needed...
>>>>
>>>
>>> IIUC your JCRBrowser is read-only at the moment?
>>>
>> beside showing content the Sling JCRBrowser can rename nodes and delete
>> single nodes and a list of selected nodes.
>>
>>   If yes adding create/update/delete functionality would be nice of
>>> course, but I'm in favor of accepting your contribution in its present
>>> state so that you can benefit from this community's feedback to evolve
>>> it.
>>>
>>> As you're not a committer for now you'd need to submit patches to
>>> expand it, but that's the best way to become a committer, by showing
>>> us how you work and communicate based on a real project.
>>>
>> I'm absolutely fine with submitting patches.
>>
>>
>>> So IMO we should accept this contribution now (in contrib - not core
>>> for now) - what do others think?
>>>
>>> -Bertrand
>>>
>>>
>> Best,
>>
>> Sandro
>>
>


Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Hi Dominik and others,

now as some time passed I can tell about results and more concrete 
things. Please see my comments inline:

Am 01.10.14 15:17, schrieb Dominik Süß:
> Hi everyone,
>
> here my 2 cents about changes that I would like to see (had a short chat
> with Sandro at adaptTo() about that):
> * rename it and get rid of JCR in the name since it effectively is a
> resourceTreeBrowser
The JCRBrowser is renamed to Apache Sling Resource Editor. See the 
contribution ticket [1] and the latest source code at GitHub [2]

> * make sure to be compatible with all ResourceProviders through CRUD API
> (and blend out operations not available for ResourceProviders not
> supporting it)
 From reading the docs I think the Sling POST servlet that I use for 
nodes is operating on the Resource of the request.
For reading the nodes I use the Resource API as well.
But for reading properties I check if the resource is adaptable to a 
node. If it is, I use the JCR API for reading. If it isn't I adapt to a 
ValueMap and show its keys and values.
For changing properties I plan to use the Sling POST servlet as well.
I guess this is the best possible compatibility right?


> * get rid of the Selectorbased ResourceDecorator pattern for the browser
> but implement a ResourceProvider which does the decorationion to make sure
> code can be properly secured for production instances and does not impact
> rendering of 3rd code at all.
The code is changed now at GitHub [3] to use the ResourceProvider. This 
way the Sling Resource Editor does not depend on a selector and instead 
uses the root path element of the ResourceProvider. A URL looks like 
this now:
http://localhost:8080/reseditor/libs/sling/servlet/default.html
To secure it I guess one use the 'ResourceAccessSecurity'. Even though I 
still have to use a resource decorator.

I didn't overwrite the resource type in the resource wrapper that I use 
in the resource provider. Because then for example after every node in 
the tree the same type would show up and I couldn't distinguish between 
them anymore.
This is why I just added a marker [4] to the resources that went through 
my resource provider and I still use a resource decorator [5] to set the 
resource type depending if this marker is found. By doing it in the 
resource decorator the original resource types are preserved when 
accessing them in the JSP.

>
> If all of those points are met I guess this could really be something
> useful (especially when not basing on commercial varations that provide a
> browser) which can be included without having to worry that it actually
> interfers with the application.
I guess this way it doesn't interfere with an other application in the 
same Sling instance.

[1] - https://issues.apache.org/jira/browse/SLING-4001
[2] - https://github.com/sandroboehme/resourceeditor
[3] - 
https://github.com/sandroboehme/resourceeditor/tree/master/src/main/java/org/apache/sling/reseditor/resource
[4] - line 23 in 
https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/resource/ResourceTypeResourceWrapper.java 

[5] - line 73 in 
https://github.com/sandroboehme/resourceeditor/blob/master/src/main/java/org/apache/sling/reseditor/resource/ResourceProviderBasedResourceDecorator.java 


Best,

Sandro

Re: Sling content editor tool needed?

Posted by Dominik Süß <do...@gmail.com>.
Hi everyone,

here my 2 cents about changes that I would like to see (had a short chat
with Sandro at adaptTo() about that):
* rename it and get rid of JCR in the name since it effectively is a
resourceTreeBrowser
* make sure to be compatible with all ResourceProviders through CRUD API
(and blend out operations not available for ResourceProviders not
supporting it)
* get rid of the Selectorbased ResourceDecorator pattern for the browser
but implement a ResourceProvider which does the decorationion to make sure
code can be properly secured for production instances and does not impact
rendering of 3rd code at all.

If all of those points are met I guess this could really be something
useful (especially when not basing on commercial varations that provide a
browser) which can be included without having to worry that it actually
interfers with the application.

Cheers
Dominik

On Wed, Oct 1, 2014 at 3:06 PM, Sandro Boehme <sa...@gmx.de> wrote:

> Hi Bertrand,
>
> Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
>
>> Hi Sandro,
>>
>> On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de>
>> wrote:
>>
>>> ...To provide Apache Sling with a content editor like the JCRBrowser I
>>> would
>>> like to know what is needed to contribute the JCRBrowser to Sling. I
>>> could
>>> for example understand if more features are needed...
>>>
>>
>> IIUC your JCRBrowser is read-only at the moment?
>>
> beside showing content the Sling JCRBrowser can rename nodes and delete
> single nodes and a list of selected nodes.
>
>  If yes adding create/update/delete functionality would be nice of
>> course, but I'm in favor of accepting your contribution in its present
>> state so that you can benefit from this community's feedback to evolve
>> it.
>>
>> As you're not a committer for now you'd need to submit patches to
>> expand it, but that's the best way to become a committer, by showing
>> us how you work and communicate based on a real project.
>>
> I'm absolutely fine with submitting patches.
>
>
>> So IMO we should accept this contribution now (in contrib - not core
>> for now) - what do others think?
>>
>> -Bertrand
>>
>>
> Best,
>
> Sandro
>

Re: Sling content editor tool needed?

Posted by Sandro Boehme <sa...@gmx.de>.
Hi Bertrand,

Am 01.10.14 14:43, schrieb Bertrand Delacretaz:
> Hi Sandro,
>
> On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de> wrote:
>> ...To provide Apache Sling with a content editor like the JCRBrowser I would
>> like to know what is needed to contribute the JCRBrowser to Sling. I could
>> for example understand if more features are needed...
>
> IIUC your JCRBrowser is read-only at the moment?
beside showing content the Sling JCRBrowser can rename nodes and delete 
single nodes and a list of selected nodes.

> If yes adding create/update/delete functionality would be nice of
> course, but I'm in favor of accepting your contribution in its present
> state so that you can benefit from this community's feedback to evolve
> it.
>
> As you're not a committer for now you'd need to submit patches to
> expand it, but that's the best way to become a committer, by showing
> us how you work and communicate based on a real project.
I'm absolutely fine with submitting patches.

>
> So IMO we should accept this contribution now (in contrib - not core
> for now) - what do others think?
>
> -Bertrand
>

Best,

Sandro

Re: Sling content editor tool needed?

Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi Sandro,

On Wed, Oct 1, 2014 at 2:36 PM, Sandro Boehme <sa...@gmx.de> wrote:
> ...To provide Apache Sling with a content editor like the JCRBrowser I would
> like to know what is needed to contribute the JCRBrowser to Sling. I could
> for example understand if more features are needed...

IIUC your JCRBrowser is read-only at the moment?

If yes adding create/update/delete functionality would be nice of
course, but I'm in favor of accepting your contribution in its present
state so that you can benefit from this community's feedback to evolve
it.

As you're not a committer for now you'd need to submit patches to
expand it, but that's the best way to become a committer, by showing
us how you work and communicate based on a real project.

So IMO we should accept this contribution now (in contrib - not core
for now) - what do others think?

-Bertrand