You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by si...@apache.org on 2011/05/02 17:23:22 UTC
svn commit: r1098625 -
/lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java
Author: simonw
Date: Mon May 2 15:23:22 2011
New Revision: 1098625
URL: http://svn.apache.org/viewvc?rev=1098625&view=rev
Log:
LUCENE-3062: Fix test to be more tolerant and accept duplicates generated by randomRealisticUnicodeString
Modified:
lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java
Modified: lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java?rev=1098625&r1=1098624&r2=1098625&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java (original)
+++ lucene/dev/trunk/lucene/src/test/org/apache/lucene/util/TestBytesRefHash.java Mon May 2 15:23:22 2011
@@ -135,6 +135,7 @@ public class TestBytesRefHash extends Lu
public void testCompact() {
BytesRef ref = new BytesRef();
for (int j = 0; j < 2 * RANDOM_MULTIPLIER; j++) {
+ int numEntries = 0;
final int size = 797;
BitSet bits = new BitSet(size);
for (int i = 0; i < size; i++) {
@@ -143,13 +144,21 @@ public class TestBytesRefHash extends Lu
str = _TestUtil.randomRealisticUnicodeString(random, 1000);
} while (str.length() == 0);
ref.copy(str);
- bits.set(hash.add(ref));
-
+ final int key = hash.add(ref);
+ if (key < 0) {
+ assertTrue(bits.get((-key)-1));
+ } else {
+ assertFalse(bits.get(key));
+ bits.set(key);
+ numEntries++;
+ }
}
assertEquals(hash.size(), bits.cardinality());
+ assertEquals(numEntries, bits.cardinality());
+ assertEquals(numEntries, hash.size());
int[] compact = hash.compact();
- assertTrue(size < compact.length);
- for (int i = 0; i < size; i++) {
+ assertTrue(numEntries < compact.length);
+ for (int i = 0; i < numEntries; i++) {
bits.set(compact[i], false);
}
assertEquals(0, bits.cardinality());