You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/21 04:06:16 UTC

[GitHub] [iotdb] RYH61 commented on a diff in pull request #6735: [IOTDB-3880] Optimize asyncclientpool retry logic

RYH61 commented on code in PR #6735:
URL: https://github.com/apache/iotdb/pull/6735#discussion_r926233056


##########
confignode/src/main/java/org/apache/iotdb/confignode/client/async/handlers/AbstractRetryHandler.java:
##########
@@ -22,19 +22,15 @@
 import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
 import org.apache.iotdb.confignode.client.DataNodeRequestType;
 
-import java.util.Map;
+import java.util.List;
 import java.util.concurrent.CountDownLatch;
 
 public abstract class AbstractRetryHandler {
 
-  protected final int index;
-
   protected CountDownLatch countDownLatch;
-  /**
-   * Map<Index, TDataNodeLocation> The DataNode that successfully execute the request will be
-   * removed from this map
-   */
-  protected Map<Integer, TDataNodeLocation> dataNodeLocations;
+
+  /** The DataNode that successfully execute the request will be removed from this list */
+  protected List<TDataNodeLocation> dataNodeLocations;
 
   protected DataNodeRequestType dataNodeRequestType;
   /** Target DataNode */

Review Comment:
   fixed~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org