You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sunkai-cai (via GitHub)" <gi...@apache.org> on 2023/02/17 10:42:33 UTC
[GitHub] [shardingsphere] sunkai-cai opened a new pull request, #24221: password support special characters for DistSql
sunkai-cai opened a new pull request, #24221:
URL: https://github.com/apache/shardingsphere/pull/24221
Fixes #24178.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24221: password support special characters for DistSql
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24221:
URL: https://github.com/apache/shardingsphere/pull/24221#discussion_r1115773465
##########
sql-parser/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/value/literal/impl/StringLiteralValue.java:
##########
@@ -31,4 +32,23 @@ public final class StringLiteralValue implements LiteralValue<String> {
public StringLiteralValue(final String value) {
this.value = value.substring(1, value.length() - 1);
}
+
+ /**
+ * get special escape sequences string, do this:
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24221: password support special characters for DistSql
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24221:
URL: https://github.com/apache/shardingsphere/pull/24221#issuecomment-1434490214
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24221](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d800c08) into [master](https://codecov.io/gh/apache/shardingsphere/commit/739e761349087b7401e5448a971516613d0c0f03?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (739e761) will **decrease** coverage by `0.12%`.
> The diff coverage is `43.56%`.
> :exclamation: Current head d800c08 differs from pull request most recent head 0c7ab53. Consider uploading reports for the commit 0c7ab53 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24221 +/- ##
============================================
- Coverage 50.13% 50.01% -0.12%
+ Complexity 1580 1579 -1
============================================
Files 3256 3257 +1
Lines 53515 53443 -72
Branches 9870 9864 -6
============================================
- Hits 26830 26730 -100
- Misses 24323 24343 +20
- Partials 2362 2370 +8
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `5.43% <0.00%> (+5.43%)` | :arrow_up: |
| [...ngsphere/data/pipeline/cdc/api/impl/CDCJobAPI.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2FwaS9pbXBsL0NEQ0pvYkFQSS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...a/pipeline/cdc/config/job/CDCJobConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvbmZpZy9qb2IvQ0RDSm9iQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...e/proxy/backend/handler/cdc/CDCBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2NkYy9DRENCYWNrZW5kSGFuZGxlci5qYXZh) | `24.73% <0.00%> (ø)` | |
| [.../handler/distsql/ral/RALBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1JBTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `64.00% <0.00%> (-2.67%)` | :arrow_down: |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../common/value/literal/impl/StringLiteralValue.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi92YWx1ZS9saXRlcmFsL2ltcGwvU3RyaW5nTGl0ZXJhbFZhbHVlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...dc/core/connector/SocketSinkImporterConnector.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY2RjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvY2RjL2NvcmUvY29ubmVjdG9yL1NvY2tldFNpbmtJbXBvcnRlckNvbm5lY3Rvci5qYXZh) | `15.55% <15.38%> (ø)` | |
| [...ler/update/AlterSQLParserRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3BhcnNlci9kaXN0c3FsL2hhbmRsZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3BhcnNlci9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FsdGVyU1FMUGFyc2VyUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `33.33% <33.33%> (-29.17%)` | :arrow_down: |
| [...r/update/AlterTransactionRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL3RyYW5zYWN0aW9uL2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdHJhbnNhY3Rpb24vZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlclRyYW5zYWN0aW9uUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `8.00% <33.33%> (-68.48%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/24221?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sunkai-cai commented on a diff in pull request #24221: password support special characters for DistSql
Posted by "sunkai-cai (via GitHub)" <gi...@apache.org>.
sunkai-cai commented on code in PR #24221:
URL: https://github.com/apache/shardingsphere/pull/24221#discussion_r1115753429
##########
sql-parser/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/value/literal/impl/StringLiteralValue.java:
##########
@@ -31,4 +32,23 @@ public final class StringLiteralValue implements LiteralValue<String> {
public StringLiteralValue(final String value) {
this.value = value.substring(1, value.length() - 1);
}
+
+ /**
+ * get special escape sequences string, do this:
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24221: password support special characters for DistSql
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24221:
URL: https://github.com/apache/shardingsphere/pull/24221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #24221: password support special characters for DistSql
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #24221:
URL: https://github.com/apache/shardingsphere/pull/24221#discussion_r1115747738
##########
sql-parser/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/value/literal/impl/StringLiteralValue.java:
##########
@@ -31,4 +32,23 @@ public final class StringLiteralValue implements LiteralValue<String> {
public StringLiteralValue(final String value) {
this.value = value.substring(1, value.length() - 1);
}
+
+ /**
+ * get special escape sequences string, do this:
Review Comment:
The first letter should be uppercase.
Also, I think we should not keep so many comments, since that's not a feature we provide, it's the ability of `StringUtils.replaceStandardEscapes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org