[GitHub] rdhabalia commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg
URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217502837
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -133,4 +133,5 @@ message Instance {
 message Assignment {
     Instance instance = 1;
     string workerId = 2;
+    bool removed = 3;
 
 Review comment:
   > Why do we take this approach. Instead we could just write an empty value to the key, which is the removal?
   
   yes, that's true. I didn't see that removal at compaction and I also had the concern of removing defunct assignments. I will fix it and will also fix compaction if necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services