You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/09/13 19:01:15 UTC
[PR] Fixed: Mini-lang to Groovy regressions in EmailServicesScript (OFBIZ-13581) [ofbiz-framework]
mridulpathak opened a new pull request, #1982:
URL: https://github.com/apache/ofbiz-framework/pull/1982
sendMailFromTemplateSetting filters parameters to sendMailFromScreen's own declared attributes via dctx.makeValidContext before merging into emailParams, instead of merging the entire raw parameters map. The conversion dropped the original minilang's set-service-fields step, which did exactly this filtering; restoring it removes the latent risk of an unrelated field (e.g. emailTemplateSettingId) leaking into a downstream service call, even though the framework's own dispatcher-level filtering already prevents this from crashing in practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Mini-lang to Groovy regressions in EmailServicesScript (OFBIZ-13581) [ofbiz-framework]
Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #1982:
URL: https://github.com/apache/ofbiz-framework/pull/1982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org