You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/11 06:36:07 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
jamesnetherton opened a new pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780
Fixes #1632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486822324
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486820543
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486820543
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486820543
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486820543
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Is this the actual fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486822324
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1780: Fix intermittent failures of SmallRyeReactiveMessagingIT
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1780:
URL: https://github.com/apache/camel-quarkus/pull/1780#discussion_r486822324
##########
File path: integration-tests/smallrye-reactive-messaging/src/main/java/org/apache/camel/quarkus/component/smallrye/reactive/messaging/it/SmallRyeReactiveMessagingResource.java
##########
@@ -52,6 +54,8 @@ public Response post(String message) throws Exception {
@Produces(MediaType.TEXT_PLAIN)
@GET
public String getValues() {
- return String.join(",", results.getResults());
+ List<String> values = results.getResults();
+ Collections.sort(values);
Review comment:
Yes. The order in which the messages are processed is not important. We just need to verify that all of the expected values are there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org