[GitHub] [skywalking] lujiajing1126 edited a comment on pull request #7448: Banyandb integration

[GitBox <gi...@apache.org>]

lujiajing1126 edited a comment on pull request #7448:
URL: https://github.com/apache/skywalking/pull/7448#issuecomment-898168680


   > I put many comments, but not all. @hanahmily I am not sure what code style is required in BanyanDB codebase, but this PR is not ready from main repo's requirements.
   > 
   > All API level methods should have formal comments to describe usage, and meaning of parameters and return value. Even include how and where should use this APIs.
   > 
   > My major requirements are for BanyanDB package, I would like to be very strict about this API review. Feel free even to submit a PR to submit this. Also, I recommend to move all BanyanDB client source codes as the root module of `oap-server`. It should be `org.apache.skywalking:banyandb-java-client`.
   
   I have improved this PR following you comments.
   
   1. The client package has been moved as a standalone module in the `oap-server`
   2. The typed API are introduced to avoid runtime type checking for performance issues
   3. Docs are added to all interfaces and fields in the client package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org