[GitHub] [pulsar] ivankelly commented on a change in pull request #4217: Add flag to allow TLS hostname validation to be disabled in python

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #4217: Add flag to allow TLS hostname validation to be disabled in python
URL: https://github.com/apache/pulsar/pull/4217#discussion_r282422052
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/__init__.py
 ##########
 @@ -288,7 +288,8 @@ def __init__(self, service_url,
                  log_conf_file_path=None,
                  use_tls=False,
                  tls_trust_certs_file_path=None,
-                 tls_allow_insecure_connection=False
+                 tls_allow_insecure_connection=False,
+                 tls_validate_hostname=True,
 
 Review comment:
   We should probably change it to on by default, though it depends on what we expect deployments to look like. If users are accessing through a load balancer backed by proxies, it makes sense to validate the hostname. If connecting directly to brokers, maybe not, though a wildcard cert could still be used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services