You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/04 13:49:03 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1158: Add the compatible Redis version to the info command

PragmaTwice commented on code in PR #1158:
URL: https://github.com/apache/incubator-kvrocks/pull/1158#discussion_r1038974133


##########
src/version.h.in:
##########
@@ -21,4 +21,5 @@
 #pragma once
 
 #define VERSION "@PROJECT_VERSION@"
+#define REDIS_VERSION "4.0.0"

Review Comment:
   I think it should not be in `version.h.in`, which is a header for kvrocks version configuration.
   
   You can put them just in `server.h`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org