You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Krishna Mewara (Jira)" <ji...@apache.org> on 2026/06/07 12:17:00 UTC
[jira] [Updated] (FINERACT-2631) Extend FeignClientHelper with pending client creation, status transitions, and CRUD
[ https://issues.apache.org/jira/browse/FINERACT-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Krishna Mewara updated FINERACT-2631:
-------------------------------------
Description:
*New files*
* {{ClientRequestBuilders}} — typed request object factories for client status transitions (activate, close, reject, reactivate)
* {{FeignClientLifecycleTest}} — 6 end-to-end test cases covering pending client creation, activation, rejection, closure, reactivation, update, delete, and search
*Modified files*
* {{FeignClientHelper}} — extended with 10 new methods: pending client creation, status transitions (activate, close, reject, reactivate), update, delete, search, and account retrieval
*Key design points*
* All status transition methods accept typed {{PostClientsClientIdRequest}} — no raw reason-code integers
* {{ClientRequestBuilders}} mirrors the {{SavingsRequestBuilders}} pattern for consistent factory-style request construction
* {{{}withdraw{}}}, {{{}undoReject{}}}, and {{undoWithdrawn}} intentionally deferred — {{PostClientsClientIdRequest}} Swagger model is missing {{{}withdrawalDate{}}}, {{{}withdrawalReasonId{}}}, and {{reopenedDate}} fields (same class of spec gap fixed in FINERACT-2626; requires a follow-up Swagger PR)
* Fixes legacy {{createClientIdentifer}} typo → {{createClientIdentifier}}
* Zero RestAssured or Retrofit imports — pure Feign throughout
* No modifications to existing legacy helpers or tests
was:
*Description:*
*New files*
* {{ClientRequestBuilders}} — typed request object factories for client status transitions (activate, close, reject, reactivate)
* {{FeignClientLifecycleTest}} — 6 end-to-end test cases covering pending client creation, activation, rejection, closure, reactivation, update, delete, and search
*Modified files*
* {{FeignClientHelper}} — extended with 10 new methods: pending client creation, status transitions (activate, close, reject, reactivate), update, delete, search, and account retrieval
*Key design points*
* All status transition methods accept typed {{PostClientsClientIdRequest}} — no raw reason-code integers
* {{ClientRequestBuilders}} mirrors the {{SavingsRequestBuilders}} pattern for consistent factory-style request construction
* {{{}withdraw{}}}, {{{}undoReject{}}}, and {{undoWithdrawn}} intentionally deferred — {{PostClientsClientIdRequest}} Swagger model is missing {{{}withdrawalDate{}}}, {{{}withdrawalReasonId{}}}, and {{reopenedDate}} fields (same class of spec gap fixed in FINERACT-2626; requires a follow-up Swagger PR)
* Fixes legacy {{createClientIdentifer}} typo → {{createClientIdentifier}}
* Zero RestAssured or Retrofit imports — pure Feign throughout
* No modifications to existing legacy helpers or tests
> Extend FeignClientHelper with pending client creation, status transitions, and CRUD
> -----------------------------------------------------------------------------------
>
> Key: FINERACT-2631
> URL: https://issues.apache.org/jira/browse/FINERACT-2631
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Reporter: Krishna Mewara
> Priority: Trivial
> Labels: feign-migration, test-infrastructure
>
> *New files*
> * {{ClientRequestBuilders}} — typed request object factories for client status transitions (activate, close, reject, reactivate)
> * {{FeignClientLifecycleTest}} — 6 end-to-end test cases covering pending client creation, activation, rejection, closure, reactivation, update, delete, and search
> *Modified files*
> * {{FeignClientHelper}} — extended with 10 new methods: pending client creation, status transitions (activate, close, reject, reactivate), update, delete, search, and account retrieval
> *Key design points*
> * All status transition methods accept typed {{PostClientsClientIdRequest}} — no raw reason-code integers
> * {{ClientRequestBuilders}} mirrors the {{SavingsRequestBuilders}} pattern for consistent factory-style request construction
> * {{{}withdraw{}}}, {{{}undoReject{}}}, and {{undoWithdrawn}} intentionally deferred — {{PostClientsClientIdRequest}} Swagger model is missing {{{}withdrawalDate{}}}, {{{}withdrawalReasonId{}}}, and {{reopenedDate}} fields (same class of spec gap fixed in FINERACT-2626; requires a follow-up Swagger PR)
> * Fixes legacy {{createClientIdentifer}} typo → {{createClientIdentifier}}
> * Zero RestAssured or Retrofit imports — pure Feign throughout
> * No modifications to existing legacy helpers or tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)