You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Britt Cyr (JIRA)" <ji...@apache.org> on 2012/06/19 22:34:42 UTC
[jira] [Created] (OOZIE-874) Eliminate redundancies in xml
Britt Cyr created OOZIE-874:
-------------------------------
Summary: Eliminate redundancies in xml
Key: OOZIE-874
URL: https://issues.apache.org/jira/browse/OOZIE-874
Project: Oozie
Issue Type: Bug
Reporter: Britt Cyr
Assignee: Britt Cyr
Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415379#comment-13415379 ]
Virag Kothari commented on OOZIE-874:
-------------------------------------
I just committed this..thanks Britt
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Fix For: trunk
>
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874-v4.patch, OOZIE-874-v5.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398783#comment-13398783 ]
Mona Chitnis commented on OOZIE-874:
------------------------------------
patch looks good
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-874) Eliminate redundancies in xml
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Virag Kothari resolved OOZIE-874.
---------------------------------
Resolution: Fixed
Fix Version/s: trunk
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Fix For: trunk
>
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874-v4.patch, OOZIE-874-v5.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-874) Eliminate redundancies in xml
Posted by "Britt Cyr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Britt Cyr updated OOZIE-874:
----------------------------
Attachment: OOZIE-874-v5.patch
Moved handle global to a separate method
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874-v4.patch, OOZIE-874-v5.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407663#comment-13407663 ]
Virag Kothari commented on OOZIE-874:
-------------------------------------
Parsing will fail if namespace is not specified.
E.g globalConfig.getChildText("name"); -> globalConfig.getChildText("name", ns); Same comment for other places
Add test cases that ensure that global properties are used and if local properties exists, their values override global.
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-874) Eliminate redundancies in xml
Posted by "Britt Cyr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Britt Cyr updated OOZIE-874:
----------------------------
Attachment: OOZIE-874-v2.patch
Verifies that there is a name-node and job-tracker defined for all map-reduce, pig, and java actions.
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-874) Eliminate redundancies in xml
Posted by "Britt Cyr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Britt Cyr updated OOZIE-874:
----------------------------
Attachment: OOZIE-874.patch
changes allow workflow.xml to have a global section at the beginning. There you can define the name-node, job-tracker, and configuration that you want to use for all your actions.
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Virag Kothari (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413984#comment-13413984 ]
Virag Kothari commented on OOZIE-874:
-------------------------------------
+1
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874-v4.patch, OOZIE-874-v5.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400839#comment-13400839 ]
Alejandro Abdelnur commented on OOZIE-874:
------------------------------------------
@Mona, I'm missing something I guess, I don't see where we are storing the global JT/NN/CONF and then using that for actions that don't have local values (if they do, they should override the global ones). I would have expected that the global information is stored in the proto action and then used from there is not locally avail for the action.
@Britt, we should also make the changes in the action extensions (hive, sqoop, shell).
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-874) Eliminate redundancies in xml
Posted by "Britt Cyr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Britt Cyr updated OOZIE-874:
----------------------------
Attachment: OOZIE-874-v3.patch
Changes is hive, sqoop, and shell
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399549#comment-13399549 ]
Mona Chitnis commented on OOZIE-874:
------------------------------------
Tucu,
regarding your third point, since the check and assignment for the global properties to 'eActionConf' is done within the loop for each node, isnt it taken care of?
Britt,
End-to-end testing needs to be done for this patch
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-874) Eliminate redundancies in xml
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398795#comment-13398795 ]
Alejandro Abdelnur commented on OOZIE-874:
------------------------------------------
* the schema for actions should be changed to allow 0/1 for job-tracker/name-node/configuration (this should include extension actions)
* the verification of the workflow should check that if there is not global all actions must have it (this is not possible to do via XSD)
* I don't see how/where this global information gets store/used for all actions.
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-874) Eliminate redundancies in xml
Posted by "Britt Cyr (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Britt Cyr updated OOZIE-874:
----------------------------
Attachment: OOZIE-874-v4.patch
Added tests
> Eliminate redundancies in xml
> -----------------------------
>
> Key: OOZIE-874
> URL: https://issues.apache.org/jira/browse/OOZIE-874
> Project: Oozie
> Issue Type: Bug
> Reporter: Britt Cyr
> Assignee: Britt Cyr
> Attachments: OOZIE-874-v2.patch, OOZIE-874-v3.patch, OOZIE-874-v4.patch, OOZIE-874.patch
>
>
> Allow for users to define name-node, job-tracker, and configuration in a global section of the workflow.xml so that they do not have to repeat it for every action.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira