You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Olivier Lamy <ol...@apache.org> on 2011/05/24 15:14:02 UTC
Refactoring in progress : questions
Hi Folks,
I have made some progress on removing the old good friend plexus :-).
Done for redback.
Apologize for side effect on failing archiva/continuum trunk :-(, as I
cannot do this in one shot, I work on module per module.
So it can/will take some times, I know the famous one beer to the team
per build failure (doh I have to schedule a full van :-) ).
Any objections if I move from plexus taskqueue to Spring scheduler [1] ?
The other issue I have is the use of maven apis in some modules (ie
archiva-dependency-tree-consumer ) which is very dependant to plexus.
So here I have to think/search on how to remove plexus for this part.
If any ideas, I accept :-)
Thanks,
--
Olivier Lamy
http://twitter.com/olamy | http://www.linkedin.com/in/olamy
[1] http://static.springsource.org/spring/docs/current/spring-framework-reference/html/scheduling.html
Re: Refactoring in progress : questions
Posted by Deng Ching <oc...@apache.org>.
Thanks Olivier! :)
On Tue, Jun 21, 2011 at 8:11 AM, Brett Porter <br...@apache.org> wrote:
>
> On 21/06/2011, at 6:58 AM, Olivier Lamy wrote:
>
> > Hello Folks,
> > To follow up. It looks all unit test pass now.
> > No more dependencies to plexus. Except in one place
> > dependency-tree-builder which the sisu-plexus bridge use in maven3.
> >
> > FYI I have added some jobs in jenkins :
> > https://builds.apache.org/view/A-F/view/Archiva/. (builds with mvn 2.x
> > due to an issue in jenkins).
> >
> > The jobs called archiva-all-maven-3.x-jdk-1.6-with-it execute selenium
> > tests too.
> > I'm currently working on this last part :
> > 1. to fix failing
> > 2. to remove some tests which are locale dependant (assertOnText
> > content). those fail here : sorry I'm fr-FR :-)
>
> Thanks for fixing that up :)
>
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
>
>
>
>
>
Re: Refactoring in progress : questions
Posted by Brett Porter <br...@apache.org>.
On 21/06/2011, at 6:58 AM, Olivier Lamy wrote:
> Hello Folks,
> To follow up. It looks all unit test pass now.
> No more dependencies to plexus. Except in one place
> dependency-tree-builder which the sisu-plexus bridge use in maven3.
>
> FYI I have added some jobs in jenkins :
> https://builds.apache.org/view/A-F/view/Archiva/. (builds with mvn 2.x
> due to an issue in jenkins).
>
> The jobs called archiva-all-maven-3.x-jdk-1.6-with-it execute selenium
> tests too.
> I'm currently working on this last part :
> 1. to fix failing
> 2. to remove some tests which are locale dependant (assertOnText
> content). those fail here : sorry I'm fr-FR :-)
Thanks for fixing that up :)
- Brett
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter
Re: Refactoring in progress : questions
Posted by Olivier Lamy <ol...@apache.org>.
Hello Folks,
To follow up. It looks all unit test pass now.
No more dependencies to plexus. Except in one place
dependency-tree-builder which the sisu-plexus bridge use in maven3.
FYI I have added some jobs in jenkins :
https://builds.apache.org/view/A-F/view/Archiva/. (builds with mvn 2.x
due to an issue in jenkins).
The jobs called archiva-all-maven-3.x-jdk-1.6-with-it execute selenium
tests too.
I'm currently working on this last part :
1. to fix failing
2. to remove some tests which are locale dependant (assertOnText
content). those fail here : sorry I'm fr-FR :-)
Thanks
--
Olivier Lamy
http://twitter.com/olamy | http://www.linkedin.com/in/olamy
2011/6/9 Deng Ching <oc...@apache.org>:
> Ok, thanks Olivier :) I'll help you out with the webapp module. I can start
> with the changes you've mentioned below with the actions and web.xml.
>
> -Deng
>
> On Thu, Jun 9, 2011 at 3:26 PM, Olivier Lamy <ol...@apache.org> wrote:
>
>> Hello,
>> Not yet finished (arghhh :-) )
>> I was on webdav unit test fixing.
>> BTW I will do a quick hacking regarding the webapp to get it work (and
>> back to unit tests later).
>> The goal is simply to remove all @plexus.component in the webapp for
>> using spring annotations for actions. (see changes I have done in
>> redback).
>>
>> /**
>> * Browse the repository.
>> *
>> * @todo implement repository selectors (all or specific repository)
>> * @plexus.component role="com.opensymphony.xwork2.Action"
>> role-hint="browseAction" instantiation-strategy="per-lookup"
>> */
>> public class BrowseAction
>>
>> to
>>
>> @Controller( "browseAction" )
>> @Scope( "prototype" )
>> public class BrowseAction
>>
>>
>> And change web.xml
>>
>> removing this
>> <context-param>
>> <param-name>contextClass</param-name>
>> <param-value>
>>
>> org.codehaus.plexus.spring.PlexusWebApplicationContext
>> </param-value>
>> </context-param>
>>
>> remove classpath*:META-INF/plexus/components.xml
>> <context-param>
>> <param-name>contextConfigLocation</param-name>
>> <param-value>
>> classpath*:META-INF/plexus/components.xml
>> classpath*:META-INF/spring-context.xml
>> /WEB-INF/application.xml
>> /WEB-INF/applicationContext.xml
>> </param-value>
>> </context-param>
>>
>> I will try to finish this today .
>>
>> 2011/6/9 Deng Ching <oc...@apache.org>:
>> > Hi Olivier,
>> >
>> > I tried running the jetty bundle earlier and got a ClassNotFound error
>> for
>> > PlexusWebApplicationContext. I guess there are still some modules that
>> are
>> > using plexus? Anything I can help out with? :)
>> >
>> > Thanks,
>> > Deng
>> >
>> > On Tue, May 24, 2011 at 10:20 PM, Olivier Lamy <ol...@apache.org> wrote:
>> >
>> >> 2011/5/24 Brett Porter <br...@apache.org>:
>> >> >
>> >> > On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
>> >> >
>> >> >> Hi Folks,
>> >> >> I have made some progress on removing the old good friend plexus :-).
>> >> >> Done for redback.
>> >> >> Apologize for side effect on failing archiva/continuum trunk :-(, as
>> I
>> >> >> cannot do this in one shot, I work on module per module.
>> >> >> So it can/will take some times, I know the famous one beer to the
>> team
>> >> >> per build failure (doh I have to schedule a full van :-) ).
>> >> >
>> >> > No worries. I released redback-1.3-M1 to give us a stable point if
>> needed
>> >> - so we can always branch Archiva too.
>> >> >
>> >> >>
>> >> >> Any objections if I move from plexus taskqueue to Spring scheduler
>> [1] ?
>> >> >
>> >> > No problem here (though something simpler using Quartz would be fine
>> too)
>> >> >
>> >> >>
>> >> >> The other issue I have is the use of maven apis in some modules (ie
>> >> >> archiva-dependency-tree-consumer ) which is very dependant to plexus.
>> >> >> So here I have to think/search on how to remove plexus for this part.
>> >> >> If any ideas, I accept :-)
>> >> >
>> >> >
>> >> > Don't worry about that module - just move it to the sandbox.
>> >> done I like this kind of quick fix :-)
>> >> >
>> >> > - Brett
>> >> >
>> >> > --
>> >> > Brett Porter
>> >> > brett@apache.org
>> >> > http://brettporter.wordpress.com/
>> >> > http://au.linkedin.com/in/brettporter
>> >> >
>> >> >
>> >> >
>> >> >
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Olivier Lamy
>> >> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
>> >>
>> >
>>
>>
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
>>
>
Re: Refactoring in progress : questions
Posted by Deng Ching <oc...@apache.org>.
Ok, thanks Olivier :) I'll help you out with the webapp module. I can start
with the changes you've mentioned below with the actions and web.xml.
-Deng
On Thu, Jun 9, 2011 at 3:26 PM, Olivier Lamy <ol...@apache.org> wrote:
> Hello,
> Not yet finished (arghhh :-) )
> I was on webdav unit test fixing.
> BTW I will do a quick hacking regarding the webapp to get it work (and
> back to unit tests later).
> The goal is simply to remove all @plexus.component in the webapp for
> using spring annotations for actions. (see changes I have done in
> redback).
>
> /**
> * Browse the repository.
> *
> * @todo implement repository selectors (all or specific repository)
> * @plexus.component role="com.opensymphony.xwork2.Action"
> role-hint="browseAction" instantiation-strategy="per-lookup"
> */
> public class BrowseAction
>
> to
>
> @Controller( "browseAction" )
> @Scope( "prototype" )
> public class BrowseAction
>
>
> And change web.xml
>
> removing this
> <context-param>
> <param-name>contextClass</param-name>
> <param-value>
>
> org.codehaus.plexus.spring.PlexusWebApplicationContext
> </param-value>
> </context-param>
>
> remove classpath*:META-INF/plexus/components.xml
> <context-param>
> <param-name>contextConfigLocation</param-name>
> <param-value>
> classpath*:META-INF/plexus/components.xml
> classpath*:META-INF/spring-context.xml
> /WEB-INF/application.xml
> /WEB-INF/applicationContext.xml
> </param-value>
> </context-param>
>
> I will try to finish this today .
>
> 2011/6/9 Deng Ching <oc...@apache.org>:
> > Hi Olivier,
> >
> > I tried running the jetty bundle earlier and got a ClassNotFound error
> for
> > PlexusWebApplicationContext. I guess there are still some modules that
> are
> > using plexus? Anything I can help out with? :)
> >
> > Thanks,
> > Deng
> >
> > On Tue, May 24, 2011 at 10:20 PM, Olivier Lamy <ol...@apache.org> wrote:
> >
> >> 2011/5/24 Brett Porter <br...@apache.org>:
> >> >
> >> > On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
> >> >
> >> >> Hi Folks,
> >> >> I have made some progress on removing the old good friend plexus :-).
> >> >> Done for redback.
> >> >> Apologize for side effect on failing archiva/continuum trunk :-(, as
> I
> >> >> cannot do this in one shot, I work on module per module.
> >> >> So it can/will take some times, I know the famous one beer to the
> team
> >> >> per build failure (doh I have to schedule a full van :-) ).
> >> >
> >> > No worries. I released redback-1.3-M1 to give us a stable point if
> needed
> >> - so we can always branch Archiva too.
> >> >
> >> >>
> >> >> Any objections if I move from plexus taskqueue to Spring scheduler
> [1] ?
> >> >
> >> > No problem here (though something simpler using Quartz would be fine
> too)
> >> >
> >> >>
> >> >> The other issue I have is the use of maven apis in some modules (ie
> >> >> archiva-dependency-tree-consumer ) which is very dependant to plexus.
> >> >> So here I have to think/search on how to remove plexus for this part.
> >> >> If any ideas, I accept :-)
> >> >
> >> >
> >> > Don't worry about that module - just move it to the sandbox.
> >> done I like this kind of quick fix :-)
> >> >
> >> > - Brett
> >> >
> >> > --
> >> > Brett Porter
> >> > brett@apache.org
> >> > http://brettporter.wordpress.com/
> >> > http://au.linkedin.com/in/brettporter
> >> >
> >> >
> >> >
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
> >>
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
>
Re: Refactoring in progress : questions
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
Not yet finished (arghhh :-) )
I was on webdav unit test fixing.
BTW I will do a quick hacking regarding the webapp to get it work (and
back to unit tests later).
The goal is simply to remove all @plexus.component in the webapp for
using spring annotations for actions. (see changes I have done in
redback).
/**
* Browse the repository.
*
* @todo implement repository selectors (all or specific repository)
* @plexus.component role="com.opensymphony.xwork2.Action"
role-hint="browseAction" instantiation-strategy="per-lookup"
*/
public class BrowseAction
to
@Controller( "browseAction" )
@Scope( "prototype" )
public class BrowseAction
And change web.xml
removing this
<context-param>
<param-name>contextClass</param-name>
<param-value>
org.codehaus.plexus.spring.PlexusWebApplicationContext
</param-value>
</context-param>
remove classpath*:META-INF/plexus/components.xml
<context-param>
<param-name>contextConfigLocation</param-name>
<param-value>
classpath*:META-INF/plexus/components.xml
classpath*:META-INF/spring-context.xml
/WEB-INF/application.xml
/WEB-INF/applicationContext.xml
</param-value>
</context-param>
I will try to finish this today .
2011/6/9 Deng Ching <oc...@apache.org>:
> Hi Olivier,
>
> I tried running the jetty bundle earlier and got a ClassNotFound error for
> PlexusWebApplicationContext. I guess there are still some modules that are
> using plexus? Anything I can help out with? :)
>
> Thanks,
> Deng
>
> On Tue, May 24, 2011 at 10:20 PM, Olivier Lamy <ol...@apache.org> wrote:
>
>> 2011/5/24 Brett Porter <br...@apache.org>:
>> >
>> > On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
>> >
>> >> Hi Folks,
>> >> I have made some progress on removing the old good friend plexus :-).
>> >> Done for redback.
>> >> Apologize for side effect on failing archiva/continuum trunk :-(, as I
>> >> cannot do this in one shot, I work on module per module.
>> >> So it can/will take some times, I know the famous one beer to the team
>> >> per build failure (doh I have to schedule a full van :-) ).
>> >
>> > No worries. I released redback-1.3-M1 to give us a stable point if needed
>> - so we can always branch Archiva too.
>> >
>> >>
>> >> Any objections if I move from plexus taskqueue to Spring scheduler [1] ?
>> >
>> > No problem here (though something simpler using Quartz would be fine too)
>> >
>> >>
>> >> The other issue I have is the use of maven apis in some modules (ie
>> >> archiva-dependency-tree-consumer ) which is very dependant to plexus.
>> >> So here I have to think/search on how to remove plexus for this part.
>> >> If any ideas, I accept :-)
>> >
>> >
>> > Don't worry about that module - just move it to the sandbox.
>> done I like this kind of quick fix :-)
>> >
>> > - Brett
>> >
>> > --
>> > Brett Porter
>> > brett@apache.org
>> > http://brettporter.wordpress.com/
>> > http://au.linkedin.com/in/brettporter
>> >
>> >
>> >
>> >
>> >
>>
>>
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
>>
>
--
Olivier Lamy
http://twitter.com/olamy | http://www.linkedin.com/in/olamy
Re: Refactoring in progress : questions
Posted by Deng Ching <oc...@apache.org>.
Hi Olivier,
I tried running the jetty bundle earlier and got a ClassNotFound error for
PlexusWebApplicationContext. I guess there are still some modules that are
using plexus? Anything I can help out with? :)
Thanks,
Deng
On Tue, May 24, 2011 at 10:20 PM, Olivier Lamy <ol...@apache.org> wrote:
> 2011/5/24 Brett Porter <br...@apache.org>:
> >
> > On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
> >
> >> Hi Folks,
> >> I have made some progress on removing the old good friend plexus :-).
> >> Done for redback.
> >> Apologize for side effect on failing archiva/continuum trunk :-(, as I
> >> cannot do this in one shot, I work on module per module.
> >> So it can/will take some times, I know the famous one beer to the team
> >> per build failure (doh I have to schedule a full van :-) ).
> >
> > No worries. I released redback-1.3-M1 to give us a stable point if needed
> - so we can always branch Archiva too.
> >
> >>
> >> Any objections if I move from plexus taskqueue to Spring scheduler [1] ?
> >
> > No problem here (though something simpler using Quartz would be fine too)
> >
> >>
> >> The other issue I have is the use of maven apis in some modules (ie
> >> archiva-dependency-tree-consumer ) which is very dependant to plexus.
> >> So here I have to think/search on how to remove plexus for this part.
> >> If any ideas, I accept :-)
> >
> >
> > Don't worry about that module - just move it to the sandbox.
> done I like this kind of quick fix :-)
> >
> > - Brett
> >
> > --
> > Brett Porter
> > brett@apache.org
> > http://brettporter.wordpress.com/
> > http://au.linkedin.com/in/brettporter
> >
> >
> >
> >
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://www.linkedin.com/in/olamy
>
Re: Refactoring in progress : questions
Posted by Olivier Lamy <ol...@apache.org>.
2011/5/24 Brett Porter <br...@apache.org>:
>
> On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
>
>> Hi Folks,
>> I have made some progress on removing the old good friend plexus :-).
>> Done for redback.
>> Apologize for side effect on failing archiva/continuum trunk :-(, as I
>> cannot do this in one shot, I work on module per module.
>> So it can/will take some times, I know the famous one beer to the team
>> per build failure (doh I have to schedule a full van :-) ).
>
> No worries. I released redback-1.3-M1 to give us a stable point if needed - so we can always branch Archiva too.
>
>>
>> Any objections if I move from plexus taskqueue to Spring scheduler [1] ?
>
> No problem here (though something simpler using Quartz would be fine too)
>
>>
>> The other issue I have is the use of maven apis in some modules (ie
>> archiva-dependency-tree-consumer ) which is very dependant to plexus.
>> So here I have to think/search on how to remove plexus for this part.
>> If any ideas, I accept :-)
>
>
> Don't worry about that module - just move it to the sandbox.
done I like this kind of quick fix :-)
>
> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
>
>
>
>
>
--
Olivier Lamy
http://twitter.com/olamy | http://www.linkedin.com/in/olamy
Re: Refactoring in progress : questions
Posted by Brett Porter <br...@apache.org>.
On 24/05/2011, at 11:14 PM, Olivier Lamy wrote:
> Hi Folks,
> I have made some progress on removing the old good friend plexus :-).
> Done for redback.
> Apologize for side effect on failing archiva/continuum trunk :-(, as I
> cannot do this in one shot, I work on module per module.
> So it can/will take some times, I know the famous one beer to the team
> per build failure (doh I have to schedule a full van :-) ).
No worries. I released redback-1.3-M1 to give us a stable point if needed - so we can always branch Archiva too.
>
> Any objections if I move from plexus taskqueue to Spring scheduler [1] ?
No problem here (though something simpler using Quartz would be fine too)
>
> The other issue I have is the use of maven apis in some modules (ie
> archiva-dependency-tree-consumer ) which is very dependant to plexus.
> So here I have to think/search on how to remove plexus for this part.
> If any ideas, I accept :-)
Don't worry about that module - just move it to the sandbox.
- Brett
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter