You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/09 12:15:36 UTC
[GitHub] [pulsar] eolivelli opened a new pull request, #15512: Allow Pulsar Broker and Functions to run on JDK11
eolivelli opened a new pull request, #15512:
URL: https://github.com/apache/pulsar/pull/15512
PIP-156 with commit a742eb53cfc5aaaaf5896be04de11df5d5e0ef40 added the requirement to run the Pulsar Broker and build Pulsar Functions on JDK17.
This patch relaxes this requirement by setting JDK11 as target JDK for the Broker and for Pulsar IO/Functions framework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #15512:
URL: https://github.com/apache/pulsar/pull/15512#issuecomment-1121023412
@heesung-sn PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15512:
URL: https://github.com/apache/pulsar/pull/15512#issuecomment-1121023060
@eolivelli:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a diff in pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
merlimat commented on code in PR #15512:
URL: https://github.com/apache/pulsar/pull/15512#discussion_r868144037
##########
pom.xml:
##########
@@ -77,8 +77,8 @@ flexible messaging model and an intuitive client API.</description>
</issueManagement>
<properties>
- <maven.compiler.source>17</maven.compiler.source>
- <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
Review Comment:
This would be bringing everything back to Java 11. The goal of PIP-156 was to get brokers on Java 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
URL: https://github.com/apache/pulsar/pull/15512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #15512:
URL: https://github.com/apache/pulsar/pull/15512#discussion_r868147052
##########
pom.xml:
##########
@@ -77,8 +77,8 @@ flexible messaging model and an intuitive client API.</description>
</issueManagement>
<properties>
- <maven.compiler.source>17</maven.compiler.source>
- <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
Review Comment:
My suggestion is to make the Broker work well on JDK17 and force people to switch to JDK11.
JDK17 is too "new"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #15512:
URL: https://github.com/apache/pulsar/pull/15512#discussion_r868146294
##########
pom.xml:
##########
@@ -77,8 +77,8 @@ flexible messaging model and an intuitive client API.</description>
</issueManagement>
<properties>
- <maven.compiler.source>17</maven.compiler.source>
- <maven.compiler.target>17</maven.compiler.target>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>11</maven.compiler.target>
Review Comment:
I sent a message on the ML.
I believe it is too strong to require people moving to JDK17 without having forced them switch to JDK11.
I know few companies (especially Banks and Insurance Companies for instance) that are not able to switch so easily the JDK, especially if you were running on JDK8.
I am not talking about Docker, but clusters on traditional/legacy VMs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #15512: Allow Pulsar Broker and Functions to run on JDK11 (PIP-156 related)
URL: https://github.com/apache/pulsar/pull/15512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org