You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Kanna Karanam <ka...@microsoft.com> on 2012/07/06 22:16:38 UTC
Review Request: Windows: Fix the unit tests which contains “!” commands (Unix shell commands)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5812/
-----------------------------------------------------------
Review request for hive, Carl Steinbach, Edward Capriolo, and Ashutosh Chauhan.
Description
-------
Replaced all “!<cmd> with DFS commands to run unit tests on Unix as well as Windows.
1) Creating a test directory before attempting to delete the non-existing directory to avoid the DFS failures.
Known Issue: Didn’t fix the ddltime.q unit test failure on windows yet. It has a “!sleep 1” command and I couldn’t invoke a simple java method to sleep for 1 sec. I will address this as a separate Jira as it requires more changes.
SELECT java_method("java.lang.Thread", "sleep", 1000) FROM src LIMIT 1;
This addresses bug HIVE-3204.
https://issues.apache.org/jira/browse/HIVE-3204
Diffs
-----
trunk/ql/src/test/queries/clientnegative/exim_00_unsupported_schema.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_01_nonpart_over_loaded.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_02_all_part_over_overlap.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_03_nonpart_noncompat_colschema.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_04_nonpart_noncompat_colnumber.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_05_nonpart_noncompat_coltype.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_06_nonpart_noncompat_storage.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_07_nonpart_noncompat_ifof.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_08_nonpart_noncompat_serde.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_09_nonpart_noncompat_serdeparam.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_10_nonpart_noncompat_bucketing.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_11_nonpart_noncompat_sorting.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_13_nonnative_import.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_14_nonpart_part.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_15_part_nonpart.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_16_part_noncompat_schema.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_17_part_spec_underspec.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_18_part_spec_missing.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_19_external_over_existing.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_20_managed_location_over_existing.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_21_part_managed_external.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_22_export_authfail.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_23_import_exist_authfail.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_24_import_part_authfail.q 1358338
trunk/ql/src/test/queries/clientnegative/exim_25_import_nonexist_authfail.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_00_nonpart_empty.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_01_nonpart.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_02_00_part_empty.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_02_part.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_03_nonpart_over_compat.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_04_all_part.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_04_evolved_parts.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_05_some_part.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_06_one_part.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_07_all_part_over_nonoverlap.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_08_nonpart_rename.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_09_part_spec_nonoverlap.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_10_external_managed.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_11_managed_external.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_12_external_location.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_13_managed_location.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_14_managed_location_over_existing.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_15_external_part.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_16_part_external.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_17_part_managed.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_18_part_external.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_19_00_part_external_location.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_19_part_external_location.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_20_part_managed_location.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_21_export_authsuccess.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_22_import_exist_authsuccess.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_23_import_part_authsuccess.q 1358338
trunk/ql/src/test/queries/clientpositive/exim_24_import_nonexist_authsuccess.q 1358338
trunk/ql/src/test/queries/clientpositive/insertexternal1.q 1358338
trunk/ql/src/test/queries/clientpositive/multi_insert.q 1358338
trunk/ql/src/test/queries/clientpositive/multi_insert_move_tasks_share_dependencies.q 1358338
trunk/ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_22_export_authfail.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out 1358338
trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_01_nonpart.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_02_part.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_04_all_part.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_05_some_part.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_06_one_part.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_10_external_managed.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_11_managed_external.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_12_external_location.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_13_managed_location.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_15_external_part.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_16_part_external.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_17_part_managed.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_18_part_external.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_19_00_part_external_location.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_19_part_external_location.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_21_export_authsuccess.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_22_import_exist_authsuccess.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_23_import_part_authsuccess.q.out 1358338
trunk/ql/src/test/results/clientpositive/exim_24_import_nonexist_authsuccess.q.out 1358338
trunk/ql/src/test/results/clientpositive/insertexternal1.q.out 1358338
trunk/ql/src/test/results/clientpositive/multi_insert.q.out 1358338
trunk/ql/src/test/results/clientpositive/multi_insert_move_tasks_share_dependencies.q.out 1358338
Diff: https://reviews.apache.org/r/5812/diff/
Testing
-------
Yes
Thanks,
Kanna Karanam
Re: Review Request: Windows: Fix the unit tests which contains “!” commands (Unix shell commands)
Posted by Kanna Karanam <ka...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5812/
-----------------------------------------------------------
(Updated July 11, 2012, 8:19 p.m.)
Review request for hive, Carl Steinbach, Edward Capriolo, and Ashutosh Chauhan.
Changes
-------
Removed the whitespace changes and updated the patch.
Description
-------
Replaced all “!<cmd> with DFS commands to run unit tests on Unix as well as Windows.
1) Creating a test directory before attempting to delete the non-existing directory to avoid the DFS failures.
Known Issue: Didn’t fix the ddltime.q unit test failure on windows yet. It has a “!sleep 1” command and I couldn’t invoke a simple java method to sleep for 1 sec. I will address this as a separate Jira as it requires more changes.
SELECT java_method("java.lang.Thread", "sleep", 1000) FROM src LIMIT 1;
This addresses bug HIVE-3204.
https://issues.apache.org/jira/browse/HIVE-3204
Diffs (updated)
-----
trunk/ql/src/test/queries/clientnegative/exim_00_unsupported_schema.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_01_nonpart_over_loaded.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_02_all_part_over_overlap.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_03_nonpart_noncompat_colschema.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_04_nonpart_noncompat_colnumber.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_05_nonpart_noncompat_coltype.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_06_nonpart_noncompat_storage.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_07_nonpart_noncompat_ifof.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_08_nonpart_noncompat_serde.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_09_nonpart_noncompat_serdeparam.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_10_nonpart_noncompat_bucketing.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_11_nonpart_noncompat_sorting.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_13_nonnative_import.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_14_nonpart_part.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_15_part_nonpart.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_16_part_noncompat_schema.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_17_part_spec_underspec.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_18_part_spec_missing.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_19_external_over_existing.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_20_managed_location_over_existing.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_21_part_managed_external.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_22_export_authfail.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_23_import_exist_authfail.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_24_import_part_authfail.q 1360329
trunk/ql/src/test/queries/clientnegative/exim_25_import_nonexist_authfail.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_00_nonpart_empty.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_01_nonpart.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_02_00_part_empty.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_02_part.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_03_nonpart_over_compat.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_04_all_part.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_04_evolved_parts.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_05_some_part.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_06_one_part.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_07_all_part_over_nonoverlap.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_08_nonpart_rename.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_09_part_spec_nonoverlap.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_10_external_managed.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_11_managed_external.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_12_external_location.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_13_managed_location.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_14_managed_location_over_existing.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_15_external_part.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_16_part_external.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_17_part_managed.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_18_part_external.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_19_00_part_external_location.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_19_part_external_location.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_20_part_managed_location.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_21_export_authsuccess.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_22_import_exist_authsuccess.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_23_import_part_authsuccess.q 1360329
trunk/ql/src/test/queries/clientpositive/exim_24_import_nonexist_authsuccess.q 1360329
trunk/ql/src/test/queries/clientpositive/insertexternal1.q 1360329
trunk/ql/src/test/queries/clientpositive/multi_insert.q 1360329
trunk/ql/src/test/queries/clientpositive/multi_insert_move_tasks_share_dependencies.q 1360329
trunk/ql/src/test/results/clientnegative/exim_00_unsupported_schema.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_01_nonpart_over_loaded.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_02_all_part_over_overlap.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_03_nonpart_noncompat_colschema.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_04_nonpart_noncompat_colnumber.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_05_nonpart_noncompat_coltype.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_06_nonpart_noncompat_storage.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_07_nonpart_noncompat_ifof.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_08_nonpart_noncompat_serde.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_09_nonpart_noncompat_serdeparam.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_10_nonpart_noncompat_bucketing.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_11_nonpart_noncompat_sorting.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_13_nonnative_import.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_14_nonpart_part.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_15_part_nonpart.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_16_part_noncompat_schema.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_17_part_spec_underspec.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_18_part_spec_missing.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_19_external_over_existing.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_20_managed_location_over_existing.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_21_part_managed_external.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_22_export_authfail.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_23_import_exist_authfail.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_24_import_part_authfail.q.out 1360329
trunk/ql/src/test/results/clientnegative/exim_25_import_nonexist_authfail.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_00_nonpart_empty.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_01_nonpart.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_02_00_part_empty.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_02_part.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_03_nonpart_over_compat.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_04_all_part.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_04_evolved_parts.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_05_some_part.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_06_one_part.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_07_all_part_over_nonoverlap.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_08_nonpart_rename.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_09_part_spec_nonoverlap.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_10_external_managed.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_11_managed_external.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_12_external_location.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_13_managed_location.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_14_managed_location_over_existing.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_15_external_part.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_16_part_external.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_17_part_managed.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_18_part_external.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_19_00_part_external_location.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_19_part_external_location.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_20_part_managed_location.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_21_export_authsuccess.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_22_import_exist_authsuccess.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_23_import_part_authsuccess.q.out 1360329
trunk/ql/src/test/results/clientpositive/exim_24_import_nonexist_authsuccess.q.out 1360329
trunk/ql/src/test/results/clientpositive/insertexternal1.q.out 1360329
trunk/ql/src/test/results/clientpositive/multi_insert.q.out 1360329
trunk/ql/src/test/results/clientpositive/multi_insert_move_tasks_share_dependencies.q.out 1360329
Diff: https://reviews.apache.org/r/5812/diff/
Testing
-------
Yes
Thanks,
Kanna Karanam