You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/13 22:13:15 UTC
[GitHub] [tvm] Lunderberg commented on a change in pull request #7840: [DOCS][BUILD] Small improvements to documentation/build setup for first-time builds
Lunderberg commented on a change in pull request #7840:
URL: https://github.com/apache/tvm/pull/7840#discussion_r612809507
##########
File path: docs/README.txt
##########
@@ -3,7 +3,7 @@ TVM Documentations
This folder contains the source of TVM documents
- A hosted version of doc is at https://tvm.apache.org/docs
-- pip install sphinx>=1.5.5 sphinx-gallery sphinx_rtd_theme matplotlib Image recommonmark "Pillow<7" autodocsumm tlcpack-sphinx-addon
+- pip install "sphinx>=1.5.5" sphinx-gallery sphinx_rtd_theme matplotlib Image recommonmark "Pillow<7" "autodocsumm<0.2.0" tlcpack-sphinx-addon
Review comment:
Good point, and that makes sense. I will add that to the README.txt shortly.
There's probably also room for the [gen_requirements.py](https://github.com/apache/tvm/blob/main/python/gen_requirements.py) to be used more in the docs/examples in the future. From what I can tell, the list of dependencies in it would be a perfect spot to centralize all dependency listings. Right now, it looks like it is primarily used in the CI framework, but the `tvm/python/requirements/*.txt` could be referred anywhere that currently has an explicit listing of the required packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org