You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/09/11 14:54:23 UTC
[19/25] hbase-site git commit: Published site at
2ab8122a24eb8444c2804b7f980bf008f395933d.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/dcc97e01/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.html
index 9c5a545..93bcb46 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.html
@@ -35,140 +35,155 @@
<span class="sourceLineNo">027</span>import org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure;<a name="line.27"></a>
<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.procedure2.ProcedureStateSerializer;<a name="line.28"></a>
<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.procedure2.ProcedureSuspendedException;<a name="line.29"></a>
-<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.procedure2.ProcedureYieldException;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.slf4j.Logger;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.slf4j.LoggerFactory;<a name="line.33"></a>
-<span class="sourceLineNo">034</span><a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.ReopenTableRegionsState;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.ReopenTableRegionsStateData;<a name="line.37"></a>
-<span class="sourceLineNo">038</span><a name="line.38"></a>
-<span class="sourceLineNo">039</span>/**<a name="line.39"></a>
-<span class="sourceLineNo">040</span> * Used for reopening the regions for a table.<a name="line.40"></a>
-<span class="sourceLineNo">041</span> */<a name="line.41"></a>
-<span class="sourceLineNo">042</span>@InterfaceAudience.Private<a name="line.42"></a>
-<span class="sourceLineNo">043</span>public class ReopenTableRegionsProcedure<a name="line.43"></a>
-<span class="sourceLineNo">044</span> extends AbstractStateMachineTableProcedure<ReopenTableRegionsState> {<a name="line.44"></a>
-<span class="sourceLineNo">045</span><a name="line.45"></a>
-<span class="sourceLineNo">046</span> private static final Logger LOG = LoggerFactory.getLogger(ReopenTableRegionsProcedure.class);<a name="line.46"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.procedure2.ProcedureUtil;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.procedure2.ProcedureYieldException;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.yetus.audience.InterfaceAudience;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.slf4j.Logger;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.slf4j.LoggerFactory;<a name="line.34"></a>
+<span class="sourceLineNo">035</span><a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.ReopenTableRegionsState;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.ReopenTableRegionsStateData;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.ProcedureProtos;<a name="line.39"></a>
+<span class="sourceLineNo">040</span><a name="line.40"></a>
+<span class="sourceLineNo">041</span>/**<a name="line.41"></a>
+<span class="sourceLineNo">042</span> * Used for reopening the regions for a table.<a name="line.42"></a>
+<span class="sourceLineNo">043</span> */<a name="line.43"></a>
+<span class="sourceLineNo">044</span>@InterfaceAudience.Private<a name="line.44"></a>
+<span class="sourceLineNo">045</span>public class ReopenTableRegionsProcedure<a name="line.45"></a>
+<span class="sourceLineNo">046</span> extends AbstractStateMachineTableProcedure<ReopenTableRegionsState> {<a name="line.46"></a>
<span class="sourceLineNo">047</span><a name="line.47"></a>
-<span class="sourceLineNo">048</span> private TableName tableName;<a name="line.48"></a>
+<span class="sourceLineNo">048</span> private static final Logger LOG = LoggerFactory.getLogger(ReopenTableRegionsProcedure.class);<a name="line.48"></a>
<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span> private List<HRegionLocation> regions = Collections.emptyList();<a name="line.50"></a>
+<span class="sourceLineNo">050</span> private TableName tableName;<a name="line.50"></a>
<span class="sourceLineNo">051</span><a name="line.51"></a>
-<span class="sourceLineNo">052</span> public ReopenTableRegionsProcedure() {<a name="line.52"></a>
-<span class="sourceLineNo">053</span> }<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span> public ReopenTableRegionsProcedure(TableName tableName) {<a name="line.55"></a>
-<span class="sourceLineNo">056</span> this.tableName = tableName;<a name="line.56"></a>
+<span class="sourceLineNo">052</span> private List<HRegionLocation> regions = Collections.emptyList();<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span> private int attempt;<a name="line.54"></a>
+<span class="sourceLineNo">055</span><a name="line.55"></a>
+<span class="sourceLineNo">056</span> public ReopenTableRegionsProcedure() {<a name="line.56"></a>
<span class="sourceLineNo">057</span> }<a name="line.57"></a>
<span class="sourceLineNo">058</span><a name="line.58"></a>
-<span class="sourceLineNo">059</span> @Override<a name="line.59"></a>
-<span class="sourceLineNo">060</span> public TableName getTableName() {<a name="line.60"></a>
-<span class="sourceLineNo">061</span> return tableName;<a name="line.61"></a>
-<span class="sourceLineNo">062</span> }<a name="line.62"></a>
-<span class="sourceLineNo">063</span><a name="line.63"></a>
-<span class="sourceLineNo">064</span> @Override<a name="line.64"></a>
-<span class="sourceLineNo">065</span> public TableOperationType getTableOperationType() {<a name="line.65"></a>
-<span class="sourceLineNo">066</span> return TableOperationType.REGION_EDIT;<a name="line.66"></a>
-<span class="sourceLineNo">067</span> }<a name="line.67"></a>
-<span class="sourceLineNo">068</span><a name="line.68"></a>
-<span class="sourceLineNo">069</span> @Override<a name="line.69"></a>
-<span class="sourceLineNo">070</span> protected Flow executeFromState(MasterProcedureEnv env, ReopenTableRegionsState state)<a name="line.70"></a>
-<span class="sourceLineNo">071</span> throws ProcedureSuspendedException, ProcedureYieldException, InterruptedException {<a name="line.71"></a>
-<span class="sourceLineNo">072</span> switch (state) {<a name="line.72"></a>
-<span class="sourceLineNo">073</span> case REOPEN_TABLE_REGIONS_GET_REGIONS:<a name="line.73"></a>
-<span class="sourceLineNo">074</span> if (!env.getAssignmentManager().isTableEnabled(tableName)) {<a name="line.74"></a>
-<span class="sourceLineNo">075</span> LOG.info("Table {} is disabled, give up reopening its regions");<a name="line.75"></a>
-<span class="sourceLineNo">076</span> return Flow.NO_MORE_STATE;<a name="line.76"></a>
-<span class="sourceLineNo">077</span> }<a name="line.77"></a>
-<span class="sourceLineNo">078</span> regions =<a name="line.78"></a>
-<span class="sourceLineNo">079</span> env.getAssignmentManager().getRegionStates().getRegionsOfTableForReopen(tableName);<a name="line.79"></a>
-<span class="sourceLineNo">080</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_REOPEN_REGIONS);<a name="line.80"></a>
-<span class="sourceLineNo">081</span> return Flow.HAS_MORE_STATE;<a name="line.81"></a>
-<span class="sourceLineNo">082</span> case REOPEN_TABLE_REGIONS_REOPEN_REGIONS:<a name="line.82"></a>
-<span class="sourceLineNo">083</span> for (HRegionLocation loc : regions) {<a name="line.83"></a>
-<span class="sourceLineNo">084</span> RegionStateNode regionNode = env.getAssignmentManager().getRegionStates()<a name="line.84"></a>
-<span class="sourceLineNo">085</span> .getOrCreateRegionStateNode(loc.getRegion());<a name="line.85"></a>
-<span class="sourceLineNo">086</span> TransitRegionStateProcedure proc;<a name="line.86"></a>
-<span class="sourceLineNo">087</span> regionNode.lock();<a name="line.87"></a>
-<span class="sourceLineNo">088</span> try {<a name="line.88"></a>
-<span class="sourceLineNo">089</span> if (regionNode.getProcedure() != null) {<a name="line.89"></a>
-<span class="sourceLineNo">090</span> continue;<a name="line.90"></a>
-<span class="sourceLineNo">091</span> }<a name="line.91"></a>
-<span class="sourceLineNo">092</span> proc = TransitRegionStateProcedure.reopen(env, regionNode.getRegionInfo());<a name="line.92"></a>
-<span class="sourceLineNo">093</span> regionNode.setProcedure(proc);<a name="line.93"></a>
-<span class="sourceLineNo">094</span> } finally {<a name="line.94"></a>
-<span class="sourceLineNo">095</span> regionNode.unlock();<a name="line.95"></a>
-<span class="sourceLineNo">096</span> }<a name="line.96"></a>
-<span class="sourceLineNo">097</span> addChildProcedure(proc);<a name="line.97"></a>
-<span class="sourceLineNo">098</span> }<a name="line.98"></a>
-<span class="sourceLineNo">099</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_CONFIRM_REOPENED);<a name="line.99"></a>
-<span class="sourceLineNo">100</span> return Flow.HAS_MORE_STATE;<a name="line.100"></a>
-<span class="sourceLineNo">101</span> case REOPEN_TABLE_REGIONS_CONFIRM_REOPENED:<a name="line.101"></a>
-<span class="sourceLineNo">102</span> regions = regions.stream().map(env.getAssignmentManager().getRegionStates()::checkReopened)<a name="line.102"></a>
-<span class="sourceLineNo">103</span> .filter(l -> l != null).collect(Collectors.toList());<a name="line.103"></a>
-<span class="sourceLineNo">104</span> if (regions.isEmpty()) {<a name="line.104"></a>
-<span class="sourceLineNo">105</span> return Flow.NO_MORE_STATE;<a name="line.105"></a>
-<span class="sourceLineNo">106</span> }<a name="line.106"></a>
-<span class="sourceLineNo">107</span> if (regions.stream().anyMatch(l -> l.getSeqNum() >= 0)) {<a name="line.107"></a>
-<span class="sourceLineNo">108</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_REOPEN_REGIONS);<a name="line.108"></a>
-<span class="sourceLineNo">109</span> return Flow.HAS_MORE_STATE;<a name="line.109"></a>
+<span class="sourceLineNo">059</span> public ReopenTableRegionsProcedure(TableName tableName) {<a name="line.59"></a>
+<span class="sourceLineNo">060</span> this.tableName = tableName;<a name="line.60"></a>
+<span class="sourceLineNo">061</span> }<a name="line.61"></a>
+<span class="sourceLineNo">062</span><a name="line.62"></a>
+<span class="sourceLineNo">063</span> @Override<a name="line.63"></a>
+<span class="sourceLineNo">064</span> public TableName getTableName() {<a name="line.64"></a>
+<span class="sourceLineNo">065</span> return tableName;<a name="line.65"></a>
+<span class="sourceLineNo">066</span> }<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span> @Override<a name="line.68"></a>
+<span class="sourceLineNo">069</span> public TableOperationType getTableOperationType() {<a name="line.69"></a>
+<span class="sourceLineNo">070</span> return TableOperationType.REGION_EDIT;<a name="line.70"></a>
+<span class="sourceLineNo">071</span> }<a name="line.71"></a>
+<span class="sourceLineNo">072</span><a name="line.72"></a>
+<span class="sourceLineNo">073</span> @Override<a name="line.73"></a>
+<span class="sourceLineNo">074</span> protected Flow executeFromState(MasterProcedureEnv env, ReopenTableRegionsState state)<a name="line.74"></a>
+<span class="sourceLineNo">075</span> throws ProcedureSuspendedException, ProcedureYieldException, InterruptedException {<a name="line.75"></a>
+<span class="sourceLineNo">076</span> switch (state) {<a name="line.76"></a>
+<span class="sourceLineNo">077</span> case REOPEN_TABLE_REGIONS_GET_REGIONS:<a name="line.77"></a>
+<span class="sourceLineNo">078</span> if (!env.getAssignmentManager().isTableEnabled(tableName)) {<a name="line.78"></a>
+<span class="sourceLineNo">079</span> LOG.info("Table {} is disabled, give up reopening its regions");<a name="line.79"></a>
+<span class="sourceLineNo">080</span> return Flow.NO_MORE_STATE;<a name="line.80"></a>
+<span class="sourceLineNo">081</span> }<a name="line.81"></a>
+<span class="sourceLineNo">082</span> regions =<a name="line.82"></a>
+<span class="sourceLineNo">083</span> env.getAssignmentManager().getRegionStates().getRegionsOfTableForReopen(tableName);<a name="line.83"></a>
+<span class="sourceLineNo">084</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_REOPEN_REGIONS);<a name="line.84"></a>
+<span class="sourceLineNo">085</span> return Flow.HAS_MORE_STATE;<a name="line.85"></a>
+<span class="sourceLineNo">086</span> case REOPEN_TABLE_REGIONS_REOPEN_REGIONS:<a name="line.86"></a>
+<span class="sourceLineNo">087</span> for (HRegionLocation loc : regions) {<a name="line.87"></a>
+<span class="sourceLineNo">088</span> RegionStateNode regionNode = env.getAssignmentManager().getRegionStates()<a name="line.88"></a>
+<span class="sourceLineNo">089</span> .getOrCreateRegionStateNode(loc.getRegion());<a name="line.89"></a>
+<span class="sourceLineNo">090</span> TransitRegionStateProcedure proc;<a name="line.90"></a>
+<span class="sourceLineNo">091</span> regionNode.lock();<a name="line.91"></a>
+<span class="sourceLineNo">092</span> try {<a name="line.92"></a>
+<span class="sourceLineNo">093</span> if (regionNode.getProcedure() != null) {<a name="line.93"></a>
+<span class="sourceLineNo">094</span> continue;<a name="line.94"></a>
+<span class="sourceLineNo">095</span> }<a name="line.95"></a>
+<span class="sourceLineNo">096</span> proc = TransitRegionStateProcedure.reopen(env, regionNode.getRegionInfo());<a name="line.96"></a>
+<span class="sourceLineNo">097</span> regionNode.setProcedure(proc);<a name="line.97"></a>
+<span class="sourceLineNo">098</span> } finally {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> regionNode.unlock();<a name="line.99"></a>
+<span class="sourceLineNo">100</span> }<a name="line.100"></a>
+<span class="sourceLineNo">101</span> addChildProcedure(proc);<a name="line.101"></a>
+<span class="sourceLineNo">102</span> }<a name="line.102"></a>
+<span class="sourceLineNo">103</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_CONFIRM_REOPENED);<a name="line.103"></a>
+<span class="sourceLineNo">104</span> return Flow.HAS_MORE_STATE;<a name="line.104"></a>
+<span class="sourceLineNo">105</span> case REOPEN_TABLE_REGIONS_CONFIRM_REOPENED:<a name="line.105"></a>
+<span class="sourceLineNo">106</span> regions = regions.stream().map(env.getAssignmentManager().getRegionStates()::checkReopened)<a name="line.106"></a>
+<span class="sourceLineNo">107</span> .filter(l -> l != null).collect(Collectors.toList());<a name="line.107"></a>
+<span class="sourceLineNo">108</span> if (regions.isEmpty()) {<a name="line.108"></a>
+<span class="sourceLineNo">109</span> return Flow.NO_MORE_STATE;<a name="line.109"></a>
<span class="sourceLineNo">110</span> }<a name="line.110"></a>
-<span class="sourceLineNo">111</span> LOG.info("There are still {} region(s) which need to be reopened for table {} are in " +<a name="line.111"></a>
-<span class="sourceLineNo">112</span> "OPENING state, try again later", regions.size(), tableName);<a name="line.112"></a>
-<span class="sourceLineNo">113</span> // All the regions need to reopen are in OPENING state which means we can not schedule any<a name="line.113"></a>
-<span class="sourceLineNo">114</span> // MRPs. Then sleep for one second, and yield the procedure to let other procedures run<a name="line.114"></a>
-<span class="sourceLineNo">115</span> // first and hope next time we can get some regions in other state to make progress.<a name="line.115"></a>
-<span class="sourceLineNo">116</span> // TODO: add a delay for ProcedureYieldException so that we do not need to sleep here which<a name="line.116"></a>
-<span class="sourceLineNo">117</span> // blocks a procedure worker.<a name="line.117"></a>
-<span class="sourceLineNo">118</span> Thread.sleep(1000);<a name="line.118"></a>
-<span class="sourceLineNo">119</span> throw new ProcedureYieldException();<a name="line.119"></a>
-<span class="sourceLineNo">120</span> default:<a name="line.120"></a>
-<span class="sourceLineNo">121</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.121"></a>
-<span class="sourceLineNo">122</span> }<a name="line.122"></a>
-<span class="sourceLineNo">123</span> }<a name="line.123"></a>
-<span class="sourceLineNo">124</span><a name="line.124"></a>
-<span class="sourceLineNo">125</span> @Override<a name="line.125"></a>
-<span class="sourceLineNo">126</span> protected void rollbackState(MasterProcedureEnv env, ReopenTableRegionsState state)<a name="line.126"></a>
-<span class="sourceLineNo">127</span> throws IOException, InterruptedException {<a name="line.127"></a>
-<span class="sourceLineNo">128</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.128"></a>
+<span class="sourceLineNo">111</span> if (regions.stream().anyMatch(l -> l.getSeqNum() >= 0)) {<a name="line.111"></a>
+<span class="sourceLineNo">112</span> attempt = 0;<a name="line.112"></a>
+<span class="sourceLineNo">113</span> setNextState(ReopenTableRegionsState.REOPEN_TABLE_REGIONS_REOPEN_REGIONS);<a name="line.113"></a>
+<span class="sourceLineNo">114</span> return Flow.HAS_MORE_STATE;<a name="line.114"></a>
+<span class="sourceLineNo">115</span> }<a name="line.115"></a>
+<span class="sourceLineNo">116</span> // All the regions need to reopen are in OPENING state which means we can not schedule any<a name="line.116"></a>
+<span class="sourceLineNo">117</span> // MRPs.<a name="line.117"></a>
+<span class="sourceLineNo">118</span> long backoff = ProcedureUtil.getBackoffTimeMs(this.attempt++);<a name="line.118"></a>
+<span class="sourceLineNo">119</span> LOG.info(<a name="line.119"></a>
+<span class="sourceLineNo">120</span> "There are still {} region(s) which need to be reopened for table {} are in " +<a name="line.120"></a>
+<span class="sourceLineNo">121</span> "OPENING state, suspend {}secs and try again later",<a name="line.121"></a>
+<span class="sourceLineNo">122</span> regions.size(), tableName, backoff / 1000);<a name="line.122"></a>
+<span class="sourceLineNo">123</span> setTimeout(Math.toIntExact(backoff));<a name="line.123"></a>
+<span class="sourceLineNo">124</span> setState(ProcedureProtos.ProcedureState.WAITING_TIMEOUT);<a name="line.124"></a>
+<span class="sourceLineNo">125</span> throw new ProcedureSuspendedException();<a name="line.125"></a>
+<span class="sourceLineNo">126</span> default:<a name="line.126"></a>
+<span class="sourceLineNo">127</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> }<a name="line.128"></a>
<span class="sourceLineNo">129</span> }<a name="line.129"></a>
<span class="sourceLineNo">130</span><a name="line.130"></a>
-<span class="sourceLineNo">131</span> @Override<a name="line.131"></a>
-<span class="sourceLineNo">132</span> protected ReopenTableRegionsState getState(int stateId) {<a name="line.132"></a>
-<span class="sourceLineNo">133</span> return ReopenTableRegionsState.forNumber(stateId);<a name="line.133"></a>
-<span class="sourceLineNo">134</span> }<a name="line.134"></a>
-<span class="sourceLineNo">135</span><a name="line.135"></a>
-<span class="sourceLineNo">136</span> @Override<a name="line.136"></a>
-<span class="sourceLineNo">137</span> protected int getStateId(ReopenTableRegionsState state) {<a name="line.137"></a>
-<span class="sourceLineNo">138</span> return state.getNumber();<a name="line.138"></a>
+<span class="sourceLineNo">131</span> /**<a name="line.131"></a>
+<span class="sourceLineNo">132</span> * At end of timeout, wake ourselves up so we run again.<a name="line.132"></a>
+<span class="sourceLineNo">133</span> */<a name="line.133"></a>
+<span class="sourceLineNo">134</span> @Override<a name="line.134"></a>
+<span class="sourceLineNo">135</span> protected synchronized boolean setTimeoutFailure(MasterProcedureEnv env) {<a name="line.135"></a>
+<span class="sourceLineNo">136</span> setState(ProcedureProtos.ProcedureState.RUNNABLE);<a name="line.136"></a>
+<span class="sourceLineNo">137</span> env.getProcedureScheduler().addFront(this);<a name="line.137"></a>
+<span class="sourceLineNo">138</span> return false; // 'false' means that this procedure handled the timeout<a name="line.138"></a>
<span class="sourceLineNo">139</span> }<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span> @Override<a name="line.141"></a>
-<span class="sourceLineNo">142</span> protected ReopenTableRegionsState getInitialState() {<a name="line.142"></a>
-<span class="sourceLineNo">143</span> return ReopenTableRegionsState.REOPEN_TABLE_REGIONS_GET_REGIONS;<a name="line.143"></a>
+<span class="sourceLineNo">140</span> @Override<a name="line.140"></a>
+<span class="sourceLineNo">141</span> protected void rollbackState(MasterProcedureEnv env, ReopenTableRegionsState state)<a name="line.141"></a>
+<span class="sourceLineNo">142</span> throws IOException, InterruptedException {<a name="line.142"></a>
+<span class="sourceLineNo">143</span> throw new UnsupportedOperationException("unhandled state=" + state);<a name="line.143"></a>
<span class="sourceLineNo">144</span> }<a name="line.144"></a>
<span class="sourceLineNo">145</span><a name="line.145"></a>
<span class="sourceLineNo">146</span> @Override<a name="line.146"></a>
-<span class="sourceLineNo">147</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.147"></a>
-<span class="sourceLineNo">148</span> super.serializeStateData(serializer);<a name="line.148"></a>
-<span class="sourceLineNo">149</span> ReopenTableRegionsStateData.Builder builder = ReopenTableRegionsStateData.newBuilder()<a name="line.149"></a>
-<span class="sourceLineNo">150</span> .setTableName(ProtobufUtil.toProtoTableName(tableName));<a name="line.150"></a>
-<span class="sourceLineNo">151</span> regions.stream().map(ProtobufUtil::toRegionLocation).forEachOrdered(builder::addRegion);<a name="line.151"></a>
-<span class="sourceLineNo">152</span> serializer.serialize(builder.build());<a name="line.152"></a>
-<span class="sourceLineNo">153</span> }<a name="line.153"></a>
-<span class="sourceLineNo">154</span><a name="line.154"></a>
-<span class="sourceLineNo">155</span> @Override<a name="line.155"></a>
-<span class="sourceLineNo">156</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.156"></a>
-<span class="sourceLineNo">157</span> super.deserializeStateData(serializer);<a name="line.157"></a>
-<span class="sourceLineNo">158</span> ReopenTableRegionsStateData data = serializer.deserialize(ReopenTableRegionsStateData.class);<a name="line.158"></a>
-<span class="sourceLineNo">159</span> tableName = ProtobufUtil.toTableName(data.getTableName());<a name="line.159"></a>
-<span class="sourceLineNo">160</span> regions = data.getRegionList().stream().map(ProtobufUtil::toRegionLocation)<a name="line.160"></a>
-<span class="sourceLineNo">161</span> .collect(Collectors.toList());<a name="line.161"></a>
-<span class="sourceLineNo">162</span> }<a name="line.162"></a>
-<span class="sourceLineNo">163</span>}<a name="line.163"></a>
+<span class="sourceLineNo">147</span> protected ReopenTableRegionsState getState(int stateId) {<a name="line.147"></a>
+<span class="sourceLineNo">148</span> return ReopenTableRegionsState.forNumber(stateId);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> }<a name="line.149"></a>
+<span class="sourceLineNo">150</span><a name="line.150"></a>
+<span class="sourceLineNo">151</span> @Override<a name="line.151"></a>
+<span class="sourceLineNo">152</span> protected int getStateId(ReopenTableRegionsState state) {<a name="line.152"></a>
+<span class="sourceLineNo">153</span> return state.getNumber();<a name="line.153"></a>
+<span class="sourceLineNo">154</span> }<a name="line.154"></a>
+<span class="sourceLineNo">155</span><a name="line.155"></a>
+<span class="sourceLineNo">156</span> @Override<a name="line.156"></a>
+<span class="sourceLineNo">157</span> protected ReopenTableRegionsState getInitialState() {<a name="line.157"></a>
+<span class="sourceLineNo">158</span> return ReopenTableRegionsState.REOPEN_TABLE_REGIONS_GET_REGIONS;<a name="line.158"></a>
+<span class="sourceLineNo">159</span> }<a name="line.159"></a>
+<span class="sourceLineNo">160</span><a name="line.160"></a>
+<span class="sourceLineNo">161</span> @Override<a name="line.161"></a>
+<span class="sourceLineNo">162</span> protected void serializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.162"></a>
+<span class="sourceLineNo">163</span> super.serializeStateData(serializer);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> ReopenTableRegionsStateData.Builder builder = ReopenTableRegionsStateData.newBuilder()<a name="line.164"></a>
+<span class="sourceLineNo">165</span> .setTableName(ProtobufUtil.toProtoTableName(tableName));<a name="line.165"></a>
+<span class="sourceLineNo">166</span> regions.stream().map(ProtobufUtil::toRegionLocation).forEachOrdered(builder::addRegion);<a name="line.166"></a>
+<span class="sourceLineNo">167</span> serializer.serialize(builder.build());<a name="line.167"></a>
+<span class="sourceLineNo">168</span> }<a name="line.168"></a>
+<span class="sourceLineNo">169</span><a name="line.169"></a>
+<span class="sourceLineNo">170</span> @Override<a name="line.170"></a>
+<span class="sourceLineNo">171</span> protected void deserializeStateData(ProcedureStateSerializer serializer) throws IOException {<a name="line.171"></a>
+<span class="sourceLineNo">172</span> super.deserializeStateData(serializer);<a name="line.172"></a>
+<span class="sourceLineNo">173</span> ReopenTableRegionsStateData data = serializer.deserialize(ReopenTableRegionsStateData.class);<a name="line.173"></a>
+<span class="sourceLineNo">174</span> tableName = ProtobufUtil.toTableName(data.getTableName());<a name="line.174"></a>
+<span class="sourceLineNo">175</span> regions = data.getRegionList().stream().map(ProtobufUtil::toRegionLocation)<a name="line.175"></a>
+<span class="sourceLineNo">176</span> .collect(Collectors.toList());<a name="line.176"></a>
+<span class="sourceLineNo">177</span> }<a name="line.177"></a>
+<span class="sourceLineNo">178</span>}<a name="line.178"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/dcc97e01/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/Procedure.LockState.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/Procedure.LockState.html b/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/Procedure.LockState.html
index c081310..c7f1e58 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/Procedure.LockState.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/procedure2/Procedure.LockState.html
@@ -774,280 +774,287 @@
<span class="sourceLineNo">766</span><a name="line.766"></a>
<span class="sourceLineNo">767</span> /**<a name="line.767"></a>
<span class="sourceLineNo">768</span> * Called by the ProcedureExecutor when the timeout set by setTimeout() is expired.<a name="line.768"></a>
-<span class="sourceLineNo">769</span> * @return true to let the framework handle the timeout as abort, false in case the procedure<a name="line.769"></a>
-<span class="sourceLineNo">770</span> * handled the timeout itself.<a name="line.770"></a>
-<span class="sourceLineNo">771</span> */<a name="line.771"></a>
-<span class="sourceLineNo">772</span> protected synchronized boolean setTimeoutFailure(TEnvironment env) {<a name="line.772"></a>
-<span class="sourceLineNo">773</span> if (state == ProcedureState.WAITING_TIMEOUT) {<a name="line.773"></a>
-<span class="sourceLineNo">774</span> long timeDiff = EnvironmentEdgeManager.currentTime() - lastUpdate;<a name="line.774"></a>
-<span class="sourceLineNo">775</span> setFailure("ProcedureExecutor", new TimeoutIOException(<a name="line.775"></a>
-<span class="sourceLineNo">776</span> "Operation timed out after " + StringUtils.humanTimeDiff(timeDiff)));<a name="line.776"></a>
-<span class="sourceLineNo">777</span> return true;<a name="line.777"></a>
-<span class="sourceLineNo">778</span> }<a name="line.778"></a>
-<span class="sourceLineNo">779</span> return false;<a name="line.779"></a>
-<span class="sourceLineNo">780</span> }<a name="line.780"></a>
-<span class="sourceLineNo">781</span><a name="line.781"></a>
-<span class="sourceLineNo">782</span> public synchronized boolean hasException() {<a name="line.782"></a>
-<span class="sourceLineNo">783</span> return exception != null;<a name="line.783"></a>
-<span class="sourceLineNo">784</span> }<a name="line.784"></a>
-<span class="sourceLineNo">785</span><a name="line.785"></a>
-<span class="sourceLineNo">786</span> public synchronized RemoteProcedureException getException() {<a name="line.786"></a>
-<span class="sourceLineNo">787</span> return exception;<a name="line.787"></a>
-<span class="sourceLineNo">788</span> }<a name="line.788"></a>
-<span class="sourceLineNo">789</span><a name="line.789"></a>
-<span class="sourceLineNo">790</span> /**<a name="line.790"></a>
-<span class="sourceLineNo">791</span> * Called by the ProcedureExecutor on procedure-load to restore the latch state<a name="line.791"></a>
-<span class="sourceLineNo">792</span> */<a name="line.792"></a>
-<span class="sourceLineNo">793</span> protected synchronized void setChildrenLatch(int numChildren) {<a name="line.793"></a>
-<span class="sourceLineNo">794</span> this.childrenLatch = numChildren;<a name="line.794"></a>
-<span class="sourceLineNo">795</span> if (LOG.isTraceEnabled()) {<a name="line.795"></a>
-<span class="sourceLineNo">796</span> LOG.trace("CHILD LATCH INCREMENT SET " +<a name="line.796"></a>
-<span class="sourceLineNo">797</span> this.childrenLatch, new Throwable(this.toString()));<a name="line.797"></a>
-<span class="sourceLineNo">798</span> }<a name="line.798"></a>
-<span class="sourceLineNo">799</span> }<a name="line.799"></a>
-<span class="sourceLineNo">800</span><a name="line.800"></a>
-<span class="sourceLineNo">801</span> /**<a name="line.801"></a>
-<span class="sourceLineNo">802</span> * Called by the ProcedureExecutor on procedure-load to restore the latch state<a name="line.802"></a>
-<span class="sourceLineNo">803</span> */<a name="line.803"></a>
-<span class="sourceLineNo">804</span> protected synchronized void incChildrenLatch() {<a name="line.804"></a>
-<span class="sourceLineNo">805</span> // TODO: can this be inferred from the stack? I think so...<a name="line.805"></a>
-<span class="sourceLineNo">806</span> this.childrenLatch++;<a name="line.806"></a>
-<span class="sourceLineNo">807</span> if (LOG.isTraceEnabled()) {<a name="line.807"></a>
-<span class="sourceLineNo">808</span> LOG.trace("CHILD LATCH INCREMENT " + this.childrenLatch, new Throwable(this.toString()));<a name="line.808"></a>
-<span class="sourceLineNo">809</span> }<a name="line.809"></a>
-<span class="sourceLineNo">810</span> }<a name="line.810"></a>
-<span class="sourceLineNo">811</span><a name="line.811"></a>
-<span class="sourceLineNo">812</span> /**<a name="line.812"></a>
-<span class="sourceLineNo">813</span> * Called by the ProcedureExecutor to notify that one of the sub-procedures has completed.<a name="line.813"></a>
-<span class="sourceLineNo">814</span> */<a name="line.814"></a>
-<span class="sourceLineNo">815</span> private synchronized boolean childrenCountDown() {<a name="line.815"></a>
-<span class="sourceLineNo">816</span> assert childrenLatch > 0: this;<a name="line.816"></a>
-<span class="sourceLineNo">817</span> boolean b = --childrenLatch == 0;<a name="line.817"></a>
-<span class="sourceLineNo">818</span> if (LOG.isTraceEnabled()) {<a name="line.818"></a>
-<span class="sourceLineNo">819</span> LOG.trace("CHILD LATCH DECREMENT " + childrenLatch, new Throwable(this.toString()));<a name="line.819"></a>
-<span class="sourceLineNo">820</span> }<a name="line.820"></a>
-<span class="sourceLineNo">821</span> return b;<a name="line.821"></a>
-<span class="sourceLineNo">822</span> }<a name="line.822"></a>
-<span class="sourceLineNo">823</span><a name="line.823"></a>
-<span class="sourceLineNo">824</span> /**<a name="line.824"></a>
-<span class="sourceLineNo">825</span> * Try to set this procedure into RUNNABLE state.<a name="line.825"></a>
-<span class="sourceLineNo">826</span> * Succeeds if all subprocedures/children are done.<a name="line.826"></a>
-<span class="sourceLineNo">827</span> * @return True if we were able to move procedure to RUNNABLE state.<a name="line.827"></a>
-<span class="sourceLineNo">828</span> */<a name="line.828"></a>
-<span class="sourceLineNo">829</span> synchronized boolean tryRunnable() {<a name="line.829"></a>
-<span class="sourceLineNo">830</span> // Don't use isWaiting in the below; it returns true for WAITING and WAITING_TIMEOUT<a name="line.830"></a>
-<span class="sourceLineNo">831</span> if (getState() == ProcedureState.WAITING && childrenCountDown()) {<a name="line.831"></a>
-<span class="sourceLineNo">832</span> setState(ProcedureState.RUNNABLE);<a name="line.832"></a>
-<span class="sourceLineNo">833</span> return true;<a name="line.833"></a>
-<span class="sourceLineNo">834</span> } else {<a name="line.834"></a>
-<span class="sourceLineNo">835</span> return false;<a name="line.835"></a>
-<span class="sourceLineNo">836</span> }<a name="line.836"></a>
-<span class="sourceLineNo">837</span> }<a name="line.837"></a>
-<span class="sourceLineNo">838</span><a name="line.838"></a>
-<span class="sourceLineNo">839</span> protected synchronized boolean hasChildren() {<a name="line.839"></a>
-<span class="sourceLineNo">840</span> return childrenLatch > 0;<a name="line.840"></a>
-<span class="sourceLineNo">841</span> }<a name="line.841"></a>
-<span class="sourceLineNo">842</span><a name="line.842"></a>
-<span class="sourceLineNo">843</span> protected synchronized int getChildrenLatch() {<a name="line.843"></a>
-<span class="sourceLineNo">844</span> return childrenLatch;<a name="line.844"></a>
-<span class="sourceLineNo">845</span> }<a name="line.845"></a>
-<span class="sourceLineNo">846</span><a name="line.846"></a>
-<span class="sourceLineNo">847</span> /**<a name="line.847"></a>
-<span class="sourceLineNo">848</span> * Called by the RootProcedureState on procedure execution.<a name="line.848"></a>
-<span class="sourceLineNo">849</span> * Each procedure store its stack-index positions.<a name="line.849"></a>
-<span class="sourceLineNo">850</span> */<a name="line.850"></a>
-<span class="sourceLineNo">851</span> protected synchronized void addStackIndex(final int index) {<a name="line.851"></a>
-<span class="sourceLineNo">852</span> if (stackIndexes == null) {<a name="line.852"></a>
-<span class="sourceLineNo">853</span> stackIndexes = new int[] { index };<a name="line.853"></a>
-<span class="sourceLineNo">854</span> } else {<a name="line.854"></a>
-<span class="sourceLineNo">855</span> int count = stackIndexes.length;<a name="line.855"></a>
-<span class="sourceLineNo">856</span> stackIndexes = Arrays.copyOf(stackIndexes, count + 1);<a name="line.856"></a>
-<span class="sourceLineNo">857</span> stackIndexes[count] = index;<a name="line.857"></a>
-<span class="sourceLineNo">858</span> }<a name="line.858"></a>
-<span class="sourceLineNo">859</span> }<a name="line.859"></a>
-<span class="sourceLineNo">860</span><a name="line.860"></a>
-<span class="sourceLineNo">861</span> protected synchronized boolean removeStackIndex() {<a name="line.861"></a>
-<span class="sourceLineNo">862</span> if (stackIndexes != null && stackIndexes.length > 1) {<a name="line.862"></a>
-<span class="sourceLineNo">863</span> stackIndexes = Arrays.copyOf(stackIndexes, stackIndexes.length - 1);<a name="line.863"></a>
-<span class="sourceLineNo">864</span> return false;<a name="line.864"></a>
-<span class="sourceLineNo">865</span> } else {<a name="line.865"></a>
-<span class="sourceLineNo">866</span> stackIndexes = null;<a name="line.866"></a>
-<span class="sourceLineNo">867</span> return true;<a name="line.867"></a>
-<span class="sourceLineNo">868</span> }<a name="line.868"></a>
-<span class="sourceLineNo">869</span> }<a name="line.869"></a>
-<span class="sourceLineNo">870</span><a name="line.870"></a>
-<span class="sourceLineNo">871</span> /**<a name="line.871"></a>
-<span class="sourceLineNo">872</span> * Called on store load to initialize the Procedure internals after<a name="line.872"></a>
-<span class="sourceLineNo">873</span> * the creation/deserialization.<a name="line.873"></a>
-<span class="sourceLineNo">874</span> */<a name="line.874"></a>
-<span class="sourceLineNo">875</span> protected synchronized void setStackIndexes(final List<Integer> stackIndexes) {<a name="line.875"></a>
-<span class="sourceLineNo">876</span> this.stackIndexes = new int[stackIndexes.size()];<a name="line.876"></a>
-<span class="sourceLineNo">877</span> for (int i = 0; i < this.stackIndexes.length; ++i) {<a name="line.877"></a>
-<span class="sourceLineNo">878</span> this.stackIndexes[i] = stackIndexes.get(i);<a name="line.878"></a>
-<span class="sourceLineNo">879</span> }<a name="line.879"></a>
-<span class="sourceLineNo">880</span> }<a name="line.880"></a>
-<span class="sourceLineNo">881</span><a name="line.881"></a>
-<span class="sourceLineNo">882</span> protected synchronized boolean wasExecuted() {<a name="line.882"></a>
-<span class="sourceLineNo">883</span> return stackIndexes != null;<a name="line.883"></a>
-<span class="sourceLineNo">884</span> }<a name="line.884"></a>
-<span class="sourceLineNo">885</span><a name="line.885"></a>
-<span class="sourceLineNo">886</span> protected synchronized int[] getStackIndexes() {<a name="line.886"></a>
-<span class="sourceLineNo">887</span> return stackIndexes;<a name="line.887"></a>
-<span class="sourceLineNo">888</span> }<a name="line.888"></a>
-<span class="sourceLineNo">889</span><a name="line.889"></a>
-<span class="sourceLineNo">890</span> // ==========================================================================<a name="line.890"></a>
-<span class="sourceLineNo">891</span> // Internal methods - called by the ProcedureExecutor<a name="line.891"></a>
-<span class="sourceLineNo">892</span> // ==========================================================================<a name="line.892"></a>
-<span class="sourceLineNo">893</span><a name="line.893"></a>
-<span class="sourceLineNo">894</span> /**<a name="line.894"></a>
-<span class="sourceLineNo">895</span> * Internal method called by the ProcedureExecutor that starts the user-level code execute().<a name="line.895"></a>
-<span class="sourceLineNo">896</span> * @throws ProcedureSuspendedException This is used when procedure wants to halt processing and<a name="line.896"></a>
-<span class="sourceLineNo">897</span> * skip out without changing states or releasing any locks held.<a name="line.897"></a>
-<span class="sourceLineNo">898</span> */<a name="line.898"></a>
-<span class="sourceLineNo">899</span> protected Procedure<TEnvironment>[] doExecute(TEnvironment env)<a name="line.899"></a>
-<span class="sourceLineNo">900</span> throws ProcedureYieldException, ProcedureSuspendedException, InterruptedException {<a name="line.900"></a>
-<span class="sourceLineNo">901</span> try {<a name="line.901"></a>
-<span class="sourceLineNo">902</span> updateTimestamp();<a name="line.902"></a>
-<span class="sourceLineNo">903</span> if (bypass) {<a name="line.903"></a>
-<span class="sourceLineNo">904</span> LOG.info("{} bypassed, returning null to finish it", this);<a name="line.904"></a>
-<span class="sourceLineNo">905</span> return null;<a name="line.905"></a>
-<span class="sourceLineNo">906</span> }<a name="line.906"></a>
-<span class="sourceLineNo">907</span> return execute(env);<a name="line.907"></a>
-<span class="sourceLineNo">908</span> } finally {<a name="line.908"></a>
+<span class="sourceLineNo">769</span> * <p/><a name="line.769"></a>
+<span class="sourceLineNo">770</span> * Another usage for this method is to implement retrying. A procedure can set the state to<a name="line.770"></a>
+<span class="sourceLineNo">771</span> * {@code WAITING_TIMEOUT} by calling {@code setState} method, and throw a<a name="line.771"></a>
+<span class="sourceLineNo">772</span> * {@link ProcedureSuspendedException} to halt the execution of the procedure, and do not forget a<a name="line.772"></a>
+<span class="sourceLineNo">773</span> * call {@link #setTimeout(int)} method to set the timeout. And you should also override this<a name="line.773"></a>
+<span class="sourceLineNo">774</span> * method to wake up the procedure, and also return false to tell the ProcedureExecutor that the<a name="line.774"></a>
+<span class="sourceLineNo">775</span> * timeout event has been handled.<a name="line.775"></a>
+<span class="sourceLineNo">776</span> * @return true to let the framework handle the timeout as abort, false in case the procedure<a name="line.776"></a>
+<span class="sourceLineNo">777</span> * handled the timeout itself.<a name="line.777"></a>
+<span class="sourceLineNo">778</span> */<a name="line.778"></a>
+<span class="sourceLineNo">779</span> protected synchronized boolean setTimeoutFailure(TEnvironment env) {<a name="line.779"></a>
+<span class="sourceLineNo">780</span> if (state == ProcedureState.WAITING_TIMEOUT) {<a name="line.780"></a>
+<span class="sourceLineNo">781</span> long timeDiff = EnvironmentEdgeManager.currentTime() - lastUpdate;<a name="line.781"></a>
+<span class="sourceLineNo">782</span> setFailure("ProcedureExecutor",<a name="line.782"></a>
+<span class="sourceLineNo">783</span> new TimeoutIOException("Operation timed out after " + StringUtils.humanTimeDiff(timeDiff)));<a name="line.783"></a>
+<span class="sourceLineNo">784</span> return true;<a name="line.784"></a>
+<span class="sourceLineNo">785</span> }<a name="line.785"></a>
+<span class="sourceLineNo">786</span> return false;<a name="line.786"></a>
+<span class="sourceLineNo">787</span> }<a name="line.787"></a>
+<span class="sourceLineNo">788</span><a name="line.788"></a>
+<span class="sourceLineNo">789</span> public synchronized boolean hasException() {<a name="line.789"></a>
+<span class="sourceLineNo">790</span> return exception != null;<a name="line.790"></a>
+<span class="sourceLineNo">791</span> }<a name="line.791"></a>
+<span class="sourceLineNo">792</span><a name="line.792"></a>
+<span class="sourceLineNo">793</span> public synchronized RemoteProcedureException getException() {<a name="line.793"></a>
+<span class="sourceLineNo">794</span> return exception;<a name="line.794"></a>
+<span class="sourceLineNo">795</span> }<a name="line.795"></a>
+<span class="sourceLineNo">796</span><a name="line.796"></a>
+<span class="sourceLineNo">797</span> /**<a name="line.797"></a>
+<span class="sourceLineNo">798</span> * Called by the ProcedureExecutor on procedure-load to restore the latch state<a name="line.798"></a>
+<span class="sourceLineNo">799</span> */<a name="line.799"></a>
+<span class="sourceLineNo">800</span> protected synchronized void setChildrenLatch(int numChildren) {<a name="line.800"></a>
+<span class="sourceLineNo">801</span> this.childrenLatch = numChildren;<a name="line.801"></a>
+<span class="sourceLineNo">802</span> if (LOG.isTraceEnabled()) {<a name="line.802"></a>
+<span class="sourceLineNo">803</span> LOG.trace("CHILD LATCH INCREMENT SET " +<a name="line.803"></a>
+<span class="sourceLineNo">804</span> this.childrenLatch, new Throwable(this.toString()));<a name="line.804"></a>
+<span class="sourceLineNo">805</span> }<a name="line.805"></a>
+<span class="sourceLineNo">806</span> }<a name="line.806"></a>
+<span class="sourceLineNo">807</span><a name="line.807"></a>
+<span class="sourceLineNo">808</span> /**<a name="line.808"></a>
+<span class="sourceLineNo">809</span> * Called by the ProcedureExecutor on procedure-load to restore the latch state<a name="line.809"></a>
+<span class="sourceLineNo">810</span> */<a name="line.810"></a>
+<span class="sourceLineNo">811</span> protected synchronized void incChildrenLatch() {<a name="line.811"></a>
+<span class="sourceLineNo">812</span> // TODO: can this be inferred from the stack? I think so...<a name="line.812"></a>
+<span class="sourceLineNo">813</span> this.childrenLatch++;<a name="line.813"></a>
+<span class="sourceLineNo">814</span> if (LOG.isTraceEnabled()) {<a name="line.814"></a>
+<span class="sourceLineNo">815</span> LOG.trace("CHILD LATCH INCREMENT " + this.childrenLatch, new Throwable(this.toString()));<a name="line.815"></a>
+<span class="sourceLineNo">816</span> }<a name="line.816"></a>
+<span class="sourceLineNo">817</span> }<a name="line.817"></a>
+<span class="sourceLineNo">818</span><a name="line.818"></a>
+<span class="sourceLineNo">819</span> /**<a name="line.819"></a>
+<span class="sourceLineNo">820</span> * Called by the ProcedureExecutor to notify that one of the sub-procedures has completed.<a name="line.820"></a>
+<span class="sourceLineNo">821</span> */<a name="line.821"></a>
+<span class="sourceLineNo">822</span> private synchronized boolean childrenCountDown() {<a name="line.822"></a>
+<span class="sourceLineNo">823</span> assert childrenLatch > 0: this;<a name="line.823"></a>
+<span class="sourceLineNo">824</span> boolean b = --childrenLatch == 0;<a name="line.824"></a>
+<span class="sourceLineNo">825</span> if (LOG.isTraceEnabled()) {<a name="line.825"></a>
+<span class="sourceLineNo">826</span> LOG.trace("CHILD LATCH DECREMENT " + childrenLatch, new Throwable(this.toString()));<a name="line.826"></a>
+<span class="sourceLineNo">827</span> }<a name="line.827"></a>
+<span class="sourceLineNo">828</span> return b;<a name="line.828"></a>
+<span class="sourceLineNo">829</span> }<a name="line.829"></a>
+<span class="sourceLineNo">830</span><a name="line.830"></a>
+<span class="sourceLineNo">831</span> /**<a name="line.831"></a>
+<span class="sourceLineNo">832</span> * Try to set this procedure into RUNNABLE state.<a name="line.832"></a>
+<span class="sourceLineNo">833</span> * Succeeds if all subprocedures/children are done.<a name="line.833"></a>
+<span class="sourceLineNo">834</span> * @return True if we were able to move procedure to RUNNABLE state.<a name="line.834"></a>
+<span class="sourceLineNo">835</span> */<a name="line.835"></a>
+<span class="sourceLineNo">836</span> synchronized boolean tryRunnable() {<a name="line.836"></a>
+<span class="sourceLineNo">837</span> // Don't use isWaiting in the below; it returns true for WAITING and WAITING_TIMEOUT<a name="line.837"></a>
+<span class="sourceLineNo">838</span> if (getState() == ProcedureState.WAITING && childrenCountDown()) {<a name="line.838"></a>
+<span class="sourceLineNo">839</span> setState(ProcedureState.RUNNABLE);<a name="line.839"></a>
+<span class="sourceLineNo">840</span> return true;<a name="line.840"></a>
+<span class="sourceLineNo">841</span> } else {<a name="line.841"></a>
+<span class="sourceLineNo">842</span> return false;<a name="line.842"></a>
+<span class="sourceLineNo">843</span> }<a name="line.843"></a>
+<span class="sourceLineNo">844</span> }<a name="line.844"></a>
+<span class="sourceLineNo">845</span><a name="line.845"></a>
+<span class="sourceLineNo">846</span> protected synchronized boolean hasChildren() {<a name="line.846"></a>
+<span class="sourceLineNo">847</span> return childrenLatch > 0;<a name="line.847"></a>
+<span class="sourceLineNo">848</span> }<a name="line.848"></a>
+<span class="sourceLineNo">849</span><a name="line.849"></a>
+<span class="sourceLineNo">850</span> protected synchronized int getChildrenLatch() {<a name="line.850"></a>
+<span class="sourceLineNo">851</span> return childrenLatch;<a name="line.851"></a>
+<span class="sourceLineNo">852</span> }<a name="line.852"></a>
+<span class="sourceLineNo">853</span><a name="line.853"></a>
+<span class="sourceLineNo">854</span> /**<a name="line.854"></a>
+<span class="sourceLineNo">855</span> * Called by the RootProcedureState on procedure execution.<a name="line.855"></a>
+<span class="sourceLineNo">856</span> * Each procedure store its stack-index positions.<a name="line.856"></a>
+<span class="sourceLineNo">857</span> */<a name="line.857"></a>
+<span class="sourceLineNo">858</span> protected synchronized void addStackIndex(final int index) {<a name="line.858"></a>
+<span class="sourceLineNo">859</span> if (stackIndexes == null) {<a name="line.859"></a>
+<span class="sourceLineNo">860</span> stackIndexes = new int[] { index };<a name="line.860"></a>
+<span class="sourceLineNo">861</span> } else {<a name="line.861"></a>
+<span class="sourceLineNo">862</span> int count = stackIndexes.length;<a name="line.862"></a>
+<span class="sourceLineNo">863</span> stackIndexes = Arrays.copyOf(stackIndexes, count + 1);<a name="line.863"></a>
+<span class="sourceLineNo">864</span> stackIndexes[count] = index;<a name="line.864"></a>
+<span class="sourceLineNo">865</span> }<a name="line.865"></a>
+<span class="sourceLineNo">866</span> }<a name="line.866"></a>
+<span class="sourceLineNo">867</span><a name="line.867"></a>
+<span class="sourceLineNo">868</span> protected synchronized boolean removeStackIndex() {<a name="line.868"></a>
+<span class="sourceLineNo">869</span> if (stackIndexes != null && stackIndexes.length > 1) {<a name="line.869"></a>
+<span class="sourceLineNo">870</span> stackIndexes = Arrays.copyOf(stackIndexes, stackIndexes.length - 1);<a name="line.870"></a>
+<span class="sourceLineNo">871</span> return false;<a name="line.871"></a>
+<span class="sourceLineNo">872</span> } else {<a name="line.872"></a>
+<span class="sourceLineNo">873</span> stackIndexes = null;<a name="line.873"></a>
+<span class="sourceLineNo">874</span> return true;<a name="line.874"></a>
+<span class="sourceLineNo">875</span> }<a name="line.875"></a>
+<span class="sourceLineNo">876</span> }<a name="line.876"></a>
+<span class="sourceLineNo">877</span><a name="line.877"></a>
+<span class="sourceLineNo">878</span> /**<a name="line.878"></a>
+<span class="sourceLineNo">879</span> * Called on store load to initialize the Procedure internals after<a name="line.879"></a>
+<span class="sourceLineNo">880</span> * the creation/deserialization.<a name="line.880"></a>
+<span class="sourceLineNo">881</span> */<a name="line.881"></a>
+<span class="sourceLineNo">882</span> protected synchronized void setStackIndexes(final List<Integer> stackIndexes) {<a name="line.882"></a>
+<span class="sourceLineNo">883</span> this.stackIndexes = new int[stackIndexes.size()];<a name="line.883"></a>
+<span class="sourceLineNo">884</span> for (int i = 0; i < this.stackIndexes.length; ++i) {<a name="line.884"></a>
+<span class="sourceLineNo">885</span> this.stackIndexes[i] = stackIndexes.get(i);<a name="line.885"></a>
+<span class="sourceLineNo">886</span> }<a name="line.886"></a>
+<span class="sourceLineNo">887</span> }<a name="line.887"></a>
+<span class="sourceLineNo">888</span><a name="line.888"></a>
+<span class="sourceLineNo">889</span> protected synchronized boolean wasExecuted() {<a name="line.889"></a>
+<span class="sourceLineNo">890</span> return stackIndexes != null;<a name="line.890"></a>
+<span class="sourceLineNo">891</span> }<a name="line.891"></a>
+<span class="sourceLineNo">892</span><a name="line.892"></a>
+<span class="sourceLineNo">893</span> protected synchronized int[] getStackIndexes() {<a name="line.893"></a>
+<span class="sourceLineNo">894</span> return stackIndexes;<a name="line.894"></a>
+<span class="sourceLineNo">895</span> }<a name="line.895"></a>
+<span class="sourceLineNo">896</span><a name="line.896"></a>
+<span class="sourceLineNo">897</span> // ==========================================================================<a name="line.897"></a>
+<span class="sourceLineNo">898</span> // Internal methods - called by the ProcedureExecutor<a name="line.898"></a>
+<span class="sourceLineNo">899</span> // ==========================================================================<a name="line.899"></a>
+<span class="sourceLineNo">900</span><a name="line.900"></a>
+<span class="sourceLineNo">901</span> /**<a name="line.901"></a>
+<span class="sourceLineNo">902</span> * Internal method called by the ProcedureExecutor that starts the user-level code execute().<a name="line.902"></a>
+<span class="sourceLineNo">903</span> * @throws ProcedureSuspendedException This is used when procedure wants to halt processing and<a name="line.903"></a>
+<span class="sourceLineNo">904</span> * skip out without changing states or releasing any locks held.<a name="line.904"></a>
+<span class="sourceLineNo">905</span> */<a name="line.905"></a>
+<span class="sourceLineNo">906</span> protected Procedure<TEnvironment>[] doExecute(TEnvironment env)<a name="line.906"></a>
+<span class="sourceLineNo">907</span> throws ProcedureYieldException, ProcedureSuspendedException, InterruptedException {<a name="line.907"></a>
+<span class="sourceLineNo">908</span> try {<a name="line.908"></a>
<span class="sourceLineNo">909</span> updateTimestamp();<a name="line.909"></a>
-<span class="sourceLineNo">910</span> }<a name="line.910"></a>
-<span class="sourceLineNo">911</span> }<a name="line.911"></a>
-<span class="sourceLineNo">912</span><a name="line.912"></a>
-<span class="sourceLineNo">913</span> /**<a name="line.913"></a>
-<span class="sourceLineNo">914</span> * Internal method called by the ProcedureExecutor that starts the user-level code rollback().<a name="line.914"></a>
-<span class="sourceLineNo">915</span> */<a name="line.915"></a>
-<span class="sourceLineNo">916</span> protected void doRollback(TEnvironment env)<a name="line.916"></a>
-<span class="sourceLineNo">917</span> throws IOException, InterruptedException {<a name="line.917"></a>
-<span class="sourceLineNo">918</span> try {<a name="line.918"></a>
-<span class="sourceLineNo">919</span> updateTimestamp();<a name="line.919"></a>
-<span class="sourceLineNo">920</span> if (bypass) {<a name="line.920"></a>
-<span class="sourceLineNo">921</span> LOG.info("{} bypassed, skipping rollback", this);<a name="line.921"></a>
-<span class="sourceLineNo">922</span> return;<a name="line.922"></a>
-<span class="sourceLineNo">923</span> }<a name="line.923"></a>
-<span class="sourceLineNo">924</span> rollback(env);<a name="line.924"></a>
-<span class="sourceLineNo">925</span> } finally {<a name="line.925"></a>
+<span class="sourceLineNo">910</span> if (bypass) {<a name="line.910"></a>
+<span class="sourceLineNo">911</span> LOG.info("{} bypassed, returning null to finish it", this);<a name="line.911"></a>
+<span class="sourceLineNo">912</span> return null;<a name="line.912"></a>
+<span class="sourceLineNo">913</span> }<a name="line.913"></a>
+<span class="sourceLineNo">914</span> return execute(env);<a name="line.914"></a>
+<span class="sourceLineNo">915</span> } finally {<a name="line.915"></a>
+<span class="sourceLineNo">916</span> updateTimestamp();<a name="line.916"></a>
+<span class="sourceLineNo">917</span> }<a name="line.917"></a>
+<span class="sourceLineNo">918</span> }<a name="line.918"></a>
+<span class="sourceLineNo">919</span><a name="line.919"></a>
+<span class="sourceLineNo">920</span> /**<a name="line.920"></a>
+<span class="sourceLineNo">921</span> * Internal method called by the ProcedureExecutor that starts the user-level code rollback().<a name="line.921"></a>
+<span class="sourceLineNo">922</span> */<a name="line.922"></a>
+<span class="sourceLineNo">923</span> protected void doRollback(TEnvironment env)<a name="line.923"></a>
+<span class="sourceLineNo">924</span> throws IOException, InterruptedException {<a name="line.924"></a>
+<span class="sourceLineNo">925</span> try {<a name="line.925"></a>
<span class="sourceLineNo">926</span> updateTimestamp();<a name="line.926"></a>
-<span class="sourceLineNo">927</span> }<a name="line.927"></a>
-<span class="sourceLineNo">928</span> }<a name="line.928"></a>
-<span class="sourceLineNo">929</span><a name="line.929"></a>
-<span class="sourceLineNo">930</span> final void restoreLock(TEnvironment env) {<a name="line.930"></a>
-<span class="sourceLineNo">931</span> if (!lockedWhenLoading) {<a name="line.931"></a>
-<span class="sourceLineNo">932</span> LOG.debug("{} didn't hold the lock before restarting, skip acquiring lock.", this);<a name="line.932"></a>
-<span class="sourceLineNo">933</span> return;<a name="line.933"></a>
+<span class="sourceLineNo">927</span> if (bypass) {<a name="line.927"></a>
+<span class="sourceLineNo">928</span> LOG.info("{} bypassed, skipping rollback", this);<a name="line.928"></a>
+<span class="sourceLineNo">929</span> return;<a name="line.929"></a>
+<span class="sourceLineNo">930</span> }<a name="line.930"></a>
+<span class="sourceLineNo">931</span> rollback(env);<a name="line.931"></a>
+<span class="sourceLineNo">932</span> } finally {<a name="line.932"></a>
+<span class="sourceLineNo">933</span> updateTimestamp();<a name="line.933"></a>
<span class="sourceLineNo">934</span> }<a name="line.934"></a>
-<span class="sourceLineNo">935</span><a name="line.935"></a>
-<span class="sourceLineNo">936</span> if (isFinished()) {<a name="line.936"></a>
-<span class="sourceLineNo">937</span> LOG.debug("{} is already finished, skip acquiring lock.", this);<a name="line.937"></a>
-<span class="sourceLineNo">938</span> return;<a name="line.938"></a>
-<span class="sourceLineNo">939</span> }<a name="line.939"></a>
-<span class="sourceLineNo">940</span><a name="line.940"></a>
-<span class="sourceLineNo">941</span> if (isBypass()) {<a name="line.941"></a>
-<span class="sourceLineNo">942</span> LOG.debug("{} is already bypassed, skip acquiring lock.", this);<a name="line.942"></a>
-<span class="sourceLineNo">943</span> return;<a name="line.943"></a>
-<span class="sourceLineNo">944</span> }<a name="line.944"></a>
-<span class="sourceLineNo">945</span><a name="line.945"></a>
-<span class="sourceLineNo">946</span> LOG.debug("{} held the lock before restarting, call acquireLock to restore it.", this);<a name="line.946"></a>
-<span class="sourceLineNo">947</span> LockState state = acquireLock(env);<a name="line.947"></a>
-<span class="sourceLineNo">948</span> assert state == LockState.LOCK_ACQUIRED;<a name="line.948"></a>
-<span class="sourceLineNo">949</span> }<a name="line.949"></a>
-<span class="sourceLineNo">950</span><a name="line.950"></a>
-<span class="sourceLineNo">951</span> /**<a name="line.951"></a>
-<span class="sourceLineNo">952</span> * Internal method called by the ProcedureExecutor that starts the user-level code acquireLock().<a name="line.952"></a>
-<span class="sourceLineNo">953</span> */<a name="line.953"></a>
-<span class="sourceLineNo">954</span> final LockState doAcquireLock(TEnvironment env, ProcedureStore store) {<a name="line.954"></a>
-<span class="sourceLineNo">955</span> if (waitInitialized(env)) {<a name="line.955"></a>
-<span class="sourceLineNo">956</span> return LockState.LOCK_EVENT_WAIT;<a name="line.956"></a>
-<span class="sourceLineNo">957</span> }<a name="line.957"></a>
-<span class="sourceLineNo">958</span> if (lockedWhenLoading) {<a name="line.958"></a>
-<span class="sourceLineNo">959</span> // reset it so we will not consider it anymore<a name="line.959"></a>
-<span class="sourceLineNo">960</span> lockedWhenLoading = false;<a name="line.960"></a>
-<span class="sourceLineNo">961</span> locked = true;<a name="line.961"></a>
-<span class="sourceLineNo">962</span> // Here we return without persist the locked state, as lockedWhenLoading is true means<a name="line.962"></a>
-<span class="sourceLineNo">963</span> // that the locked field of the procedure stored in procedure store is true, so we do not need<a name="line.963"></a>
-<span class="sourceLineNo">964</span> // to store it again.<a name="line.964"></a>
-<span class="sourceLineNo">965</span> return LockState.LOCK_ACQUIRED;<a name="line.965"></a>
-<span class="sourceLineNo">966</span> }<a name="line.966"></a>
-<span class="sourceLineNo">967</span> LockState state = acquireLock(env);<a name="line.967"></a>
-<span class="sourceLineNo">968</span> if (state == LockState.LOCK_ACQUIRED) {<a name="line.968"></a>
-<span class="sourceLineNo">969</span> locked = true;<a name="line.969"></a>
-<span class="sourceLineNo">970</span> // persist that we have held the lock. This must be done before we actually execute the<a name="line.970"></a>
-<span class="sourceLineNo">971</span> // procedure, otherwise when restarting, we may consider the procedure does not have a lock,<a name="line.971"></a>
-<span class="sourceLineNo">972</span> // but it may have already done some changes as we have already executed it, and if another<a name="line.972"></a>
-<span class="sourceLineNo">973</span> // procedure gets the lock, then the semantic will be broken if the holdLock is true, as we do<a name="line.973"></a>
-<span class="sourceLineNo">974</span> // not expect that another procedure can be executed in the middle.<a name="line.974"></a>
-<span class="sourceLineNo">975</span> store.update(this);<a name="line.975"></a>
-<span class="sourceLineNo">976</span> }<a name="line.976"></a>
-<span class="sourceLineNo">977</span> return state;<a name="line.977"></a>
-<span class="sourceLineNo">978</span> }<a name="line.978"></a>
-<span class="sourceLineNo">979</span><a name="line.979"></a>
-<span class="sourceLineNo">980</span> /**<a name="line.980"></a>
-<span class="sourceLineNo">981</span> * Internal method called by the ProcedureExecutor that starts the user-level code releaseLock().<a name="line.981"></a>
-<span class="sourceLineNo">982</span> */<a name="line.982"></a>
-<span class="sourceLineNo">983</span> final void doReleaseLock(TEnvironment env, ProcedureStore store) {<a name="line.983"></a>
-<span class="sourceLineNo">984</span> locked = false;<a name="line.984"></a>
-<span class="sourceLineNo">985</span> // persist that we have released the lock. This must be done before we actually release the<a name="line.985"></a>
-<span class="sourceLineNo">986</span> // lock. Another procedure may take this lock immediately after we release the lock, and if we<a name="line.986"></a>
-<span class="sourceLineNo">987</span> // crash before persist the information that we have already released the lock, then when<a name="line.987"></a>
-<span class="sourceLineNo">988</span> // restarting there will be two procedures which both have the lock and cause problems.<a name="line.988"></a>
-<span class="sourceLineNo">989</span> if (getState() != ProcedureState.ROLLEDBACK) {<a name="line.989"></a>
-<span class="sourceLineNo">990</span> // If the state is ROLLEDBACK, it means that we have already deleted the procedure from<a name="line.990"></a>
-<span class="sourceLineNo">991</span> // procedure store, so do not need to log the release operation any more.<a name="line.991"></a>
-<span class="sourceLineNo">992</span> store.update(this);<a name="line.992"></a>
-<span class="sourceLineNo">993</span> }<a name="line.993"></a>
-<span class="sourceLineNo">994</span> releaseLock(env);<a name="line.994"></a>
-<span class="sourceLineNo">995</span> }<a name="line.995"></a>
-<span class="sourceLineNo">996</span><a name="line.996"></a>
-<span class="sourceLineNo">997</span> @Override<a name="line.997"></a>
-<span class="sourceLineNo">998</span> public int compareTo(final Procedure<TEnvironment> other) {<a name="line.998"></a>
-<span class="sourceLineNo">999</span> return Long.compare(getProcId(), other.getProcId());<a name="line.999"></a>
-<span class="sourceLineNo">1000</span> }<a name="line.1000"></a>
-<span class="sourceLineNo">1001</span><a name="line.1001"></a>
-<span class="sourceLineNo">1002</span> // ==========================================================================<a name="line.1002"></a>
-<span class="sourceLineNo">1003</span> // misc utils<a name="line.1003"></a>
-<span class="sourceLineNo">1004</span> // ==========================================================================<a name="line.1004"></a>
-<span class="sourceLineNo">1005</span><a name="line.1005"></a>
-<span class="sourceLineNo">1006</span> /**<a name="line.1006"></a>
-<span class="sourceLineNo">1007</span> * Get an hashcode for the specified Procedure ID<a name="line.1007"></a>
-<span class="sourceLineNo">1008</span> * @return the hashcode for the specified procId<a name="line.1008"></a>
-<span class="sourceLineNo">1009</span> */<a name="line.1009"></a>
-<span class="sourceLineNo">1010</span> public static long getProcIdHashCode(long procId) {<a name="line.1010"></a>
-<span class="sourceLineNo">1011</span> long h = procId;<a name="line.1011"></a>
-<span class="sourceLineNo">1012</span> h ^= h >> 16;<a name="line.1012"></a>
-<span class="sourceLineNo">1013</span> h *= 0x85ebca6b;<a name="line.1013"></a>
-<span class="sourceLineNo">1014</span> h ^= h >> 13;<a name="line.1014"></a>
-<span class="sourceLineNo">1015</span> h *= 0xc2b2ae35;<a name="line.1015"></a>
-<span class="sourceLineNo">1016</span> h ^= h >> 16;<a name="line.1016"></a>
-<span class="sourceLineNo">1017</span> return h;<a name="line.1017"></a>
-<span class="sourceLineNo">1018</span> }<a name="line.1018"></a>
-<span class="sourceLineNo">1019</span><a name="line.1019"></a>
-<span class="sourceLineNo">1020</span> /**<a name="line.1020"></a>
-<span class="sourceLineNo">1021</span> * Helper to lookup the root Procedure ID given a specified procedure.<a name="line.1021"></a>
-<span class="sourceLineNo">1022</span> */<a name="line.1022"></a>
-<span class="sourceLineNo">1023</span> protected static <T> Long getRootProcedureId(Map<Long, Procedure<T>> procedures,<a name="line.1023"></a>
-<span class="sourceLineNo">1024</span> Procedure<T> proc) {<a name="line.1024"></a>
-<span class="sourceLineNo">1025</span> while (proc.hasParent()) {<a name="line.1025"></a>
-<span class="sourceLineNo">1026</span> proc = procedures.get(proc.getParentProcId());<a name="line.1026"></a>
-<span class="sourceLineNo">1027</span> if (proc == null) {<a name="line.1027"></a>
-<span class="sourceLineNo">1028</span> return null;<a name="line.1028"></a>
-<span class="sourceLineNo">1029</span> }<a name="line.1029"></a>
-<span class="sourceLineNo">1030</span> }<a name="line.1030"></a>
-<span class="sourceLineNo">1031</span> return proc.getProcId();<a name="line.1031"></a>
-<span class="sourceLineNo">1032</span> }<a name="line.1032"></a>
-<span class="sourceLineNo">1033</span><a name="line.1033"></a>
-<span class="sourceLineNo">1034</span> /**<a name="line.1034"></a>
-<span class="sourceLineNo">1035</span> * @param a the first procedure to be compared.<a name="line.1035"></a>
-<span class="sourceLineNo">1036</span> * @param b the second procedure to be compared.<a name="line.1036"></a>
-<span class="sourceLineNo">1037</span> * @return true if the two procedures have the same parent<a name="line.1037"></a>
-<span class="sourceLineNo">1038</span> */<a name="line.1038"></a>
-<span class="sourceLineNo">1039</span> public static boolean haveSameParent(Procedure<?> a, Procedure<?> b) {<a name="line.1039"></a>
-<span class="sourceLineNo">1040</span> return a.hasParent() && b.hasParent() && (a.getParentProcId() == b.getParentProcId());<a name="line.1040"></a>
-<span class="sourceLineNo">1041</span> }<a name="line.1041"></a>
-<span class="sourceLineNo">1042</span>}<a name="line.1042"></a>
+<span class="sourceLineNo">935</span> }<a name="line.935"></a>
+<span class="sourceLineNo">936</span><a name="line.936"></a>
+<span class="sourceLineNo">937</span> final void restoreLock(TEnvironment env) {<a name="line.937"></a>
+<span class="sourceLineNo">938</span> if (!lockedWhenLoading) {<a name="line.938"></a>
+<span class="sourceLineNo">939</span> LOG.debug("{} didn't hold the lock before restarting, skip acquiring lock.", this);<a name="line.939"></a>
+<span class="sourceLineNo">940</span> return;<a name="line.940"></a>
+<span class="sourceLineNo">941</span> }<a name="line.941"></a>
+<span class="sourceLineNo">942</span><a name="line.942"></a>
+<span class="sourceLineNo">943</span> if (isFinished()) {<a name="line.943"></a>
+<span class="sourceLineNo">944</span> LOG.debug("{} is already finished, skip acquiring lock.", this);<a name="line.944"></a>
+<span class="sourceLineNo">945</span> return;<a name="line.945"></a>
+<span class="sourceLineNo">946</span> }<a name="line.946"></a>
+<span class="sourceLineNo">947</span><a name="line.947"></a>
+<span class="sourceLineNo">948</span> if (isBypass()) {<a name="line.948"></a>
+<span class="sourceLineNo">949</span> LOG.debug("{} is already bypassed, skip acquiring lock.", this);<a name="line.949"></a>
+<span class="sourceLineNo">950</span> return;<a name="line.950"></a>
+<span class="sourceLineNo">951</span> }<a name="line.951"></a>
+<span class="sourceLineNo">952</span><a name="line.952"></a>
+<span class="sourceLineNo">953</span> LOG.debug("{} held the lock before restarting, call acquireLock to restore it.", this);<a name="line.953"></a>
+<span class="sourceLineNo">954</span> LockState state = acquireLock(env);<a name="line.954"></a>
+<span class="sourceLineNo">955</span> assert state == LockState.LOCK_ACQUIRED;<a name="line.955"></a>
+<span class="sourceLineNo">956</span> }<a name="line.956"></a>
+<span class="sourceLineNo">957</span><a name="line.957"></a>
+<span class="sourceLineNo">958</span> /**<a name="line.958"></a>
+<span class="sourceLineNo">959</span> * Internal method called by the ProcedureExecutor that starts the user-level code acquireLock().<a name="line.959"></a>
+<span class="sourceLineNo">960</span> */<a name="line.960"></a>
+<span class="sourceLineNo">961</span> final LockState doAcquireLock(TEnvironment env, ProcedureStore store) {<a name="line.961"></a>
+<span class="sourceLineNo">962</span> if (waitInitialized(env)) {<a name="line.962"></a>
+<span class="sourceLineNo">963</span> return LockState.LOCK_EVENT_WAIT;<a name="line.963"></a>
+<span class="sourceLineNo">964</span> }<a name="line.964"></a>
+<span class="sourceLineNo">965</span> if (lockedWhenLoading) {<a name="line.965"></a>
+<span class="sourceLineNo">966</span> // reset it so we will not consider it anymore<a name="line.966"></a>
+<span class="sourceLineNo">967</span> lockedWhenLoading = false;<a name="line.967"></a>
+<span class="sourceLineNo">968</span> locked = true;<a name="line.968"></a>
+<span class="sourceLineNo">969</span> // Here we return without persist the locked state, as lockedWhenLoading is true means<a name="line.969"></a>
+<span class="sourceLineNo">970</span> // that the locked field of the procedure stored in procedure store is true, so we do not need<a name="line.970"></a>
+<span class="sourceLineNo">971</span> // to store it again.<a name="line.971"></a>
+<span class="sourceLineNo">972</span> return LockState.LOCK_ACQUIRED;<a name="line.972"></a>
+<span class="sourceLineNo">973</span> }<a name="line.973"></a>
+<span class="sourceLineNo">974</span> LockState state = acquireLock(env);<a name="line.974"></a>
+<span class="sourceLineNo">975</span> if (state == LockState.LOCK_ACQUIRED) {<a name="line.975"></a>
+<span class="sourceLineNo">976</span> locked = true;<a name="line.976"></a>
+<span class="sourceLineNo">977</span> // persist that we have held the lock. This must be done before we actually execute the<a name="line.977"></a>
+<span class="sourceLineNo">978</span> // procedure, otherwise when restarting, we may consider the procedure does not have a lock,<a name="line.978"></a>
+<span class="sourceLineNo">979</span> // but it may have already done some changes as we have already executed it, and if another<a name="line.979"></a>
+<span class="sourceLineNo">980</span> // procedure gets the lock, then the semantic will be broken if the holdLock is true, as we do<a name="line.980"></a>
+<span class="sourceLineNo">981</span> // not expect that another procedure can be executed in the middle.<a name="line.981"></a>
+<span class="sourceLineNo">982</span> store.update(this);<a name="line.982"></a>
+<span class="sourceLineNo">983</span> }<a name="line.983"></a>
+<span class="sourceLineNo">984</span> return state;<a name="line.984"></a>
+<span class="sourceLineNo">985</span> }<a name="line.985"></a>
+<span class="sourceLineNo">986</span><a name="line.986"></a>
+<span class="sourceLineNo">987</span> /**<a name="line.987"></a>
+<span class="sourceLineNo">988</span> * Internal method called by the ProcedureExecutor that starts the user-level code releaseLock().<a name="line.988"></a>
+<span class="sourceLineNo">989</span> */<a name="line.989"></a>
+<span class="sourceLineNo">990</span> final void doReleaseLock(TEnvironment env, ProcedureStore store) {<a name="line.990"></a>
+<span class="sourceLineNo">991</span> locked = false;<a name="line.991"></a>
+<span class="sourceLineNo">992</span> // persist that we have released the lock. This must be done before we actually release the<a name="line.992"></a>
+<span class="sourceLineNo">993</span> // lock. Another procedure may take this lock immediately after we release the lock, and if we<a name="line.993"></a>
+<span class="sourceLineNo">994</span> // crash before persist the information that we have already released the lock, then when<a name="line.994"></a>
+<span class="sourceLineNo">995</span> // restarting there will be two procedures which both have the lock and cause problems.<a name="line.995"></a>
+<span class="sourceLineNo">996</span> if (getState() != ProcedureState.ROLLEDBACK) {<a name="line.996"></a>
+<span class="sourceLineNo">997</span> // If the state is ROLLEDBACK, it means that we have already deleted the procedure from<a name="line.997"></a>
+<span class="sourceLineNo">998</span> // procedure store, so do not need to log the release operation any more.<a name="line.998"></a>
+<span class="sourceLineNo">999</span> store.update(this);<a name="line.999"></a>
+<span class="sourceLineNo">1000</span> }<a name="line.1000"></a>
+<span class="sourceLineNo">1001</span> releaseLock(env);<a name="line.1001"></a>
+<span class="sourceLineNo">1002</span> }<a name="line.1002"></a>
+<span class="sourceLineNo">1003</span><a name="line.1003"></a>
+<span class="sourceLineNo">1004</span> @Override<a name="line.1004"></a>
+<span class="sourceLineNo">1005</span> public int compareTo(final Procedure<TEnvironment> other) {<a name="line.1005"></a>
+<span class="sourceLineNo">1006</span> return Long.compare(getProcId(), other.getProcId());<a name="line.1006"></a>
+<span class="sourceLineNo">1007</span> }<a name="line.1007"></a>
+<span class="sourceLineNo">1008</span><a name="line.1008"></a>
+<span class="sourceLineNo">1009</span> // ==========================================================================<a name="line.1009"></a>
+<span class="sourceLineNo">1010</span> // misc utils<a name="line.1010"></a>
+<span class="sourceLineNo">1011</span> // ==========================================================================<a name="line.1011"></a>
+<span class="sourceLineNo">1012</span><a name="line.1012"></a>
+<span class="sourceLineNo">1013</span> /**<a name="line.1013"></a>
+<span class="sourceLineNo">1014</span> * Get an hashcode for the specified Procedure ID<a name="line.1014"></a>
+<span class="sourceLineNo">1015</span> * @return the hashcode for the specified procId<a name="line.1015"></a>
+<span class="sourceLineNo">1016</span> */<a name="line.1016"></a>
+<span class="sourceLineNo">1017</span> public static long getProcIdHashCode(long procId) {<a name="line.1017"></a>
+<span class="sourceLineNo">1018</span> long h = procId;<a name="line.1018"></a>
+<span class="sourceLineNo">1019</span> h ^= h >> 16;<a name="line.1019"></a>
+<span class="sourceLineNo">1020</span> h *= 0x85ebca6b;<a name="line.1020"></a>
+<span class="sourceLineNo">1021</span> h ^= h >> 13;<a name="line.1021"></a>
+<span class="sourceLineNo">1022</span> h *= 0xc2b2ae35;<a name="line.1022"></a>
+<span class="sourceLineNo">1023</span> h ^= h >> 16;<a name="line.1023"></a>
+<span class="sourceLineNo">1024</span> return h;<a name="line.1024"></a>
+<span class="sourceLineNo">1025</span> }<a name="line.1025"></a>
+<span class="sourceLineNo">1026</span><a name="line.1026"></a>
+<span class="sourceLineNo">1027</span> /**<a name="line.1027"></a>
+<span class="sourceLineNo">1028</span> * Helper to lookup the root Procedure ID given a specified procedure.<a name="line.1028"></a>
+<span class="sourceLineNo">1029</span> */<a name="line.1029"></a>
+<span class="sourceLineNo">1030</span> protected static <T> Long getRootProcedureId(Map<Long, Procedure<T>> procedures,<a name="line.1030"></a>
+<span class="sourceLineNo">1031</span> Procedure<T> proc) {<a name="line.1031"></a>
+<span class="sourceLineNo">1032</span> while (proc.hasParent()) {<a name="line.1032"></a>
+<span class="sourceLineNo">1033</span> proc = procedures.get(proc.getParentProcId());<a name="line.1033"></a>
+<span class="sourceLineNo">1034</span> if (proc == null) {<a name="line.1034"></a>
+<span class="sourceLineNo">1035</span> return null;<a name="line.1035"></a>
+<span class="sourceLineNo">1036</span> }<a name="line.1036"></a>
+<span class="sourceLineNo">1037</span> }<a name="line.1037"></a>
+<span class="sourceLineNo">1038</span> return proc.getProcId();<a name="line.1038"></a>
+<span class="sourceLineNo">1039</span> }<a name="line.1039"></a>
+<span class="sourceLineNo">1040</span><a name="line.1040"></a>
+<span class="sourceLineNo">1041</span> /**<a name="line.1041"></a>
+<span class="sourceLineNo">1042</span> * @param a the first procedure to be compared.<a name="line.1042"></a>
+<span class="sourceLineNo">1043</span> * @param b the second procedure to be compared.<a name="line.1043"></a>
+<span class="sourceLineNo">1044</span> * @return true if the two procedures have the same parent<a name="line.1044"></a>
+<span class="sourceLineNo">1045</span> */<a name="line.1045"></a>
+<span class="sourceLineNo">1046</span> public static boolean haveSameParent(Procedure<?> a, Procedure<?> b) {<a name="line.1046"></a>
+<span class="sourceLineNo">1047</span> return a.hasParent() && b.hasParent() && (a.getParentProcId() == b.getParentProcId());<a name="line.1047"></a>
+<span class="sourceLineNo">1048</span> }<a name="line.1048"></a>
+<span class="sourceLineNo">1049</span>}<a name="line.1049"></a>