You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by hmcl <gi...@git.apache.org> on 2017/10/25 06:57:15 UTC
[GitHub] storm pull request #2387: STORM-2787: storm-kafka-client KafkaSpout method o...
GitHub user hmcl opened a pull request:
https://github.com/apache/storm/pull/2387
STORM-2787: storm-kafka-client KafkaSpout method onPartitionsRevoked(...) should set initialized flag independently of processing guarantees
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hmcl/storm-apache Apache_master_STORM-2787_KSInitFlag
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2387
----
commit 95d10fc60669fdf6b28f28fd9a5536a905a9a26e
Author: Hugo Louro <hm...@gmail.com>
Date: 2017-10-23T00:44:54Z
STORM-2781: Refactor storm-kafka-client KafkaSpout Processing Guarantees
- Define processing guarantees as AT_LEAST_ONCE, AT_MOST_ONCE, NONE
- Refactor method name from setForceEnableTupleTracking to setTupleTrackingEnforced
- Throw IllegalStateException instead of IllegalArgumentException if spout attempts to emit an already committed message
- Update documentation to reflect these changes
commit 12473ed944a0f1499a2ba61987a223bd861e9768
Author: Hugo Louro <hm...@gmail.com>
Date: 2017-10-25T06:52:54Z
STORM-2787: storm-kafka-client KafkaSpout method onPartitionsRevoked(...) should set initialized flag independently of processing guarantees
----
---
[GitHub] storm issue #2387: STORM-2787: storm-kafka-client KafkaSpout method onPartit...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2387
Looks like 1.1.x branch also needs the patch, and that branch shouldn't be on top of STORM-2781.
https://github.com/apache/storm/blob/1.1.x-branch/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
@hmcl Could you craft a new PR against 1.1.x-branch if my understanding is right? Thanks in advance.
---
[GitHub] storm pull request #2387: STORM-2787: storm-kafka-client KafkaSpout method o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2387
---
[GitHub] storm issue #2387: STORM-2787: storm-kafka-client KafkaSpout method onPartit...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2387
@srdo @HeartSaVioR I have incorporated the code review changes of the depending patch. It should be good to merge. Thanks.
---
[GitHub] storm issue #2387: STORM-2787: storm-kafka-client KafkaSpout method onPartit...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2387
+1 for the change. It might be good to add a test that demonstrates the fix as well if possible.
---
[GitHub] storm issue #2387: STORM-2787: storm-kafka-client KafkaSpout method onPartit...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2387
@hmcl
Thanks, I merged into master.
Like STORM-2781 (#2380) we need another PR on 1.x branch. Please raise pull requests against 1.x branch. Thanks in advance.
---