You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/11 08:16:49 UTC
Review Request 28935: CLOUDSATCK-8062: test_multiple_ip_ranges.py -
Fix the test case to avoid using same vlan IP range in each test case
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28935/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8062
https://issues.apache.org/jira/browse/CLOUDSTACK-8062
Repository: cloudstack-git
Description
-------
Each test case in this test suite uses the same vlan IP range, adds it and deletes it. In some cases, the vlan IP range deletion fails due to this operation.
Change the test case to use different vlan IP range each time.
Other changes:
1) Fix imports
2) Remove Service dict from test case and use data from test_data.py instead.
3) Fix pep8 issues.
Diffs
-----
test/integration/component/test_multiple_ip_ranges.py 32c39f7
Diff: https://reviews.apache.org/r/28935/diff/
Testing
-------
yes.
Log:
Test add guest ip range in the existing cidr ... === TestName: test_01_add_ip_same_cidr | Status : SUCCESS ===
ok
Test add ip range in a new cidr ... === TestName: test_02_add_ip_diff_cidr | Status : SUCCESS ===
ok
Test delete ip range ... === TestName: test_03_del_ip_range | Status : SUCCESS ===
ok
Test adding non-contiguous ip range in existing cidr ... === TestName: test_04_add_noncontiguous_ip_range | Status : SUCCESS ===
ok
Test adding overlapped ip range in existing cidr ... === TestName: test_05_add_overlapped_ip_range | Status : SUCCESS ===
ok
Test adding overlapped ip range with two existing cidr ... === TestName: test_06_add_ip_range_overlapped_with_two_ranges | Status : SUCCESS ===
ok
Test adding ip range superset to existing CIDR ... === TestName: test_07_add_iprange_superset | Status : SUCCESS ===
ok
Test adding ip range subset to existing CIDR ... === TestName: test_08_add_iprange_subset | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 1.583s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 28935: CLOUDSATCK-8062: test_multiple_ip_ranges.py
- Fix
the test case to avoid using same vlan IP range in each test case
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28935/#review64722
-----------------------------------------------------------
Ship it!
7ff118c90b80a51efea73f87ac70dc686d92753b 4.5
- SrikanteswaraRao Talluri
On Dec. 11, 2014, 9 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28935/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 9 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8062
> https://issues.apache.org/jira/browse/CLOUDSTACK-8062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Each test case in this test suite uses the same vlan IP range, adds it and deletes it. In some cases, the vlan IP range deletion fails due to this operation.
>
> Change the test case to use different vlan IP range each time.
>
>
> Other changes:
> 1) Fix imports
> 2) Remove Service dict from test case and use data from test_data.py instead.
> 3) Fix pep8 issues.
>
>
> Diffs
> -----
>
> test/integration/component/test_multiple_ip_ranges.py 32c39f7
> tools/marvin/marvin/config/test_data.py 4b50afa
>
> Diff: https://reviews.apache.org/r/28935/diff/
>
>
> Testing
> -------
>
> yes.
>
> Log:
> Test add guest ip range in the existing cidr ... === TestName: test_01_add_ip_same_cidr | Status : SUCCESS ===
> ok
> Test add ip range in a new cidr ... === TestName: test_02_add_ip_diff_cidr | Status : SUCCESS ===
> ok
> Test delete ip range ... === TestName: test_03_del_ip_range | Status : SUCCESS ===
> ok
> Test adding non-contiguous ip range in existing cidr ... === TestName: test_04_add_noncontiguous_ip_range | Status : SUCCESS ===
> ok
> Test adding overlapped ip range in existing cidr ... === TestName: test_05_add_overlapped_ip_range | Status : SUCCESS ===
> ok
> Test adding overlapped ip range with two existing cidr ... === TestName: test_06_add_ip_range_overlapped_with_two_ranges | Status : SUCCESS ===
> ok
> Test adding ip range superset to existing CIDR ... === TestName: test_07_add_iprange_superset | Status : SUCCESS ===
> ok
> Test adding ip range subset to existing CIDR ... === TestName: test_08_add_iprange_subset | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 8 tests in 1.583s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28935: CLOUDSATCK-8062: test_multiple_ip_ranges.py
- Fix
the test case to avoid using same vlan IP range in each test case
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28935/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 2:30 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8062
https://issues.apache.org/jira/browse/CLOUDSTACK-8062
Repository: cloudstack-git
Description
-------
Each test case in this test suite uses the same vlan IP range, adds it and deletes it. In some cases, the vlan IP range deletion fails due to this operation.
Change the test case to use different vlan IP range each time.
Other changes:
1) Fix imports
2) Remove Service dict from test case and use data from test_data.py instead.
3) Fix pep8 issues.
Diffs (updated)
-----
test/integration/component/test_multiple_ip_ranges.py 32c39f7
tools/marvin/marvin/config/test_data.py 4b50afa
Diff: https://reviews.apache.org/r/28935/diff/
Testing
-------
yes.
Log:
Test add guest ip range in the existing cidr ... === TestName: test_01_add_ip_same_cidr | Status : SUCCESS ===
ok
Test add ip range in a new cidr ... === TestName: test_02_add_ip_diff_cidr | Status : SUCCESS ===
ok
Test delete ip range ... === TestName: test_03_del_ip_range | Status : SUCCESS ===
ok
Test adding non-contiguous ip range in existing cidr ... === TestName: test_04_add_noncontiguous_ip_range | Status : SUCCESS ===
ok
Test adding overlapped ip range in existing cidr ... === TestName: test_05_add_overlapped_ip_range | Status : SUCCESS ===
ok
Test adding overlapped ip range with two existing cidr ... === TestName: test_06_add_ip_range_overlapped_with_two_ranges | Status : SUCCESS ===
ok
Test adding ip range superset to existing CIDR ... === TestName: test_07_add_iprange_superset | Status : SUCCESS ===
ok
Test adding ip range subset to existing CIDR ... === TestName: test_08_add_iprange_subset | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 1.583s
OK
Thanks,
Gaurav Aradhye