You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/07 18:49:48 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request, #494: Upgrade go to 1.19, enforce in Makefile
HoustonPutman opened a new pull request, #494:
URL: https://github.com/apache/solr-operator/pull/494
Fixed #492
Will wait on #491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on pull request #494: Upgrade go to 1.19, enforce in Makefile
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #494:
URL: https://github.com/apache/solr-operator/pull/494#issuecomment-1306164108
I have to upgrade controller-gen because of incompatibilities with go 1.19, but it will be further updated in #491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #494: Upgrade go to 1.19, enforce in Makefile
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #494:
URL: https://github.com/apache/solr-operator/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on a diff in pull request #494: Upgrade go to 1.19, enforce in Makefile
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on code in PR #494:
URL: https://github.com/apache/solr-operator/pull/494#discussion_r1015886242
##########
Makefile:
##########
@@ -18,6 +18,13 @@ PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
# Produce CRDs that work back to Kubernetes 1.11 (no version conversion)
CRD_OPTIONS ?= "crd:trivialVersions=true,preserveUnknownFields=false"
+GO_VERSION = $(shell go version | sed -r 's/^.*([0-9]+\.[0-9]+\.[0-9]+).*$$/\1/g')
+REQUIRED_GO_VERSION = $(shell cat go.mod | grep -E 'go [1-9]\.[0-9]+' | sed -r 's/^go ([0-9]+\.[0-9]+)$$/\1/g')
+
+ifeq (,$(findstring $(REQUIRED_GO_VERSION),$(GO_VERSION)))
Review Comment:
[+1] I remember we talked about this being one of the reasons people ahve trouble running the operator smoke-tester and build, awesome to add a check in here for it.
##########
config/crd/bases/solr.apache.org_solrbackups.yaml:
##########
@@ -63,10 +63,14 @@ spec:
description: SolrBackup is the Schema for the solrbackups API
properties:
apiVersion:
- description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ description: 'APIVersion defines the versioned schema of this representation
Review Comment:
[-0] Ugh, these reformatting changes are unfortunate. No way around them I take it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #494: Upgrade go to 1.19, enforce in Makefile
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #494:
URL: https://github.com/apache/solr-operator/pull/494#discussion_r1015889065
##########
config/crd/bases/solr.apache.org_solrbackups.yaml:
##########
@@ -63,10 +63,14 @@ spec:
description: SolrBackup is the Schema for the solrbackups API
properties:
apiVersion:
- description: 'APIVersion defines the versioned schema of this representation of an object. Servers should convert recognized schemas to the latest internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ description: 'APIVersion defines the versioned schema of this representation
Review Comment:
No workaround. It'll probably get fixed when we upgrade the controller-gen version, but we will see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org