You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by se...@apache.org on 2017/10/11 10:46:35 UTC
[tika] branch master updated: [TIKA-2476] Making sure the trailing
space is not added
This is an automated email from the ASF dual-hosted git repository.
sergeyb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tika.git
The following commit(s) were added to refs/heads/master by this push:
new 369a04e [TIKA-2476] Making sure the trailing space is not added
369a04e is described below
commit 369a04ee2be4b28c2bed1f1119e8cb5805dbd9c8
Author: Sergey Beryozkin <sb...@gmail.com>
AuthorDate: Wed Oct 11 11:46:24 2017 +0100
[TIKA-2476] Making sure the trailing space is not added
---
.../src/main/java/org/apache/tika/metadata/Metadata.java | 5 ++++-
.../test/java/org/apache/tika/metadata/TestMetadata.java | 16 ++++++++++++++++
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/tika-core/src/main/java/org/apache/tika/metadata/Metadata.java b/tika-core/src/main/java/org/apache/tika/metadata/Metadata.java
index 843aaab..18c0cf0 100644
--- a/tika-core/src/main/java/org/apache/tika/metadata/Metadata.java
+++ b/tika-core/src/main/java/org/apache/tika/metadata/Metadata.java
@@ -538,7 +538,10 @@ public class Metadata implements CreativeCommons, Geographic, HttpHeaders,
for (int i = 0; i < names.length; i++) {
String[] values = _getValues(names[i]);
for (int j = 0; j < values.length; j++) {
- buf.append(names[i]).append("=").append(values[j]).append(" ");
+ if (buf.length() > 0) {
+ buf.append(" ");
+ }
+ buf.append(names[i]).append("=").append(values[j]);
}
}
return buf.toString();
diff --git a/tika-core/src/test/java/org/apache/tika/metadata/TestMetadata.java b/tika-core/src/test/java/org/apache/tika/metadata/TestMetadata.java
index 46b956d..490e3e8 100644
--- a/tika-core/src/test/java/org/apache/tika/metadata/TestMetadata.java
+++ b/tika-core/src/test/java/org/apache/tika/metadata/TestMetadata.java
@@ -468,4 +468,20 @@ public class TestMetadata {
assertEquals(meta1, meta2);
assertEquals(meta1.hashCode(), meta2.hashCode());
}
+
+ @Test
+ public void testToStringWithManyEntries() {
+ Metadata m = new Metadata();
+ m.add("key", "value1");
+ m.add("key", "value2");
+ m.add("key2", "value12");
+ assertEquals("key2=value12 key=value1 key=value2", m.toString());
+ }
+
+ @Test
+ public void testToStringWithSingleEntry() {
+ Metadata m = new Metadata();
+ m.add("key", "value1");
+ assertEquals("key=value1", m.toString());
+ }
}
--
To stop receiving notification emails like this one, please contact
['"commits@tika.apache.org" <co...@tika.apache.org>'].