You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/11 03:47:46 UTC

[GitHub] [hudi] Litianye commented on pull request #1719: [HUDI-1006]deltastreamer use kafkaSource with offset reset strategy:latest can't consume data

Litianye commented on pull request #1719:
URL: https://github.com/apache/hudi/pull/1719#issuecomment-642388711


   > I think we can replace empty string by `Option.empty()` https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java#L261
   > so we only needs to handle one case later. This will make the logic more straight forward. WDYT?
   
   It's a more logical solution, move all handle of checkpoint string into DeltaSync. Commit related change in this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org