[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2458: Opt format code

[GitBox <gi...@apache.org>]

jackxu2011 commented on code in PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#discussion_r918953442


##########
linkis-commons/linkis-storage/pom.xml:
##########
@@ -36,7 +36,6 @@
             <groupId>org.apache.linkis</groupId>
             <artifactId>linkis-common</artifactId>
             <version>${linkis.version}</version>
-            <scope>provided</scope>

Review Comment:
   the common and storage are all the shared module,  the provided scope is not need. and the storage miss the commons-lang3 jar,  which is import by runtime scope by other jars, so change the scope of linkis-common's scope to fix the dependency miss.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org