You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/12/11 01:47:56 UTC

Review Request: Adding google perftools in mesos.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8452/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

NOTE: The tar.gz is attached since the diff doesn't include it.

We will be using this for simulation performance analysis.
This is not something we want people to turn on in production, since there are issues with libunwind and glibc on 64 bit systems.


Diffs
-----

  src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
  third_party/Makefile.am ac39404523e172987381abe0812f832268d296d9 
  third_party/gperftools-2.0.tar.gz PRE-CREATION 
  third_party/libprocess/Makefile.am 6b68c69b07b831255d34a68d7b9b4b37eee55167 
  third_party/libprocess/third_party/Makefile.am 39fc33bc24d4d05de5c80970527e562a7946afa5 
  third_party/libprocess/third_party/gperftools-2.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/versions.am 8b47d2b958070285ca2ef7d6cfe2fe89b62e1e93 
  third_party/versions.am 09e1b578c7e3b1d65b192251ee60948eb998c2fe 

Diff: https://reviews.apache.org/r/8452/diff/


Testing
-------

In the second review: https://reviews.apache.org/r/8453/


Thanks,

Ben Mahler

Re: Review Request: Adding google perftools in mesos.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8452/#review14327
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Dec. 11, 2012, 12:48 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8452/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2012, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> NOTE: The tar.gz is attached since the diff doesn't include it.
> 
> We will be using this for simulation performance analysis.
> This is not something we want people to turn on in production, since there are issues with libunwind and glibc on 64 bit systems.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
>   third_party/Makefile.am ac39404523e172987381abe0812f832268d296d9 
>   third_party/gperftools-2.0.tar.gz PRE-CREATION 
>   third_party/libprocess/Makefile.am 6b68c69b07b831255d34a68d7b9b4b37eee55167 
>   third_party/libprocess/third_party/Makefile.am 39fc33bc24d4d05de5c80970527e562a7946afa5 
>   third_party/libprocess/third_party/gperftools-2.0.tar.gz PRE-CREATION 
>   third_party/libprocess/third_party/versions.am 8b47d2b958070285ca2ef7d6cfe2fe89b62e1e93 
>   third_party/versions.am 09e1b578c7e3b1d65b192251ee60948eb998c2fe 
> 
> Diff: https://reviews.apache.org/r/8452/diff/
> 
> 
> Testing
> -------
> 
> In the second review: https://reviews.apache.org/r/8453/
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Adding google perftools in mesos.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8452/
-----------------------------------------------------------

(Updated Dec. 11, 2012, 12:48 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Attached the perftools distribution.


Description
-------

NOTE: The tar.gz is attached since the diff doesn't include it.

We will be using this for simulation performance analysis.
This is not something we want people to turn on in production, since there are issues with libunwind and glibc on 64 bit systems.


Diffs
-----

  src/Makefile.am c94736df660a25b58dc47c07d9c56c3c26152a66 
  third_party/Makefile.am ac39404523e172987381abe0812f832268d296d9 
  third_party/gperftools-2.0.tar.gz PRE-CREATION 
  third_party/libprocess/Makefile.am 6b68c69b07b831255d34a68d7b9b4b37eee55167 
  third_party/libprocess/third_party/Makefile.am 39fc33bc24d4d05de5c80970527e562a7946afa5 
  third_party/libprocess/third_party/gperftools-2.0.tar.gz PRE-CREATION 
  third_party/libprocess/third_party/versions.am 8b47d2b958070285ca2ef7d6cfe2fe89b62e1e93 
  third_party/versions.am 09e1b578c7e3b1d65b192251ee60948eb998c2fe 

Diff: https://reviews.apache.org/r/8452/diff/


Testing
-------

In the second review: https://reviews.apache.org/r/8453/


Thanks,

Ben Mahler