You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/08/08 05:51:27 UTC
[jira] [Created] (HADOOP-7525) Make arguments to test-patch
optional
Make arguments to test-patch optional
-------------------------------------
Key: HADOOP-7525
URL: https://issues.apache.org/jira/browse/HADOOP-7525
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Tom White
Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved HADOOP-7525.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
I've just committed this. I'll work on getting the Jenkins job running.
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: HADOOP-7525.patch
>
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-7525:
------------------------------
Attachment: HADOOP-7525.patch
Here's a patch for this.
* I checked and test-patch.sh already uses smart-apply-patch.sh
* I removed the curl option since it wasn't used.
* I also added a {{--dirty-workspace}} that allows the workspace to have uncommitted changes in it. This is useful if you need to move some files around in SVN before applying your patch. It's also useful for testing changes to test-patch.sh itself.
Usage:
{noformat}
Usage: dev-support/test-patch.sh [options] patch-file | defect-number
Where:
patch-file is a local patch file containing the changes to test
defect-number is a JIRA defect number (e.g. 'HADOOP-1234') to test (Jenkins only)
Options:
--patch-dir=<dir> The directory for working and output files (default '/tmp')
--basedir=<dir> The directory to apply the patch to (default current directory)
--mvn-cmd=<cmd> The 'mvn' command to use (default $MAVEN_HOME/bin/mvn, or 'mvn')
--ps-cmd=<cmd> The 'ps' command to use (default 'ps')
--awk-cmd=<cmd> The 'awk' command to use (default 'awk')
--svn-cmd=<cmd> The 'svn' command to use (default 'svn')
--grep-cmd=<cmd> The 'grep' command to use (default 'grep')
--patch-cmd=<cmd> The 'patch' command to use (default 'patch')
--findbugs-home=<path> Findbugs home directory (default FINDBUGS_HOME environment variable)
--forrest-home=<path> Forrest home directory (default FORREST_HOME environment variable)
--dirty-workspace Allow the local SVN workspace to have uncommitted changes
Jenkins-only options:
--jenkins Run by Jenkins (runs tests and posts results to JIRA)
--support-dir=<dir> The directory to find support files in
--wget-cmd=<cmd> The 'wget' command to use (default 'wget')
--jira-cmd=<cmd> The 'jira' command to use (default 'jira')
--jira-password=<pw> The password for the 'jira' command
--eclipse-home=<path> Eclipse home directory (default ECLIPSE_HOME environment variable)
{noformat}
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
> Assignee: Tom White
> Attachments: HADOOP-7525.patch
>
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7525:
-------------------------------------------
Component/s: scripts
It probably should use smart-apply-patch.sh.
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081200#comment-13081200 ]
Aaron T. Myers commented on HADOOP-7525:
----------------------------------------
+1, this change looks great, Tom. I only tested the script *without* the {{--jenkins}} option, but that appears to have worked flawlessly.
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
> Assignee: Tom White
> Attachments: HADOOP-7525.patch
>
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081909#comment-13081909 ]
Hudson commented on HADOOP-7525:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #714 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/714/])
HADOOP-7525. Make arguments to test-patch optional.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1155551
Files :
* /hadoop/common/trunk/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/dev-support/test-patch.sh
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: HADOOP-7525.patch
>
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7525) Make arguments to test-patch
optional
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White reassigned HADOOP-7525:
---------------------------------
Assignee: Tom White
> Make arguments to test-patch optional
> -------------------------------------
>
> Key: HADOOP-7525
> URL: https://issues.apache.org/jira/browse/HADOOP-7525
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts
> Reporter: Tom White
> Assignee: Tom White
>
> Currently you have to specify all the arguments to test-patch.sh, which makes it cumbersome to use. We should make all arguments except the patch file optional.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira