You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/07/20 04:54:56 UTC
[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #2675: ci: Merge java/python/nodejs setup into Setup CI
Xuanwo opened a new pull request, #2675:
URL: https://github.com/apache/incubator-opendal/pull/2675
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2675: ci: Merge java/python/nodejs setup into Setup CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2675:
URL: https://github.com/apache/incubator-opendal/pull/2675#issuecomment-1643240541
> disappointed_relievedMerging them may not be a necessary thing. I think it's better to just keep configurations of core in setup action.
Yep, seems not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo closed pull request #2675: ci: Merge java/python/nodejs setup into Setup CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #2675: ci: Merge java/python/nodejs setup into Setup CI
URL: https://github.com/apache/incubator-opendal/pull/2675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2675: ci: Merge java/python/nodejs setup into Setup CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2675:
URL: https://github.com/apache/incubator-opendal/pull/2675#discussion_r1268951015
##########
.github/workflows/docs.yml:
##########
@@ -89,11 +85,10 @@ jobs:
steps:
- uses: actions/checkout@v3
- - uses: actions/setup-node@v3
+ - name: Setup CI
+ uses: ./.github/actions/setup
with:
- node-version: '18'
- cache: yarn
- cache-dependency-path: "bindings/nodejs/yarn.lock"
Review Comment:
In fact, they never been cached...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #2675: ci: Merge java/python/nodejs setup into Setup CI
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #2675:
URL: https://github.com/apache/incubator-opendal/pull/2675#discussion_r1268936683
##########
.github/workflows/docs.yml:
##########
@@ -89,11 +85,10 @@ jobs:
steps:
- uses: actions/checkout@v3
- - uses: actions/setup-node@v3
+ - name: Setup CI
+ uses: ./.github/actions/setup
with:
- node-version: '18'
- cache: yarn
- cache-dependency-path: "bindings/nodejs/yarn.lock"
Review Comment:
How to resolve this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org