You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/07 21:54:56 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38541: [SPARK-41034][CONNECT] Connect DataFrame should require RemoteSparkSession
amaliujia opened a new pull request, #38541:
URL: https://github.com/apache/spark/pull/38541
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Connect have marked the session parameter everywhere as `Optional`. This seems to be only useful for testing where test case can ignore the session parameter when it is not applicable.
However:
1. There are PySpark DataFrame API that returns SparkSession which is not optional. If Connect keep it as optional then we will have diff on such API.
2. Optional suggests `None` check which seems to not be necessary at many places (or forget to check `None` etc.)
This PR proposes to remove the `Optional` on the session from API interface.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
4. If you fix a bug, you can clarify why it is a bug.
-->
Maintainability
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38541:
URL: https://github.com/apache/spark/pull/38541#discussion_r1040531198
##########
python/pyspark/testing/connectutils.py:
##########
@@ -91,6 +92,10 @@ def _session_range(
def _session_sql(cls, query: str) -> "DataFrame":
return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore
+ @classmethod
+ def _with_plan(cls, plan: LogicalPlan) -> "DataFrame":
Review Comment:
I made a PR with a different way.
- https://github.com/apache/spark/pull/38928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
URL: https://github.com/apache/spark/pull/38541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38541:
URL: https://github.com/apache/spark/pull/38541#discussion_r1040495359
##########
python/pyspark/testing/connectutils.py:
##########
@@ -91,6 +92,10 @@ def _session_range(
def _session_sql(cls, query: str) -> "DataFrame":
return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore
+ @classmethod
+ def _with_plan(cls, plan: LogicalPlan) -> "DataFrame":
Review Comment:
Hi, @amaliujia . Unfortunately, this seems to break downstream CIs again by introducing `pandas` dependency back. In this PR, line 27 seems to be insufficient because `_with_plan` is a `classmethod`.
```
if have_pandas:
...
from pyspark.sql.connect.plan import LogicalPlan
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38541:
URL: https://github.com/apache/spark/pull/38541#issuecomment-1309846031
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38541:
URL: https://github.com/apache/spark/pull/38541#discussion_r1040524762
##########
python/pyspark/testing/connectutils.py:
##########
@@ -91,6 +92,10 @@ def _session_range(
def _session_sql(cls, query: str) -> "DataFrame":
return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore
+ @classmethod
+ def _with_plan(cls, plan: LogicalPlan) -> "DataFrame":
Review Comment:
Ya, it's also possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38541:
URL: https://github.com/apache/spark/pull/38541#discussion_r1040495359
##########
python/pyspark/testing/connectutils.py:
##########
@@ -91,6 +92,10 @@ def _session_range(
def _session_sql(cls, query: str) -> "DataFrame":
return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore
+ @classmethod
+ def _with_plan(cls, plan: LogicalPlan) -> "DataFrame":
Review Comment:
Hi, @amaliujia . Unfortunately, this seems to break downstream CIs again by introducing `pandas` dependency back. In this PR, line 27 seems to be insufficient because `_with_plan` is a `classmethod`.
```
if have_pandas:
...
from pyspark.sql.connect.plan import LogicalPlan
```
The following error happens.
```
NameError: name 'LogicalPlan' is not defined
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38541:
URL: https://github.com/apache/spark/pull/38541#issuecomment-1308071934
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38541: [SPARK-41034][CONNECT] Connect DataFrame should require RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38541:
URL: https://github.com/apache/spark/pull/38541#issuecomment-1306263740
@grundprinzip @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38541: [SPARK-41034][CONNECT][PYTHON] Connect DataFrame should require a RemoteSparkSession
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38541:
URL: https://github.com/apache/spark/pull/38541#discussion_r1040497034
##########
python/pyspark/testing/connectutils.py:
##########
@@ -91,6 +92,10 @@ def _session_range(
def _session_sql(cls, query: str) -> "DataFrame":
return DataFrame.withPlan(SQL(query), cls.connect) # type: ignore
+ @classmethod
+ def _with_plan(cls, plan: LogicalPlan) -> "DataFrame":
Review Comment:
> Hi, @amaliujia . Unfortunately, this seems to break downstream CIs again by introducing `pandas` dependency back. In this PR, line 27 seems to be insufficient because `_with_plan` is a `classmethod`.
>
> ```
>
> if have_pandas:
>
> ...
>
> from pyspark.sql.connect.plan import LogicalPlan
>
> ```
>
>
>
> The following error happens.
>
> ```
>
> NameError: name 'LogicalPlan' is not defined
>
> ```
I think we might be able to replace it with "LogicalPlan" in quotes and use the typing conditional import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org