[GitHub] gparai commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects

[GitBox <gi...@apache.org>]

gparai commented on a change in pull request #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r204951494
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
 ##########
 @@ -732,6 +732,25 @@ public void testPushFilterInExprPastAgg() throws Exception {
         .build().run();
   }
 
+  @Test
+  public void testTransitiveFilterPushPastAgg() throws Exception {
 
 Review comment:
   Moved testcase. I decided to remove the push filter past project rule from TC. It was causing too many side-effects (plan patterns breaking etc.). Moreover, it may not be very useful from a cost perspective. We can re-introduce it if it were to be applied in a cost-based manner (via Volcano planner).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services